mirror of
https://github.com/enso-org/enso.git
synced 2024-12-23 19:21:54 +03:00
6d3151f32d
`Vector.sort` does some custom method dispatch logic which always expected a function as `by` and `on` arguments. At the same time, `UnresolvedSymbol` is treated like a (to be resolved) `Function` and under normal circumstances there would be no difference between `_.foo` and `.foo` provided as arguments. Rather than adding an additional phase that does some form of eta-expansion, to accomodate for this custom dispatch, this change only fixes the problem locally. We accept `Function` and `UnresolvedSymbol` and perform the resolution on the fly. Ideally, we would have a specialization on the latter but again, it would be dependent on the contents of the `Vector` so unclear if that is better. Closes #6276, # Important Notes There was a suggestion to somehow modify our codegen to accomodate for this scenario but I went against it. In fact a lot of name literals have `isMethod` flag and that information is used in the passes but it should not control how (late) codegen is done. If we were to make this more generic, I would suggest maybe to add separate eta-expansion pass. But it could affect other things and could be potentially a significant change with limited potential initially, so potential future work item. |
||
|---|---|---|
| .. | ||
| Benchmarks | ||
| Examples_Tests | ||
| Geo_Tests | ||
| Google_Api_Test | ||
| Image_Tests | ||
| Meta_Test_Suite_Tests | ||
| micro-distribution | ||
| Table_Tests | ||
| Tests | ||
| Visualization_Tests | ||