mirror of
https://github.com/enso-org/enso.git
synced 2024-12-30 05:42:08 +03:00
9234d742cb
Implements #5640 and #5650 It made sense for me to implement those two together, as I wanted to make sure that the necessary widget API changes will support custom entry values for both dynamic and static data. - Added support for custom dropdown labels defined on the method annotations - Added shortening of static dropdown values, which resolves | dynamic dropdown - custom labels | static dropdown - automatic shortening | |-|-| |![image](https://user-images.githubusercontent.com/919491/220117241-8682736e-d750-4eeb-b9bb-cd6cfce42356.png)|![image](https://user-images.githubusercontent.com/919491/220117412-05ad7f4a-3ccf-468b-a976-c52395a497e2.png)| # Important Notes During implementation I had multiple data update order issues caused by FRP network forming a diamond shape. Two inputs that are often updated together were combined with `all` combinator, and that was further fed into the dropdown. This caused two updates to propagate through the whole network, and one of them was immediately outdated. To fix this and similar future scenarios, I've added an `next_tick` FRP node. It buffers the incoming events until the next browser microtask, preserving only the last received event. Currently if it is called inside a `requestAnimationFrame` callback, the effects of that processing will only be rendered in the next frame. Later this can be mitigated by delaying the rendering logic until the microtask queue is empty. |
||
---|---|---|
.. | ||
impl | ||
macros |