mirror of
https://github.com/enso-org/enso.git
synced 2024-12-21 19:31:41 +03:00
aa2f72cbd0
- Closes #6730 - Changes config to allow environment variables to override server host and port - Adds port scanning to Electron app to ensure the PM is started at a free port # Important Notes - `SERVER_PORT=abcd enso.AppImage` does NOT work. It would not be difficult to implement, but it probably needs discussion on how exactly it should be implemented - for example, `SERVER_PORT` is quite a generic name, should the Electron app pass though something like `ENSO_PM_SERVER_PORT` to the PM as `SERVER_PORT` instead? ⚠️ Port scanning is *only* implemented in the JS frontend. It is not implemented: - In Scala, because the JS/Rust code calling it needs to know the port as well. There shouldn't be any problems with adding port scanning though, if that's desired - In Rust, because I'm not sure parsing the host and port from a string is a good idea. - (This also applies to JS, but it *must* work in JS, and port scanning is already a dependency there so it's quite a bit easier) - QA *will* need a new PM (`sbt buildProjectManagerDistribution` or `./run backend sbt` -> `buildProjectManagerDistribution`), and the path must be supplied as: `-engine.project-manager-path=path/to/new/pm/here` |
||
|---|---|---|
| .. | ||
| src | ||
| tasks | ||
| bundle.ts | ||
| dist.ts | ||
| electron-builder-config.ts | ||
| entitlements.mac.plist | ||
| esbuild-config.ts | ||
| file-associations.ts | ||
| package.json | ||
| paths.ts | ||
| start.ts | ||
| tsconfig.json | ||
| watch.ts | ||