mirror of https://github.com/enso-org/enso.git synced 2024-12-20 22:01:34 +03:00

History

somebody1234 aa2f72cbd0 Allow configuring Project Manager server host and port (#6774 ) - Closes #6730 - Changes config to allow environment variables to override server host and port - Adds port scanning to Electron app to ensure the PM is started at a free port # Important Notes - `SERVER_PORT=abcd enso.AppImage` does NOT work. It would not be difficult to implement, but it probably needs discussion on how exactly it should be implemented - for example, `SERVER_PORT` is quite a generic name, should the Electron app pass though something like `ENSO_PM_SERVER_PORT` to the PM as `SERVER_PORT` instead? ⚠️ Port scanning is only implemented in the JS frontend. It is not implemented: - In Scala, because the JS/Rust code calling it needs to know the port as well. There shouldn't be any problems with adding port scanning though, if that's desired - In Rust, because I'm not sure parsing the host and port from a string is a good idea. - (This also applies to JS, but it must work in JS, and port scanning is already a dependency there so it's quite a bit easier) - QA will need a new PM (`sbt buildProjectManagerDistribution` or `./run backend sbt` -> `buildProjectManagerDistribution`), and the path must be supplied as: `-engine.project-manager-path=path/to/new/pm/here`	2023-08-25 07:33:31 +00:00
..
src	Allow configuring Project Manager server host and port (#6774 )	2023-08-25 07:33:31 +00:00
README.md	Add a markdown style guide (#1022 )	2020-07-21 13:59:40 +01:00

Allow configuring Project Manager server host and port (#6774 )

- Closes #6730
- Changes config to allow environment variables to override server host and port
- Adds port scanning to Electron app to ensure the PM is started at a free port

# Important Notes
- `SERVER_PORT=abcd enso.AppImage` does NOT work. It would not be difficult to implement, but it probably needs discussion on how exactly it should be implemented - for example, `SERVER_PORT` is quite a generic name, should the Electron app pass though something like `ENSO_PM_SERVER_PORT` to the PM as `SERVER_PORT` instead?

⚠️ Port scanning is *only* implemented in the JS frontend. It is not implemented:
- In Scala, because the JS/Rust code calling it needs to know the port as well. There shouldn't be any problems with adding port scanning though, if that's desired
- In Rust, because I'm not sure parsing the host and port from a string is a good idea.
- (This also applies to JS, but it *must* work in JS, and port scanning is already a dependency there so it's quite a bit easier)

- QA *will* need a new PM (`sbt buildProjectManagerDistribution` or `./run backend sbt` -> `buildProjectManagerDistribution`), and the path must be supplied as: `-engine.project-manager-path=path/to/new/pm/here`

2023-08-25 07:33:31 +00:00

src

Allow configuring Project Manager server host and port (#6774 )

2023-08-25 07:33:31 +00:00

README.md

Add a markdown style guide (#1022 )

2020-07-21 13:59:40 +01:00

README.md

Project Manager

This library implements the functionality and messages backing the project manager component of the Enso Protocol.