enso/app/gui/integration-test/project-view/collapsingAndEntering.spec.ts
Paweł Grabarz be1b706d0a
Function definition editor widget (#11655)
Fixes #11406

Also refactored the right panel state into its own store, so it is less coupled with the graph editor.

<img width="439" alt="image" src="https://github.com/user-attachments/assets/73e6bb92-235f-497d-9cff-126dc4110f8b">

The function definition widget tree displays the icon, name and all arguments. The name is editable, everything else right now is just read-only. The icons next to the arguments are just placeholders intended to be replaced with a "drag handle" icon.

Also fixed issues with missing rounded corners on the ag-grid widget.
<img width="263" alt="image" src="https://github.com/user-attachments/assets/cb61f62a-755c-4865-ba6c-ab9130167713">
2024-12-05 18:03:48 +00:00

247 lines
9.4 KiB
TypeScript

import { test, type Page } from '@playwright/test'
import * as actions from './actions'
import { expect } from './customExpect'
import { mockCollapsedFunctionInfo } from './expressionUpdates'
import { CONTROL_KEY } from './keyboard'
import * as locate from './locate'
import { edgesFromNode, edgesToNode } from './locate'
import { mockSuggestion } from './suggestionUpdates'
const MAIN_FILE_NODES = 12
const EDGE_PARTS = 2
const COLLAPSE_SHORTCUT = `${CONTROL_KEY}+G`
test('Entering nodes', async ({ page }) => {
await actions.goToGraph(page)
await mockCollapsedFunctionInfo(page, 'final', 'func1')
await expectInsideMain(page)
await expect(locate.navBreadcrumb(page)).toHaveText(['Mock Project'])
await locate.graphNodeByBinding(page, 'final').dblclick()
await mockCollapsedFunctionInfo(page, 'f2', 'func2')
await expectInsideFunc1(page)
await expect(locate.navBreadcrumb(page)).toHaveText(['Mock Project', 'func1'])
await locate.graphNodeByBinding(page, 'f2').dblclick()
await expectInsideFunc2(page)
await expect(locate.navBreadcrumb(page)).toHaveText(['Mock Project', 'func1', 'func2'])
})
test('Leaving entered nodes', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
await actions.exitFunction(page)
await expectInsideFunc1(page)
await actions.exitFunction(page)
await expectInsideMain(page)
})
test('Using breadcrumbs to navigate', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
await actions.exitFunction(page)
await expectInsideFunc1(page)
await actions.exitFunction(page)
await expectInsideMain(page)
// Breadcrumbs still have all the crumbs, but the last two are dimmed.
await expect(locate.navBreadcrumb(page)).toHaveText(['Mock Project', 'func1', 'func2'])
await expect(locate.navBreadcrumb(page).and(page.locator('.inactive'))).toHaveText([
'func1',
'func2',
])
await locate.navBreadcrumb(page).filter({ hasText: 'func2' }).click()
await expectInsideFunc2(page)
await locate.navBreadcrumb(page).filter({ hasText: 'Mock Project' }).click()
await expectInsideMain(page)
await locate.navBreadcrumb(page).filter({ hasText: 'func1' }).click()
await expectInsideFunc1(page)
})
test('Collapsing nodes', async ({ page }) => {
await actions.goToGraph(page)
const initialNodesCount = await locate.graphNode(page).count()
await mockCollapsedFunctionInfo(page, 'final', 'func1')
// Widgets may "steal" clicks, so we always click at icon.
await locate
.graphNodeByBinding(page, 'prod')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
await locate
.graphNodeByBinding(page, 'sum')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
await locate
.graphNodeByBinding(page, 'ten')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
await page.getByLabel('Group Selected Components').click()
await expect(locate.graphNode(page)).toHaveCount(initialNodesCount - 2)
await mockCollapsedFunctionInfo(page, 'prod', 'collapsed')
await mockSuggestion(page, {
type: 'method',
module: 'local.Mock_Project',
name: 'collapsed',
isStatic: true,
arguments: [{ name: 'five', reprType: 'Any', isSuspended: false, hasDefault: false }],
selfType: 'local.Mock_Project',
returnType: 'Standard.Base.Any.Any',
annotations: [],
})
const collapsedNode = locate.graphNodeByBinding(page, 'prod')
await expect(collapsedNode.locator('.WidgetApplication.prefix > .WidgetPort')).toExist()
await expect(collapsedNode.locator('.WidgetApplication.prefix > .WidgetPort')).toHaveText(
'Main.collapsed',
)
await expect(collapsedNode.locator('.WidgetTopLevelArgument')).toHaveText('five')
await locate.graphNodeIcon(collapsedNode).dblclick()
await expect(locate.graphNode(page)).toHaveCount(5)
await expect(locate.inputNode(page)).toHaveCount(1)
await expect(locate.graphNodeByBinding(page, 'ten')).toExist()
await expect(locate.graphNodeByBinding(page, 'sum')).toExist()
await expect(locate.graphNodeByBinding(page, 'prod')).toExist()
await locate
.graphNodeByBinding(page, 'ten')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
// Wait till node is selected.
await expect(locate.graphNodeByBinding(page, 'ten').and(page.locator('.selected'))).toHaveCount(1)
await page.keyboard.press(COLLAPSE_SHORTCUT)
await expect(locate.graphNode(page)).toHaveCount(5)
await expect(locate.inputNode(page)).toHaveCount(1)
const secondCollapsedNode = locate.graphNodeByBinding(page, 'ten')
await expect(secondCollapsedNode.locator('.WidgetToken')).toHaveText(['Main', '.', 'collapsed1'])
await mockCollapsedFunctionInfo(page, 'ten', 'collapsed1')
await secondCollapsedNode.dblclick()
await expect(locate.graphNode(page)).toHaveCount(2)
await expect(locate.graphNodeByBinding(page, 'ten')).toExist()
})
test('Input node', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
const inputNode = locate.inputNode(page)
await expect(inputNode).toHaveCount(1)
// Input node with identifier should have the icon and an identifier.
await expect(inputNode.locator('.WidgetIcon')).toHaveCount(1)
await expect(inputNode.locator('.WidgetToken')).toContainText('a')
await inputNode.click()
await page.keyboard.press('Delete')
await expect(inputNode).toHaveCount(1)
await inputNode.locator('.More').click({})
await expect(inputNode.getByTestId('removeNode')).toHaveClass(/(?<=^| )disabled(?=$| )/)
})
test('Output node', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
const outputNode = locate.outputNode(page)
await expect(outputNode).toHaveCount(1)
// Output node with identifier should have only icon and no displayed identifiers
await expect(outputNode.locator('.WidgetIcon')).toHaveCount(1)
await expect(outputNode.locator('.WidgetToken')).toHaveCount(0)
await outputNode.click()
await page.keyboard.press('Delete')
await expect(outputNode).toHaveCount(1)
await outputNode.locator('.More').click({})
await expect(outputNode.getByTestId('removeNode')).toHaveClass(/(?<=^| )disabled(?=$| )/)
})
test('Output node is not collapsed', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
await locate.outputNode(page).click({ modifiers: ['Shift'] })
await locate
.graphNodeByBinding(page, 'r')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
await page.getByLabel('Group Selected Components').click()
await expect(locate.graphNodeByBinding(page, 'r').locator('.WidgetToken')).toHaveText([
'Main',
'.',
'collapsed',
'a',
])
await expect(locate.inputNode(page)).toHaveCount(1)
})
test('Input node is not collapsed', async ({ page }) => {
await actions.goToGraph(page)
await enterToFunc2(page)
await locate
.graphNodeByBinding(page, 'r')
.locator('.grab-handle')
.click({ modifiers: ['Shift'] })
await locate.inputNode(page).click({ modifiers: ['Shift'] })
await page.getByLabel('Group Selected Components').click()
await expect(locate.graphNodeByBinding(page, 'r').locator('.WidgetToken')).toHaveText([
'Main',
'.',
'collapsed',
'a',
])
await expect(locate.outputNode(page)).toHaveCount(1)
})
async function expectInsideMain(page: Page) {
await actions.expectNodePositionsInitialized(page, -16)
await expect(locate.graphNode(page)).toHaveCount(MAIN_FILE_NODES)
await expect(locate.graphNodeByBinding(page, 'five')).toExist()
await expect(locate.graphNodeByBinding(page, 'ten')).toExist()
await expect(locate.graphNodeByBinding(page, 'sum')).toExist()
await expect(locate.graphNodeByBinding(page, 'prod')).toExist()
await expect(locate.graphNodeByBinding(page, 'final')).toExist()
await expect(locate.graphNodeByBinding(page, 'list')).toExist()
await expect(locate.graphNodeByBinding(page, 'data')).toExist()
await expect(locate.graphNodeByBinding(page, 'aggregated')).toExist()
await expect(locate.graphNodeByBinding(page, 'filtered')).toExist()
await expect(locate.graphNodeByBinding(page, 'autoscoped')).toExist()
}
async function expectInsideFunc1(page: Page) {
await actions.expectNodePositionsInitialized(page, -88)
await expect(locate.graphNode(page)).toHaveCount(4)
await expect(locate.inputNode(page)).toHaveCount(1)
await expect(locate.graphNodeByBinding(page, 'f2')).toExist()
await expect(locate.graphNodeByBinding(page, 'result')).toExist()
await expect(locate.outputNode(page)).toHaveCount(1)
await expect(await edgesFromNode(page, locate.inputNode(page))).toHaveCount(EDGE_PARTS)
await expect(await edgesToNode(page, locate.outputNode(page))).toHaveCount(EDGE_PARTS)
}
async function expectInsideFunc2(page: Page) {
await actions.expectNodePositionsInitialized(page, -88)
await expect(locate.graphNode(page)).toHaveCount(3)
await expect(locate.inputNode(page)).toHaveCount(1)
await expect(locate.graphNodeByBinding(page, 'r')).toExist()
await expect(locate.outputNode(page)).toHaveCount(1)
await expect(await edgesFromNode(page, locate.inputNode(page))).toHaveCount(EDGE_PARTS)
await expect(await edgesToNode(page, locate.outputNode(page))).toHaveCount(EDGE_PARTS)
}
async function enterToFunc2(page: Page) {
await mockCollapsedFunctionInfo(page, 'final', 'func1')
await locate.graphNodeByBinding(page, 'final').dblclick()
await expectInsideFunc1(page)
await mockCollapsedFunctionInfo(page, 'f2', 'func2')
await locate.graphNodeByBinding(page, 'f2').dblclick()
await expectInsideFunc2(page)
}