mirror of
https://github.com/enso-org/enso.git
synced 2024-12-19 20:21:36 +03:00
c2b82b9934
Fixes https://www.pivotaltracker.com/story/show/182926584 [Task link](https://www.pivotaltracker.com/story/show/183426449) This PR fixes an IDE freeze introduced by https://github.com/enso-org/enso/pull/3732 and reimplements reverting edited nodes to their previous state. The cause of the IDE freeze is quite interesting. A detailed investigation is available [here](https://gist.github.com/vitvakatu/785e34881368b8cfda61715d7543cbd0). The graph editor needs to update the Presenter state only if the user is editing the node. Before this PR, the graph editor notified the Presenter with a visual representation of the node content instead of code expression. It caused inconsistency between the states of the controller and Presenter and caused severe performance issues. https://user-images.githubusercontent.com/6566674/195831224-6d6e8258-e347-48b4-890a-d89c7300bc39.mp4 # Important Notes - ~~There is a more complex alternative solution – it requires refactoring of the `component::node::input::area` module. The Presenter can be notified with `expression.code` changes, not `expression.viz_code`. I found a simpler solution (`.gate(&edit_mode)`), which has the same effect but does not require additional refactoring.~~ Said solution is implemented in a separate commit |
||
|---|---|---|
| .. | ||
| component-list-panel-view | ||
| icons | ||
| interface | ||
| src | ||
| visualization | ||
| Cargo.toml | ||