mirror of
https://github.com/enso-org/enso.git
synced 2024-12-19 02:11:29 +03:00
4ebf637fd4
[ci no changelog needed] [Task link](https://www.pivotaltracker.com/story/show/181725003) This PR implements a fully visible component group header while scrolling the group (using the ScrollArea). The header moves in sync with scrolling movements (using new `set_header_pos` FRP input), so it looks like the component group is scrolled. ScrollArea masks the "scrolled" entries above the header. This design allows a fully visible header even though our renderer doesn't support nested layers masking yet. The screencast: https://user-images.githubusercontent.com/6566674/168320360-2c2017b2-0ef5-42ce-9c79-82b9641c1d73.mp4 The most recent one, with the updated demo scene from develop: https://user-images.githubusercontent.com/6566674/168555268-8552c4b0-f887-4388-89a1-e65ddf668be6.mp4 # Important Notes - I fixed the API of the list view so now it supports non-hardcoded scene layers (previously it did not). I also believe it was implemented incorrectly. - I've found a [pretty weird bug](https://www.pivotaltracker.com/story/show/182193824): the component group inside the ScrollArea is invisible unless I add some arbitrary shape to the scroll area content. I use a `transparent_circle` for this purpose in the demo scene. The bug is probably related to masking the sublayers, though I wasn't able to reproduce it properly on a simpler example. - The selection box is removed from the demo scene as agreed with @farmaazon . The correct implementation has proven to be much harder than I expected, and we will implement another approach in a separate PR. - I also modified the `shadow::Parameters` so that it uses `Var`s instead of plain values. |
||
|---|---|---|
| .. | ||
| component-group | ||
| src | ||
| Cargo.toml | ||