diff --git a/CHANGELOG.md b/CHANGELOG.md index 27b0bb73..5e9db7b1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Added - support reverse tabbing using shift+tab ([#92](https://github.com/extrawurst/gitui/issues/92)) +- switch to using cmd line args instead of `ENV` (`-l` for logging and `--version`) **please convert your GITUI_LOGGING usage** [[@shenek](https://github.com/shenek)] ([#88](https://github.com/extrawurst/gitui/issues/88)) ## [0.4.0] - 2020-05-25 diff --git a/Makefile b/Makefile index ec86e572..68184bbf 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ .PHONY: debug build-release release-linux-musl test clippy clippy-pedantic install install-debug debug: - GITUI_LOGGING=true cargo run --features=timing + cargo run --features=timing -- -l build-release: cargo build --release diff --git a/README.md b/README.md index 87e6b3d7..68863e3d 100644 --- a/README.md +++ b/README.md @@ -88,7 +88,7 @@ cargo install gitui to enable logging: ``` -GITUI_LOGGING=true gitui +gitui -l ``` this will log to: diff --git a/src/main.rs b/src/main.rs index f45aa387..6475178b 100644 --- a/src/main.rs +++ b/src/main.rs @@ -227,16 +227,14 @@ fn process_cmdline() -> Result<()> { .version(crate_version!()) .about(crate_description!()) .arg( - Arg::with_name("gitui-logging") + Arg::with_name("logging") .help("Stores logging output into a cache directory") .short("l") - .long("gitui-logging") - .takes_value(false) - .required(false), + .long("logging"), ); let arg_matches = app.get_matches(); - if arg_matches.is_present("gitui-logging") { + if arg_matches.is_present("logging") { setup_logging()?; }