From 28d53fce303a12a3e38ef9ccfc0d263c9d1aa64b Mon Sep 17 00:00:00 2001 From: Bartosz Nitka Date: Tue, 14 Mar 2017 04:50:10 -0700 Subject: [PATCH] Remove ruleIntersect2 Summary: It is no longer necessary after D4676812 and D4698788. `"I have 9 am 12 pm 1 pm 2pm 4 pm 3 pm on Saturday"` now works in less than a second, it used to be 10s. The test suite also got 3s faster. Reviewed By: patapizza Differential Revision: D4701890 fbshipit-source-id: 107a55f --- Duckling/Ranking/Classifiers/DA.hs | 700 +++++++---------- Duckling/Ranking/Classifiers/EN.hs | 1119 +++++++++++----------------- Duckling/Ranking/Classifiers/NB.hs | 693 +++++++---------- Duckling/Ranking/Classifiers/PT.hs | 555 ++++++-------- Duckling/Ranking/Classifiers/SV.hs | 786 ++++++++----------- Duckling/Time/DA/Rules.hs | 14 - Duckling/Time/EN/Rules.hs | 13 - Duckling/Time/NB/Rules.hs | 14 - Duckling/Time/PT/Rules.hs | 14 - Duckling/Time/SV/Rules.hs | 14 - 10 files changed, 1443 insertions(+), 2479 deletions(-) diff --git a/Duckling/Ranking/Classifiers/DA.hs b/Duckling/Ranking/Classifiers/DA.hs index 8b59ccbd..96a57e5d 100644 --- a/Duckling/Ranking/Classifiers/DA.hs +++ b/Duckling/Ranking/Classifiers/DA.hs @@ -54,150 +54,6 @@ classifiers koData = ClassData{prior = -infinity, unseen = -0.6931471805599453, likelihoods = HashMap.fromList [], n = 0}}), - ("intersect2", - Classifier{okData = - ClassData{prior = -0.46724246780440765, - unseen = -5.869296913133774, - likelihoods = - HashMap.fromList - [(" - (interval)on ", - -4.074708587705242), - (" - (interval)on ", - -4.074708587705242), - ("hourday", -5.173320876373351), - ("dayhour", -2.9220290777668563), - ("daymonth", -3.1584178558310865), - ("monthyear", -3.0938793346935154), - ("intersecthh:mm", -5.173320876373351), - ("the (ordinal)named-month", - -3.9205579078779835), - ("intersect by \"of\", \"from\", \"'s\"year", - -4.767855768265187), - ("intersect2hh:mm", -5.173320876373351), - ("last of