From 9151f9e1ab8c085648dba4a22c4b530fe2932a6b Mon Sep 17 00:00:00 2001 From: Steven Troxler Date: Thu, 13 May 2021 11:12:25 -0700 Subject: [PATCH] Specify where the note on regex + text lives Summary: I spent a surprising amount of time trying to figure out what this comment was referring to because it wasn't at all clear to me that it meant a comment in another file. Making it more specific Reviewed By: chessai Differential Revision: D28411103 fbshipit-source-id: 26cd29b47367a7e0d865f616f289fef570544c39 --- Duckling/Engine.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Duckling/Engine.hs b/Duckling/Engine.hs index 1ef59915..47b28b35 100644 --- a/Duckling/Engine.hs +++ b/Duckling/Engine.hs @@ -86,8 +86,8 @@ lookupRegexCommon -> Duckling [Node] lookupRegexCommon doc regex position matchFun = return nodes where - -- See Note [Regular expressions and Text] to understand what's going - -- on here + -- See Note [Regular expressions and Text] from Document.hs to understand + -- what's going on here (substring, rangeToText, translateRange) = Document.byteStringFromPos doc position nodes = mapMaybe (f . Array.elems)