facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2024-12-11 06:46:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

Time: don't parse at + phone number

Browse Source 
Summary: Fixes #95.

Reviewed By: blandinw

Differential Revision: D6129893

fbshipit-source-id: e863021
This commit is contained in:
Julien Odent 2017-10-23 16:16:03 -07:00 committed by Facebook Github Bot
parent 1ade1935b2
commit 980c0f279e
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Duckling/Time/EN/Corpus.hs
View File

@ -90,6 +90,8 @@ negativeCorpus = (testContext, examples)
, "rat 6" , "rat 6"
, "3 30" , "3 30"
, "three twenty" , "three twenty"
, "at 650.650.6500"
, "at 650-650-6500"
] ]
allExamples :: [Example] allExamples :: [Example]

2
Duckling/Time/EN/Rules.hs
View File

@ -505,7 +505,7 @@ ruleHHMMLatent :: Rule
ruleHHMMLatent = Rule ruleHHMMLatent = Rule
{ name = "hhmm (latent)" { name = "hhmm (latent)"
, pattern = , pattern =
[ regex "((?:[01]?\\d)|(?:2[0-3]))([0-5]\\d)" [ regex "((?:[01]?\\d)|(?:2[0-3]))([0-5]\\d)(?!.\\d)"
] ]
, prod = \tokens -> case tokens of , prod = \tokens -> case tokens of
(Token RegexMatch (GroupMatch (hh:mm:_)):_) -> do (Token RegexMatch (GroupMatch (hh:mm:_)):_) -> do

1
tests/Duckling/Time/EN/Tests.hs
View File

@ -102,4 +102,5 @@ intersectTests = testCase "Intersect Test" $
xs = [ ("tomorrow July", 2) xs = [ ("tomorrow July", 2)
, ("Mar tonight", 2) , ("Mar tonight", 2)
, ("Feb tomorrow", 1) -- we are in February , ("Feb tomorrow", 1) -- we are in February
, ("at 615.", 1) -- make sure ruleHHMMLatent allows this
] ]