From fc5278855dcd61405e308e16fa1053dc970f728a Mon Sep 17 00:00:00 2001 From: Steven Troxler Date: Mon, 8 Mar 2021 13:41:05 -0800 Subject: [PATCH] Combine duplicated examples Summary: I was looking at adding support for "next week" constructions in Spanish to close https://github.com/facebook/duckling/issues/553 (which it appears has already been handled), when I noticed that the equivalent logic for English has been split into two separate examples: "coming week" isn't in the same example as other equivalent constructs like "upcoming week" and "next week". This diff combines them, which I think is clearer and fewer lines of code Reviewed By: chessai Differential Revision: D26892322 fbshipit-source-id: 68ca4644759198fc79d963ae080495c3f2d4a923 --- Duckling/Time/EN/Corpus.hs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Duckling/Time/EN/Corpus.hs b/Duckling/Time/EN/Corpus.hs index 3b0749c5..b444afd6 100644 --- a/Duckling/Time/EN/Corpus.hs +++ b/Duckling/Time/EN/Corpus.hs @@ -323,9 +323,6 @@ allExamples = concat [ "this week" , "current week" ] - , examples (datetime (2013, 2, 18, 0, 0, 0) Week) - [ "coming week" - ] , examples (datetime (2013, 2, 4, 0, 0, 0) Week) [ "last week" , "past week" @@ -336,6 +333,7 @@ allExamples = concat , "the following week" , "around next week" , "upcoming week" + , "coming week" ] , examples (datetime (2013, 1, 1, 0, 0, 0) Month) [ "last month"