Summary:
Applied fix mentioned in https://github.com/facebook/duckling/issues/671 to resolve https://github.com/facebook/duckling/issues/671
Since, no PR to fix this is present, I simply open a PR with the suggestion of AbstractUmbra.
The suggested fix seems to work (Docker Image builds and is operational)
Pull Request resolved: https://github.com/facebook/duckling/pull/685
Test Plan:
The author verified that the docker image works - it was missing some dependencies before.
There's no way to test this in sigma, but the change makes sense.
Reviewed By: haoxuany
Differential Revision: D34697708
Pulled By: stroxler
fbshipit-source-id: 2731604e136acfd74d4eedf3bf309f79894bb981
Summary:
The Dockerfile build part did not copy the Duckling implementation into the container, making the build fail.
I also harmonized the target Debian to Buster, that is the one currently hidden behind `haskell:8`.
Pull Request resolved: https://github.com/facebook/duckling/pull/539
Reviewed By: patapizza
Differential Revision: D24688839
Pulled By: chessai
fbshipit-source-id: 0ffcc4d28a599b7edad668730117828d26e116ad
Summary:
* Reduces size of final image from 5GB to 130MB
* Builds any checkout (not locked to the master)
* Doesn't run stack on CMD (executes static build of Duckling instead)
Pull Request resolved: https://github.com/facebook/duckling/pull/341
Reviewed By: chinmay87
Differential Revision: D21083018
Pulled By: patapizza
fbshipit-source-id: d909158f20f5b8da5b0248a25103b850797bc3a3
Summary:
I had trouble building the Docker image on a mac because `stack build` was trying to use all the cores and subsequently running out of memory. It took me a while to find the right flag, so I added a note to the dockerfile.
Closes https://github.com/facebook/duckling/pull/135
Differential Revision: D6655605
Pulled By: patapizza
fbshipit-source-id: 559c9fde175ad89f64b5c487afb77e3b7d5b982f
Summary:
With the current Dockerfile, I get errors when trying to build:
```
Downloading lts-8.8 build plan ...
Downloaded lts-8.8 build plan.
Updating package index Hackage (mirrored at https://s3.amazonaws.com/hackage.fpcomplete.com/) ...
Selected mirror https://s3.amazonaws.com/hackage.fpcomplete.com/
Downloading root
Selected mirror https://s3.amazonaws.com/hackage.fpcomplete.com/
Downloading timestamp
Downloading snapshot
Downloading mirrors
Cannot update index (no local copy)
Downloading index
Updated package list downloaded
Populating index cache ...
Populated index cache.
Compiler version mismatched, found ghc-8.2.1 (x86_64), but expected minor version match with ghc-8.0.2 (x86_64) (based on resolver setting in /duckling/stack.yaml).
To install the correct GHC into /root/.stack/programs/x86_64-linux/, try running "stack setup" or use the "--install-ghc" flag.
The command '/bin/sh -c stack build' returned a non-zero code: 1
```
With these fixes, I run `stack setup` inside the docker image in case it was not setup previously on the host machine.
Closes https://github.com/facebookincubator/duckling/pull/98
Differential Revision: D6174261
Pulled By: patapizza
fbshipit-source-id: 4719d94
