facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2024-10-27 14:26:54 +03:00
Code Issues Packages Projects Releases Wiki Activity
21 Commits 1 Branch 9 Tags 12 MiB
41800a3171
Commit Graph

4 Commits

Author SHA1 Message Date
Jonathan Coens
41800a3171 Move onto dependent-sum instead of custom local data Some 
Summary:
No need to reinvent the wheel when `dependent-sum` has what we need. I re-export `Some(..)` from `Duckling.Dimensions.Types` to cut down on import bloat.
Instead of a `Read` instance I created a `fromName` function.

Reviewed By: zilberstein

Differential Revision: D4710014

fbshipit-source-id: 1d4e86d
 2017-03-15 10:34:17 -07:00
Jonathan Coens
1b91b70c58 codemod DNumber to Numeral 
Summary: `DNumber` is a terrible name and was only there because legacy. `Numeral` makes more sense for this dimension, so let's use that instead.

Reviewed By: patapizza

Differential Revision: D4707167

fbshipit-source-id: cd78aa3
 2017-03-14 13:34:11 -07:00
Julien Odent
ab06262291 Strip off TODO/FIXME 
Summary: as the title says

Differential Revision: D4682120

fbshipit-source-id: 3f66286
 2017-03-10 12:04:16 -08:00
FBShipIt
3f8e52e70a Initial commit 
fbshipit-source-id: 301a10f448e9623aa1c953544f42de562909e192
 2017-03-08 10:33:56 -08:00