facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2025-01-06 04:53:13 +03:00
Code Issues Packages Projects Releases Wiki Activity
95 Commits 1 Branch 9 Tags 13 MiB
ff9b54ad43
Commit Graph

3 Commits

Author SHA1 Message Date
Bartosz Nitka
74936df848 Make matching anywhere vs at pos obvious 
Summary:
This change refactors the Engine to use a different
code path for when we're calling `lookupItem` to find
a first token `Node` matching the rule and a different
one for subsequent ones.

This division lets us get better invariants and more importantly
do full text regexp matches only when necessary.

This should be particularly useful for longer texts.

Reviewed By: patapizza

Differential Revision: D4953918

fbshipit-source-id: e3a69ad
 2017-04-28 09:19:20 -07:00
Bartosz Nitka
e7aeef5436 Avoid allocations and encoding in regexp matching 
Summary: The rationale is explained in a new Note.

Reviewed By: patapizza

Differential Revision: D4884104

fbshipit-source-id: 81f36ee
 2017-04-14 12:19:21 -07:00
FBShipIt
3f8e52e70a Initial commit 
fbshipit-source-id: 301a10f448e9623aa1c953544f42de562909e192
 2017-03-08 10:33:56 -08:00