6 Commits

Author	SHA1	Message	Date
Matt Schultz	ff9b54ad43	Added English fractional Numeral rule (ex: "3/4", "1/2", "5/7") ... Summary: Also added real-world test to English `Quantity` corpus ("3/4 cup", as a culinary example) Closes https://github.com/facebookincubator/duckling/pull/14 Reviewed By: patapizza Differential Revision: D5035990 Pulled By: niteria fbshipit-source-id: c1b8f65	2017-05-10 07:04:16 -07:00
Bartosz Nitka	bd94622f64	Move tests to tests and exes to exe ... Summary: This works around https://github.com/haskell/cabal/issues/4350 If we don't do this files get compiled multiple times and cabal is unhappy. Reviewed By: patapizza Differential Revision: D4782749 fbshipit-source-id: 5bbe425	2017-03-27 16:04:24 -07:00
Julien Odent	54c9448fba	Rename Number to Numeral ... Summary: For consistency with the dimension name. Reviewed By: JonCoens Differential Revision: D4722216 fbshipit-source-id: 82c56d3	2017-03-16 13:49:16 -07:00
Jonathan Coens	41800a3171	Move onto dependent-sum instead of custom local data Some ... Summary: No need to reinvent the wheel when `dependent-sum` has what we need. I re-export `Some(..)` from `Duckling.Dimensions.Types` to cut down on import bloat. Instead of a `Read` instance I created a `fromName` function. Reviewed By: zilberstein Differential Revision: D4710014 fbshipit-source-id: 1d4e86d	2017-03-15 10:34:17 -07:00
Jonathan Coens	1b91b70c58	codemod DNumber to Numeral ... Summary: `DNumber` is a terrible name and was only there because legacy. `Numeral` makes more sense for this dimension, so let's use that instead. Reviewed By: patapizza Differential Revision: D4707167 fbshipit-source-id: cd78aa3	2017-03-14 13:34:11 -07:00
FBShipIt	3f8e52e70a	Initial commit ... fbshipit-source-id: 301a10f448e9623aa1c953544f42de562909e192	2017-03-08 10:33:56 -08:00