mirror of
https://github.com/facebook/duckling.git
synced 2024-09-19 09:07:54 +03:00
6a05e40a37
Summary: This diff implements volume intervals in Duckling. It follows the AmountofMoney and Quantity modules in doing so. I had to make one crucial choice here -- defining the core Volume data type -- and whether the attribute "Unit" was optional (i.e. "Maybe") or not. Like in Quantity and unlike in AmountOfMoney, I made it optional, so that latent volumes can be supported down the line in the codebase. I also wrote the codebase to be more modular, such that future developers only need to add regular expressions rather than functions for any language. For instance, developers can simply define a fraction (e.g. "eighth") at the start of the file, and new rules will be generated automatically; rather than requiring the developer to create an entirely new rule, as previously. The only (partial) exceptions were in the Arabic and Russian Rules files, where the language structure is more difficult and so I cannot fully implement this. Developers for those two languages may need to write new rules, as before. Reviewed By: patapizza Differential Revision: D9043117 fbshipit-source-id: f08de4f167596b5b32d12a79268b8ab92c099b22 |
||
|---|---|---|
| .. | ||
| AR | ||
| EN | ||
| ES | ||
| FR | ||
| GA | ||
| HR | ||
| IT | ||
| KO | ||
| NL | ||
| PT | ||
| RO | ||
| RU | ||
| TR | ||
| Helpers.hs | ||
| Rules.hs | ||
| Types.hs | ||