mirror of
https://github.com/facebook/duckling.git
synced 2024-11-30 23:33:33 +03:00
6a05e40a37
Summary: This diff implements volume intervals in Duckling. It follows the AmountofMoney and Quantity modules in doing so. I had to make one crucial choice here -- defining the core Volume data type -- and whether the attribute "Unit" was optional (i.e. "Maybe") or not. Like in Quantity and unlike in AmountOfMoney, I made it optional, so that latent volumes can be supported down the line in the codebase. I also wrote the codebase to be more modular, such that future developers only need to add regular expressions rather than functions for any language. For instance, developers can simply define a fraction (e.g. "eighth") at the start of the file, and new rules will be generated automatically; rather than requiring the developer to create an entirely new rule, as previously. The only (partial) exceptions were in the Arabic and Russian Rules files, where the language structure is more difficult and so I cannot fully implement this. Developers for those two languages may need to write new rules, as before. Reviewed By: patapizza Differential Revision: D9043117 fbshipit-source-id: f08de4f167596b5b32d12a79268b8ab92c099b22
100 lines
2.6 KiB
Haskell
100 lines
2.6 KiB
Haskell
-- Copyright (c) 2016-present, Facebook, Inc.
|
|
-- All rights reserved.
|
|
--
|
|
-- This source code is licensed under the BSD-style license found in the
|
|
-- LICENSE file in the root directory of this source tree. An additional grant
|
|
-- of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
|
|
{-# LANGUAGE GADTs #-}
|
|
{-# LANGUAGE LambdaCase #-}
|
|
{-# LANGUAGE OverloadedStrings #-}
|
|
|
|
module Duckling.Volume.Rules
|
|
( rules
|
|
) where
|
|
|
|
import Data.String
|
|
import Prelude
|
|
import Data.String
|
|
|
|
import Duckling.Dimensions.Types
|
|
import Duckling.Types
|
|
import Duckling.Regex.Types
|
|
import Duckling.Volume.Helpers
|
|
import Duckling.Numeral.Helpers (isPositive)
|
|
import qualified Duckling.Volume.Types as TVolume
|
|
import qualified Duckling.Numeral.Types as TNumeral
|
|
|
|
ruleNumeralAsVolume :: Rule
|
|
ruleNumeralAsVolume = Rule
|
|
{ name = "number as volume"
|
|
, pattern =
|
|
[ Predicate isPositive
|
|
]
|
|
, prod = \case
|
|
(Token Numeral TNumeral.NumeralData {TNumeral.value = v}:
|
|
_) ->
|
|
Just . Token Volume $ valueOnly v
|
|
_ -> Nothing
|
|
}
|
|
|
|
ruleNumeralVolumes :: Rule
|
|
ruleNumeralVolumes = Rule
|
|
{ name = "<number> <volume>"
|
|
, pattern =
|
|
[ Predicate isPositive
|
|
, Predicate isUnitOnly
|
|
]
|
|
, prod = \case
|
|
(Token Numeral TNumeral.NumeralData{TNumeral.value = v}:
|
|
Token Volume TVolume.VolumeData{TVolume.unit = Just u}:
|
|
_) ->
|
|
Just . Token Volume $ volume u v
|
|
_ -> Nothing
|
|
}
|
|
|
|
ruleIntervalNumeralDash :: Rule
|
|
ruleIntervalNumeralDash = Rule
|
|
{ name = "<numeral> - <volume>"
|
|
, pattern =
|
|
[ Predicate isPositive
|
|
, regex "\\-"
|
|
, Predicate isSimpleVolume
|
|
]
|
|
, prod = \case
|
|
(Token Numeral TNumeral.NumeralData{TNumeral.value = from}:
|
|
_:
|
|
Token Volume TVolume.VolumeData{TVolume.value = Just to
|
|
, TVolume.unit = Just u}:
|
|
_) | from < to ->
|
|
Just . Token Volume . withInterval (from, to) $ unitOnly u
|
|
_ -> Nothing
|
|
}
|
|
|
|
ruleIntervalDash :: Rule
|
|
ruleIntervalDash = Rule
|
|
{ name = "<volume> - <volume>"
|
|
, pattern =
|
|
[ Predicate isSimpleVolume
|
|
, regex "\\-"
|
|
, Predicate isSimpleVolume
|
|
]
|
|
, prod = \case
|
|
(Token Volume TVolume.VolumeData{TVolume.value = Just from
|
|
, TVolume.unit = Just u1}:
|
|
_:
|
|
Token Volume TVolume.VolumeData{TVolume.value = Just to
|
|
, TVolume.unit = Just u2}:
|
|
_) | from < to && u1 == u2 ->
|
|
Just . Token Volume . withInterval (from, to) $ unitOnly u1
|
|
_ -> Nothing
|
|
}
|
|
|
|
rules :: [Rule]
|
|
rules = [ ruleNumeralAsVolume
|
|
, ruleNumeralVolumes
|
|
, ruleIntervalNumeralDash
|
|
, ruleIntervalDash
|
|
]
|