mirror of
https://github.com/facebook/duckling.git
synced 2024-12-01 08:19:36 +03:00
5d6750208a
Summary: When I first skimmed our rules for "half an hour" vs "an hour and a half" I actually thought there might be a bug, because `timesOneAndAHalf` sounds like it's actually multiplying by `1.5`. There's no bug, the implementation is entirely correct, but it does not multiply by 1.5, it adds .5 to any integer value at the given grain. This diff renames the function to be more descriptive. Handy trick for doing this kind of refactor without IDE tooling: ``` find duckling/Duckling/Duration/ -name 'Rules.hs'| xargs sed -i 's/timesOneAndAHalf/nPlusOneHalf/g' ``` Reviewed By: haoxuany Differential Revision: D20456966 fbshipit-source-id: 35020685f091a41618b30b7e5f95dbfa48509b88 |
||
---|---|---|
.. | ||
Corpus.hs | ||
Rules.hs |