mirror of
https://github.com/facebook/duckling.git
synced 2024-11-28 16:54:59 +03:00
84a4f30f5a
Summary: Fix issues where date time matching on double-digit months fails for VI. Reverse the order of month digit matching in two VI rules. Reversing will attempt to capture a two digit month beginning with 1, then fall back to single digit months optionally preceeded with a 0. The current regex greedily captures months starting with 1, but only of a single digit. (10, 11, and 12) are left out of this calculation, and thus regexes for capturing ng(à)y fail. This leads us into bad capturing on unexpected rules. When matched properly, the idea rules for matching date times are used. Resolves #225. I've added to the VI Time Corpus the case in question in #225 and verified its failure at `master` and success on this branch. Pull Request resolved: https://github.com/facebook/duckling/pull/228 Reviewed By: chinmay87 Differential Revision: D9303795 Pulled By: patapizza fbshipit-source-id: aa114f886ab0fdcd95f87730d36e5a686afe2f9c |
||
|---|---|---|
| .. | ||
| Classifiers | ||
| Classifiers.hs | ||
| Extraction.hs | ||
| Rank.hs | ||
| Types.hs | ||