facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2024-12-18 09:32:43 +03:00
Code Issues Packages Projects Releases Wiki Activity
d8888e2ff8
duckling/exe
History
chessai 99e1dce9c4 restrict dimensions to only those specified (#625) 
Summary:
Resolves https://github.com/facebook/duckling/issues/624

Before patch (specifying quantity and numeral, but time still shows up):
```
❯ curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_US&text="June 21 and 3 cups of sugar"&dims="[\"quantity\",\"numeral\"]"' | jq
[
  {
    "body": "June 21",
    "start": 1,
    "value": {
      "values": [
        {
          "value": "2021-06-21T00:00:00.000-07:00",
          "grain": "day",
          "type": "value"
        },
        {
          "value": "2022-06-21T00:00:00.000-07:00",
          "grain": "day",
          "type": "value"
        },
        {
          "value": "2023-06-21T00:00:00.000-07:00",
          "grain": "day",
          "type": "value"
        }
      ],
      "value": "2021-06-21T00:00:00.000-07:00",
      "grain": "day",
      "type": "value"
    },
    "end": 8,
    "dim": "time",
    "latent": false
  },
  {
    "body": "3 cups of sugar",
    "start": 13,
    "value": {
      "value": 3,
      "type": "value",
      "product": "sugar",
      "unit": "cup"
    },
    "end": 28,
    "dim": "quantity",
    "latent": false
  }
]
```

After patch (time no longer shows up):
```
❯ curl -XPOST http://0.0.0.0:8000/parse --data 'locale=en_US&text="June 21 and 3 cups of sugar"&dims="[\"quantity\",\"numeral\"]"' | jq
[
  {
    "body": "3 cups of sugar",
    "start": 13,
    "value": {
      "value": 3,
      "type": "value",
      "product": "sugar",
      "unit": "cup"
    },
    "end": 28,
    "dim": "quantity",
    "latent": false
  }
]
```

Pull Request resolved: https://github.com/facebook/duckling/pull/625

Reviewed By: stroxler

Differential Revision: D28851759

Pulled By: chessai

fbshipit-source-id: d3b3f33092c7e60bf29886939488ed562a213c35
2021-06-03 10:33:42 -07:00
..
Duckling Init 2021-05-18 13:50:19 -07:00
CustomDimensionExample.hs Remove dependency on Data.Some (#533) 2020-09-28 01:33:01 -07:00
DucklingExpensive.hs Remove dependency on Data.Some (#533) 2020-09-28 01:33:01 -07:00
DucklingRequestSample.hs Remove dependency on Data.Some (#533) 2020-09-28 01:33:01 -07:00
ExampleMain.hs restrict dimensions to only those specified (#625) 2021-06-03 10:33:42 -07:00
RegenMain.hs Relicense to BSD3 2019-05-22 10:46:39 -07:00