sapling/build/fbcode_builder/manifests/nghttp2

[manifest]
name = nghttp2

[rpms]
libnghttp2-devel
libnghttp2

[debs]
libnghttp2-dev

[download]
url = https://github.com/nghttp2/nghttp2/releases/download/v1.47.0/nghttp2-1.47.0.tar.gz
sha256 = 62f50f0e9fc479e48b34e1526df8dd2e94136de4c426b7680048181606832b7c

[build]
builder = autoconf
subdir = nghttp2-1.47.0

[autoconf.args]
--enable-lib-only
--disable-dependency-tracking
getdeps: add libcurl and make Eden use libcurl instead of system curl Summary: We are seeing random segment fault originating from OpenSSL on macOS when Mononoke fetching is enabled. The cause is that on macOS we are actually linking against libcurl shipped with the system instead of ours. That copy of libcurl is linked with macOS's libcrypto instead of the one we compiles during Eden's build, and it seems that version of libcrypto does not provide concurrency safety. The solution is to build curl on macOS and make sure it is linked to our OpenSSL that has the concurrency callbacks registered. Reviewed By: wez Differential Revision: D17657822 fbshipit-source-id: 85abdf3be10b3903a5efc6b3a91624c7258de790 2019-10-04 20:53:55 +03:00			`[manifest]`
			`name = nghttp2`

getdeps: allow satisfying deps from system packages Summary: From the outset, we wanted to be sure that getdeps was able to source and build the dependencies so that we knew that we'd have a repeatable build. This came at the cost of build times: having to build boost on each CI run is a bit of a chore. This commit adds three new elements to the manifest files: * `rpms` - a list of RPM names that are all required to be present in order to consider the dependency satisfied * `debs` - like `rpms` above, but scoped to debian package names * `preinstalled.env` - a list of environment variables that if they are all set and non-empty will satisfy the dependency. A new `--allow-system-packages` option to getdeps enables the new logic that looks for system packages; it is off by default, but enabled in the generated GitHub Actions workflows. A new `install-system-deps` subcommand is provided that will attempt to install the system packages needed to satisfy the build. This typically needs to be run via sudo and is thus broken out separately from the main getdeps build flow. I made a pass over the manifest files and added package names that satisfy the build on ubuntu-18 and fedora-31. shri-khare: I renamed the `Python3.7.6` manifest to just `python` as part of this change; the version of python that it pulls in through the normal build is the same and I believe that an equal or newer version of python3 is available in the GH actions builder. The `preinstalled.env` is used only by the boost manifest: it references the name of an environment variable that is set by the github windows hosts and that points to a pre-built and pre-installed copy of boost. Since there is no package manager that we can easily query for this sort of thing, probing from the environment seems like a reasonable and fast way to check for this. We may need to evolve this over time to become more feature rich, but this seems like a good starting point. This commit has the potential to save 20 minutes of build time from each public CI build just due to the boost dependency alone! Refs: https://github.com/facebook/watchman/pull/797 Reviewed By: yfeldblum Differential Revision: D20740410 fbshipit-source-id: 6c38019449c54465127656c3d18a6ff1f30adaea 2020-04-29 21:15:09 +03:00			`[rpms]`
			`libnghttp2-devel`
			`libnghttp2`

			`[debs]`
			`libnghttp2-dev`

getdeps: add libcurl and make Eden use libcurl instead of system curl Summary: We are seeing random segment fault originating from OpenSSL on macOS when Mononoke fetching is enabled. The cause is that on macOS we are actually linking against libcurl shipped with the system instead of ours. That copy of libcurl is linked with macOS's libcrypto instead of the one we compiles during Eden's build, and it seems that version of libcrypto does not provide concurrency safety. The solution is to build curl on macOS and make sure it is linked to our OpenSSL that has the concurrency callbacks registered. Reviewed By: wez Differential Revision: D17657822 fbshipit-source-id: 85abdf3be10b3903a5efc6b3a91624c7258de790 2019-10-04 20:53:55 +03:00			`[download]`
upgrade the nghttp2 package Summary: The EdenFS getdeps build asic build was continually failing on ASIC machines on the external package nghttp2. There were some python2 related errors and then autoconf for that package would end up splitting out an incorrectly formatted makefile. The new version of the nghttp package seems to allow us to build on all platforms. The new package depends on Python3 and I suspect this is why we are able to build with the upgraded package. Reviewed By: xavierd Differential Revision: D37020089 fbshipit-source-id: 5490cc64d454c3a6cbdcde9d7f8859b2b8f621af 2022-06-14 03:37:00 +03:00			`url = https://github.com/nghttp2/nghttp2/releases/download/v1.47.0/nghttp2-1.47.0.tar.gz`
			`sha256 = 62f50f0e9fc479e48b34e1526df8dd2e94136de4c426b7680048181606832b7c`
getdeps: add libcurl and make Eden use libcurl instead of system curl Summary: We are seeing random segment fault originating from OpenSSL on macOS when Mononoke fetching is enabled. The cause is that on macOS we are actually linking against libcurl shipped with the system instead of ours. That copy of libcurl is linked with macOS's libcrypto instead of the one we compiles during Eden's build, and it seems that version of libcrypto does not provide concurrency safety. The solution is to build curl on macOS and make sure it is linked to our OpenSSL that has the concurrency callbacks registered. Reviewed By: wez Differential Revision: D17657822 fbshipit-source-id: 85abdf3be10b3903a5efc6b3a91624c7258de790 2019-10-04 20:53:55 +03:00
			`[build]`
			`builder = autoconf`
upgrade the nghttp2 package Summary: The EdenFS getdeps build asic build was continually failing on ASIC machines on the external package nghttp2. There were some python2 related errors and then autoconf for that package would end up splitting out an incorrectly formatted makefile. The new version of the nghttp package seems to allow us to build on all platforms. The new package depends on Python3 and I suspect this is why we are able to build with the upgraded package. Reviewed By: xavierd Differential Revision: D37020089 fbshipit-source-id: 5490cc64d454c3a6cbdcde9d7f8859b2b8f621af 2022-06-14 03:37:00 +03:00			`subdir = nghttp2-1.47.0`
getdeps: add libcurl and make Eden use libcurl instead of system curl Summary: We are seeing random segment fault originating from OpenSSL on macOS when Mononoke fetching is enabled. The cause is that on macOS we are actually linking against libcurl shipped with the system instead of ours. That copy of libcurl is linked with macOS's libcrypto instead of the one we compiles during Eden's build, and it seems that version of libcrypto does not provide concurrency safety. The solution is to build curl on macOS and make sure it is linked to our OpenSSL that has the concurrency callbacks registered. Reviewed By: wez Differential Revision: D17657822 fbshipit-source-id: 85abdf3be10b3903a5efc6b3a91624c7258de790 2019-10-04 20:53:55 +03:00
			`[autoconf.args]`
			`--enable-lib-only`
upgrade the nghttp2 package Summary: The EdenFS getdeps build asic build was continually failing on ASIC machines on the external package nghttp2. There were some python2 related errors and then autoconf for that package would end up splitting out an incorrectly formatted makefile. The new version of the nghttp package seems to allow us to build on all platforms. The new package depends on Python3 and I suspect this is why we are able to build with the upgraded package. Reviewed By: xavierd Differential Revision: D37020089 fbshipit-source-id: 5490cc64d454c3a6cbdcde9d7f8859b2b8f621af 2022-06-14 03:37:00 +03:00			`--disable-dependency-tracking`