mononoke: rebuild test framework
Summary:
Our test framework as it stands right now is a light passthrough to the hg `run-tests.py` test framework, which attempts to place all the files it needs to run (including tests) into a `python_binary`, then runs the hg test runner from that directory.
It heavily relies on how Buck works to offer functionality:
- It expects that all the sources it registers for its master binary will all be in the same directory when it builds
- It expects that the sources will be symlinks to the real files so that `--interactive` can work.
This has a few problems:
- It doesn't work in `mode/opt`. The archive that gets built in `mode/opt` doesn't actually have all the sources we registered, so it's impossible to run tests.
- To add a new test, you must rebuild everything. We don't do that very often, but it'd be nice if we didn't have to.
- Iterating on the runner itself is painful, because as far as Buck is concerned, it depends on the entire world. This means that every change to the runner has to scan a lot more stuff than necessary. There's some functionality I'd like to get into the runner (like reporting test timings) that hasn't been easy to add as a result.
This diff attempts to solve these problems by separating concerns a little more:
- The runner is now just a simple `python_binary`, so it's easier to make changes to it.
- The runner now provides the logic of working from local files when needed (this means you can add a new test and it'll work immediately),
- All the binaries we need are dependencies of the integration test target, not the runner's. However, to make it possible to run the runner incrementally while iterating on something, there's a manifest target that points at all the various paths the runner needs to work. This will also help integrate the test runner with other build frameworks if necessary (e.g. for open-sourcing).
- We have separate targets for various assets we need to run the tests (e.g. the hg test framework).
- The runner now controls whether to use the network blackhole. This was necessary because the network blackhole breaks PAR archives (because tmp is no longer owned by the right owner, because we use a user namespace). We should be able to bring this back at some point if we want to by using a proper chroot for opt tests.
I included a README to explain this new design as well.
There are some things that could yet stand to be improved here (notably, I think we should put assets and tests in different directories for the sake of clarity), but so far I've been aiming at providing a 1-1 translation of the old system into the new one. I am planning to make further improvements in followup diffs.
Reviewed By: farnz
Differential Revision: D15921732
fbshipit-source-id: 09052591c419acf97f7e360b1e88ef1f412da6e5
2019-06-25 18:30:05 +03:00
|
|
|
$ . "${TEST_FIXTURES}/library.sh"
|
2019-05-30 17:10:49 +03:00
|
|
|
|
|
|
|
|
setup configuration
|
2019-07-02 20:31:16 +03:00
|
|
|
$ INFINITEPUSH_ALLOW_WRITES=true setup_common_config
|
2019-05-30 17:10:49 +03:00
|
|
|
$ cd $TESTTMP
|
|
|
|
|
|
|
|
|
|
setup common configuration for these tests
|
|
|
|
|
$ cat >> $HGRCPATH <<EOF
|
|
|
|
|
> [extensions]
|
|
|
|
|
> amend=
|
|
|
|
|
> infinitepush=
|
|
|
|
|
> commitcloud=
|
|
|
|
|
> EOF
|
|
|
|
|
|
|
|
|
|
setup repo
|
|
|
|
|
|
|
|
|
|
$ hginit_treemanifest repo-hg
|
|
|
|
|
$ cd repo-hg
|
|
|
|
|
$ touch a && hg addremove && hg ci -q -ma
|
|
|
|
|
adding a
|
|
|
|
|
$ hg log -T '{short(node)}\n'
|
|
|
|
|
3903775176ed
|
|
|
|
|
|
|
|
|
|
create master bookmark
|
|
|
|
|
$ hg bookmark master_bookmark -r tip
|
|
|
|
|
|
|
|
|
|
$ cd $TESTTMP
|
|
|
|
|
|
|
|
|
|
setup repo-push and repo-pull
|
|
|
|
|
$ hgclone_treemanifest ssh://user@dummy/repo-hg repo-push --noupdate
|
|
|
|
|
$ hgclone_treemanifest ssh://user@dummy/repo-hg repo-pull --noupdate
|
|
|
|
|
|
|
|
|
|
blobimport
|
|
|
|
|
|
|
|
|
|
$ blobimport repo-hg/.hg repo
|
|
|
|
|
|
|
|
|
|
start mononoke
|
|
|
|
|
|
|
|
|
|
$ mononoke
|
|
|
|
|
$ wait_for_mononoke $TESTTMP/repo
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Do infinitepush (aka commit cloud) push
|
|
|
|
|
$ cd repo-push
|
|
|
|
|
$ cat >> .hg/hgrc <<EOF
|
|
|
|
|
> [extensions]
|
|
|
|
|
> remotenames=
|
|
|
|
|
> [infinitepush]
|
|
|
|
|
> server=False
|
|
|
|
|
> branchpattern=re:scratch/.+
|
|
|
|
|
> EOF
|
|
|
|
|
$ hg up tip
|
|
|
|
|
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
|
|
|
|
|
$ echo new > newfile
|
|
|
|
|
$ hg addremove -q
|
|
|
|
|
$ hg ci -m new
|
|
|
|
|
$ hgmn push ssh://user@dummy/repo -r . --to "scratch/123"
|
|
|
|
|
pushing to ssh://user@dummy/repo
|
|
|
|
|
searching for changes
|
|
|
|
|
remote: Infinitepush bookmark push to scratch/123 was ignored
|
|
|
|
|
|
|
|
|
|
$ tglogp
|
|
|
|
|
@ 1: 47da8b81097c draft 'new'
|
|
|
|
|
|
|
|
|
|
|
o 0: 3903775176ed public 'a' master_bookmark
|
|
|
|
|
|
|
|
|
|
Bookmark push should have been ignored
|
2019-09-23 17:14:55 +03:00
|
|
|
$ sqlite3 "$TESTTMP/monsql/bookmarks" 'SELECT name, hg_kind, HEX(changeset_id) FROM bookmarks;'
|
2019-05-30 17:10:49 +03:00
|
|
|
master_bookmark|pull_default|E10EC6CD13B1CBCFE2384F64BD37FC71B4BF9CFE21487D2EAF5064C1B3C0B793
|
|
|
|
|
Commit should have been accepted
|
|
|
|
|
$ cd ../repo-pull
|
|
|
|
|
$ cat >> .hg/hgrc <<EOF
|
|
|
|
|
> [extensions]
|
|
|
|
|
> remotenames=
|
|
|
|
|
> [infinitepush]
|
|
|
|
|
> server=False
|
|
|
|
|
> branchpattern=re:scratch/.+
|
|
|
|
|
> EOF
|
|
|
|
|
$ hgmn pull -r 47da8b81097c5534f3eb7947a8764dd323cffe3d
|
|
|
|
|
pulling from ssh://user@dummy/repo
|
|
|
|
|
searching for changes
|
|
|
|
|
adding changesets
|
|
|
|
|
adding manifests
|
|
|
|
|
adding file changes
|
|
|
|
|
added 1 changesets with 0 changes to 0 files
|
|
|
|
|
new changesets 47da8b81097c
|
