2009-04-26 03:13:08 +04:00
|
|
|
# dirstate.py - working directory tracking for mercurial
|
|
|
|
#
|
|
|
|
# Copyright 2005-2007 Matt Mackall <mpm@selenic.com>
|
|
|
|
#
|
|
|
|
# This software may be used and distributed according to the terms of the
|
2010-01-20 07:20:08 +03:00
|
|
|
# GNU General Public License version 2 or any later version.
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2015-12-22 08:38:53 +03:00
|
|
|
from __future__ import absolute_import
|
|
|
|
|
2016-01-05 18:52:04 +03:00
|
|
|
import collections
|
2017-05-19 00:10:30 +03:00
|
|
|
import contextlib
|
2015-12-22 08:38:53 +03:00
|
|
|
import errno
|
|
|
|
import os
|
|
|
|
import stat
|
|
|
|
|
|
|
|
from . import (
|
|
|
|
encoding,
|
|
|
|
error,
|
2018-08-09 02:50:47 +03:00
|
|
|
hintutil,
|
2015-12-22 08:38:53 +03:00
|
|
|
match as matchmod,
|
|
|
|
pathutil,
|
2019-03-26 05:22:16 +03:00
|
|
|
perftrace,
|
2016-08-13 06:23:56 +03:00
|
|
|
policy,
|
2016-11-06 01:40:33 +03:00
|
|
|
pycompat,
|
2015-12-22 08:38:53 +03:00
|
|
|
scmutil,
|
2018-10-10 13:49:30 +03:00
|
|
|
treedirstate,
|
2018-06-11 23:49:45 +03:00
|
|
|
treestate,
|
2017-02-20 19:20:59 +03:00
|
|
|
txnutil,
|
2015-12-22 08:38:53 +03:00
|
|
|
util,
|
|
|
|
)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
from .i18n import _
|
2019-04-04 21:23:55 +03:00
|
|
|
from .node import hex, nullid
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
parsers = policy.importmod(r"parsers")
|
2016-08-13 06:23:56 +03:00
|
|
|
|
2009-04-30 05:47:18 +04:00
|
|
|
propertycache = util.propertycache
|
2012-03-01 19:42:49 +04:00
|
|
|
filecache = scmutil.filecache
|
2018-10-01 17:15:19 +03:00
|
|
|
_rangemask = 0x7FFFFFFF
|
2012-03-01 19:42:49 +04:00
|
|
|
|
parsers: inline fields of dirstate values in C version
Previously, while unpacking the dirstate we'd create 3-4 new CPython objects
for most dirstate values:
- the state is a single character string, which is pooled by CPython
- the mode is a new object if it isn't 0 due to being in the lookup set
- the size is a new object if it is greater than 255
- the mtime is a new object if it isn't -1 due to being in the lookup set
- the tuple to contain them all
In some cases such as regular hg status, we actually look at all the objects.
In other cases like hg add, hg status for a subdirectory, or hg status with the
third-party hgwatchman enabled, we look at almost none of the objects.
This patch eliminates most object creation in these cases by defining a custom
C struct that is exposed to Python with an interface similar to a tuple. Only
when tuple elements are actually requested are the respective objects created.
The gains, where they're expected, are significant. The following tests are run
against a working copy with over 270,000 files.
parse_dirstate becomes significantly faster:
$ hg perfdirstate
before: wall 0.186437 comb 0.180000 user 0.160000 sys 0.020000 (best of 35)
after: wall 0.093158 comb 0.100000 user 0.090000 sys 0.010000 (best of 95)
and as a result, several commands benefit:
$ time hg status # with hgwatchman enabled
before: 0.42s user 0.14s system 99% cpu 0.563 total
after: 0.34s user 0.12s system 99% cpu 0.471 total
$ time hg add new-file
before: 0.85s user 0.18s system 99% cpu 1.033 total
after: 0.76s user 0.17s system 99% cpu 0.931 total
There is a slight regression in regular status performance, but this is fixed
in an upcoming patch.
2014-05-28 01:27:41 +04:00
|
|
|
dirstatetuple = parsers.dirstatetuple
|
2014-05-28 04:10:28 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2012-03-01 19:42:49 +04:00
|
|
|
class repocache(filecache):
|
|
|
|
"""filecache for files in .hg/"""
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2012-03-01 19:42:49 +04:00
|
|
|
def join(self, obj, fname):
|
|
|
|
return obj._opener.join(fname)
|
2007-06-18 22:24:34 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2012-03-01 19:49:59 +04:00
|
|
|
class rootcache(filecache):
|
|
|
|
"""filecache for files in the repository root"""
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2012-03-01 19:49:59 +04:00
|
|
|
def join(self, obj, fname):
|
|
|
|
return obj._join(fname)
|
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2015-10-13 20:49:17 +03:00
|
|
|
def _getfsnow(vfs):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Get "now" timestamp on filesystem"""
|
2015-10-13 20:49:17 +03:00
|
|
|
tmpfd, tmpname = vfs.mkstemp()
|
|
|
|
try:
|
2015-11-19 22:15:17 +03:00
|
|
|
return os.fstat(tmpfd).st_mtime
|
2015-10-13 20:49:17 +03:00
|
|
|
finally:
|
|
|
|
os.close(tmpfd)
|
|
|
|
vfs.unlink(tmpname)
|
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2005-11-19 09:48:47 +03:00
|
|
|
class dirstate(object):
|
2018-10-10 13:49:30 +03:00
|
|
|
def __init__(
|
2018-10-31 12:48:07 +03:00
|
|
|
self,
|
|
|
|
opener,
|
|
|
|
ui,
|
|
|
|
root,
|
|
|
|
validate,
|
|
|
|
sparsematchfn=None,
|
|
|
|
istreestate=False,
|
|
|
|
istreedirstate=False,
|
2018-10-10 13:49:30 +03:00
|
|
|
):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Create a new dirstate object.
|
2009-12-28 01:24:05 +03:00
|
|
|
|
|
|
|
opener is an open()-like callable that can be used to open the
|
|
|
|
dirstate file; root is the root of the directory tracked by
|
|
|
|
the dirstate.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2007-06-18 22:24:34 +04:00
|
|
|
self._opener = opener
|
2010-11-22 21:43:31 +03:00
|
|
|
self._validate = validate
|
2007-06-18 22:24:34 +04:00
|
|
|
self._root = root
|
2015-03-05 18:14:22 +03:00
|
|
|
# ntpath.join(root, '') of Python 2.7.9 does not add sep if root is
|
|
|
|
# UNC path pointing to root share (issue4557)
|
dirstate: use pathutil.normasprefix to ensure os.sep at the end of root
419498227287 replaced "os.path.join(root, '')" by
"root.endswith(os.sep)" examination, because Python 2.7.9 changes
behavior of "os.path.join(path, '')" on UNC path.
But some problematic encodings use 0x5c (= "os.sep" on Windows) as the
tail byte of some multi-byte characters, and replacement above
prevents Mercurial from working on the repository, of which root path
ends with such multi-byte character, regardless of enabling win32mbcs.
This patch uses "pathutil.normasprefix()" instead of
"root.endswith(os.sep)" examination, to ensure "os.sep" at the end of
"dirstate._rootdir" even with problematic encodings.
"root" of dirstate can be passed to "pathutil.normasprefix()" without
normalization, because it is always given from "repo.root" =
"repo.wvfs.base", which is normalized by "os.path.realpath()".
Using "util.endswithsep()" instead of "str.endswith(os.sep)" also
fixes this problem, but this patch chooses "pathutil.normasprefix()"
to centralize "adding os.sep if endswith(os.sep)" logic into it.
2015-04-22 17:38:52 +03:00
|
|
|
self._rootdir = pathutil.normasprefix(root)
|
2007-07-22 01:02:09 +04:00
|
|
|
self._dirty = False
|
2012-01-08 21:15:54 +04:00
|
|
|
self._lastnormaltime = 0
|
2007-06-18 22:24:34 +04:00
|
|
|
self._ui = ui
|
2012-03-01 19:39:58 +04:00
|
|
|
self._filecache = {}
|
2014-09-05 22:34:29 +04:00
|
|
|
self._parentwriters = 0
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._filename = "dirstate"
|
|
|
|
self._pendingfilename = "%s.pending" % self._filename
|
2016-08-11 18:00:41 +03:00
|
|
|
self._plchangecallbacks = {}
|
|
|
|
self._origpl = None
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles = set()
|
2018-06-11 23:49:45 +03:00
|
|
|
# TODO(quark): after migrating to treestate, remove legacy code.
|
|
|
|
self._istreestate = istreestate
|
2018-10-10 13:49:30 +03:00
|
|
|
self._istreedirstate = istreedirstate
|
2018-06-11 23:49:45 +03:00
|
|
|
if istreestate:
|
|
|
|
opener.makedirs("treestate")
|
|
|
|
self._mapcls = treestate.treestatemap
|
2018-10-10 13:49:30 +03:00
|
|
|
elif istreedirstate:
|
|
|
|
self._mapcls = treedirstate.treedirstatemap
|
2018-06-11 23:49:45 +03:00
|
|
|
else:
|
|
|
|
self._mapcls = dirstatemap
|
2014-09-05 22:34:29 +04:00
|
|
|
|
2017-05-19 00:10:30 +03:00
|
|
|
@contextlib.contextmanager
|
|
|
|
def parentchange(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Context manager for handling dirstate parents.
|
2017-05-19 00:10:30 +03:00
|
|
|
|
|
|
|
If an exception occurs in the scope of the context manager,
|
|
|
|
the incoherent dirstate won't be written when wlock is
|
|
|
|
released.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2017-05-19 00:10:30 +03:00
|
|
|
self._parentwriters += 1
|
|
|
|
yield
|
|
|
|
# Typically we want the "undo" step of a context manager in a
|
|
|
|
# finally block so it happens even when an exception
|
|
|
|
# occurs. In this case, however, we only want to decrement
|
|
|
|
# parentwriters if the code in the with statement exits
|
|
|
|
# normally, so we don't have a try/finally here on purpose.
|
|
|
|
self._parentwriters -= 1
|
|
|
|
|
2014-09-05 22:34:29 +04:00
|
|
|
def beginparentchange(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Marks the beginning of a set of changes that involve changing
|
2014-09-05 22:34:29 +04:00
|
|
|
the dirstate parents. If there is an exception during this time,
|
|
|
|
the dirstate will not be written when the wlock is released. This
|
|
|
|
prevents writing an incoherent dirstate where the parent doesn't
|
|
|
|
match the contents.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
|
|
|
self._ui.deprecwarn(
|
|
|
|
"beginparentchange is obsoleted by the " "parentchange context manager.",
|
|
|
|
"4.3",
|
|
|
|
)
|
2014-09-05 22:34:29 +04:00
|
|
|
self._parentwriters += 1
|
|
|
|
|
|
|
|
def endparentchange(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Marks the end of a set of changes that involve changing the
|
2014-09-05 22:34:29 +04:00
|
|
|
dirstate parents. Once all parent changes have been marked done,
|
|
|
|
the wlock will be free to write the dirstate on release.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
|
|
|
self._ui.deprecwarn(
|
|
|
|
"endparentchange is obsoleted by the " "parentchange context manager.",
|
|
|
|
"4.3",
|
|
|
|
)
|
2014-09-05 22:34:29 +04:00
|
|
|
if self._parentwriters > 0:
|
|
|
|
self._parentwriters -= 1
|
|
|
|
|
|
|
|
def pendingparentchange(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Returns true if the dirstate is in the middle of a set of changes
|
2014-09-05 22:34:29 +04:00
|
|
|
that modify the dirstate parent.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2014-09-05 22:34:29 +04:00
|
|
|
return self._parentwriters > 0
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2009-04-30 05:47:18 +04:00
|
|
|
@propertycache
|
|
|
|
def _map(self):
|
2017-11-15 12:07:42 +03:00
|
|
|
"""Return the dirstate contents (see documentation for dirstatemap)."""
|
2017-11-15 12:07:42 +03:00
|
|
|
self._map = self._mapcls(self._ui, self._opener, self._root)
|
2009-04-30 05:47:18 +04:00
|
|
|
return self._map
|
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
@repocache("branch")
|
2009-04-30 05:47:18 +04:00
|
|
|
def _branch(self):
|
|
|
|
try:
|
2011-05-02 12:11:18 +04:00
|
|
|
return self._opener.read("branch").strip() or "default"
|
2015-06-24 08:20:08 +03:00
|
|
|
except IOError as inst:
|
2012-01-06 10:37:59 +04:00
|
|
|
if inst.errno != errno.ENOENT:
|
|
|
|
raise
|
2009-04-30 05:47:18 +04:00
|
|
|
return "default"
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
@property
|
2009-04-30 05:47:18 +04:00
|
|
|
def _pl(self):
|
2017-09-26 13:56:20 +03:00
|
|
|
return self._map.parents()
|
2009-04-30 05:47:18 +04:00
|
|
|
|
2017-11-15 12:07:42 +03:00
|
|
|
def hasdir(self, d):
|
|
|
|
return self._map.hastrackeddir(d)
|
2012-02-22 19:07:54 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
@rootcache(".hgignore")
|
2009-04-30 05:47:18 +04:00
|
|
|
def _ignore(self):
|
2018-04-10 03:51:24 +03:00
|
|
|
# gitignore
|
2019-04-30 04:19:49 +03:00
|
|
|
globalignores = self._globalignorefiles()
|
|
|
|
return matchmod.gitignorematcher(self._root, "", gitignorepaths=globalignores)
|
2009-04-30 05:47:18 +04:00
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def _slash(self):
|
2019-02-07 15:21:59 +03:00
|
|
|
return (
|
|
|
|
self._ui.plain() or self._ui.configbool("ui", "slash")
|
|
|
|
) and pycompat.ossep != "/"
|
2009-04-30 05:47:18 +04:00
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def _checklink(self):
|
|
|
|
return util.checklink(self._root)
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def _checkexec(self):
|
|
|
|
return util.checkexec(self._root)
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def _checkcase(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return not util.fscasesensitive(self._join(".hg"))
|
2009-04-30 05:47:18 +04:00
|
|
|
|
2007-07-22 01:02:09 +04:00
|
|
|
def _join(self, f):
|
2008-09-02 17:12:50 +04:00
|
|
|
# much faster than os.path.join()
|
2008-09-02 19:32:07 +04:00
|
|
|
# it's safe because f is always a relative path
|
2008-09-02 17:12:50 +04:00
|
|
|
return self._rootdir + f
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2011-10-23 01:12:33 +04:00
|
|
|
def flagfunc(self, buildfallback):
|
|
|
|
if self._checklink and self._checkexec:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2011-10-23 01:12:33 +04:00
|
|
|
def f(x):
|
2013-04-03 22:35:27 +04:00
|
|
|
try:
|
|
|
|
st = os.lstat(self._join(x))
|
|
|
|
if util.statislink(st):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return "l"
|
2013-04-03 22:35:27 +04:00
|
|
|
if util.statisexec(st):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return "x"
|
2013-04-03 22:35:27 +04:00
|
|
|
except OSError:
|
|
|
|
pass
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return ""
|
|
|
|
|
2011-10-23 01:12:33 +04:00
|
|
|
return f
|
|
|
|
|
|
|
|
fallback = buildfallback()
|
2008-06-26 22:46:34 +04:00
|
|
|
if self._checklink:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2008-06-26 22:46:34 +04:00
|
|
|
def f(x):
|
2008-09-02 17:12:50 +04:00
|
|
|
if os.path.islink(self._join(x)):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return "l"
|
|
|
|
if "x" in fallback(x):
|
|
|
|
return "x"
|
|
|
|
return ""
|
|
|
|
|
2008-06-26 22:46:34 +04:00
|
|
|
return f
|
|
|
|
if self._checkexec:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2008-06-26 22:46:34 +04:00
|
|
|
def f(x):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if "l" in fallback(x):
|
|
|
|
return "l"
|
2011-05-08 22:45:47 +04:00
|
|
|
if util.isexec(self._join(x)):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return "x"
|
|
|
|
return ""
|
|
|
|
|
2008-06-26 22:46:34 +04:00
|
|
|
return f
|
2011-10-23 01:12:33 +04:00
|
|
|
else:
|
|
|
|
return fallback
|
2008-06-26 22:46:34 +04:00
|
|
|
|
2014-02-01 03:13:15 +04:00
|
|
|
@propertycache
|
|
|
|
def _cwd(self):
|
dirstate: centralize _cwd handling into _cwd method
Before this patch, immediate value is assigned to dirstate._cwd, if
ui.forcecwd is specified at instantiation of dirstate.
But this doesn't work as expected in some cases.
For example, hgweb set ui.forcecwd after instantiation of repo object.
If an extension touches repo.dirstate in its reposetup(), dirstate is
instantiated without setting ui.forcecwd, and dirstate.getcwd()
returns incorrect result.
In addition to it, hgweb.__init__() can take already instantiated repo
object, too. In this case, repo.dirstate might be already
instantiated, even if all enabled extensions don't so in their own
reposetup().
To avoid such issue, this patch centralizes _cwd handling into _cwd
method.
This issue can be reproduced by running test-hgweb-commands.t with
fsmonitor-run-tests.py.
2017-07-02 20:52:40 +03:00
|
|
|
# internal config: ui.forcecwd
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
forcecwd = self._ui.config("ui", "forcecwd")
|
dirstate: centralize _cwd handling into _cwd method
Before this patch, immediate value is assigned to dirstate._cwd, if
ui.forcecwd is specified at instantiation of dirstate.
But this doesn't work as expected in some cases.
For example, hgweb set ui.forcecwd after instantiation of repo object.
If an extension touches repo.dirstate in its reposetup(), dirstate is
instantiated without setting ui.forcecwd, and dirstate.getcwd()
returns incorrect result.
In addition to it, hgweb.__init__() can take already instantiated repo
object, too. In this case, repo.dirstate might be already
instantiated, even if all enabled extensions don't so in their own
reposetup().
To avoid such issue, this patch centralizes _cwd handling into _cwd
method.
This issue can be reproduced by running test-hgweb-commands.t with
fsmonitor-run-tests.py.
2017-07-02 20:52:40 +03:00
|
|
|
if forcecwd:
|
|
|
|
return forcecwd
|
2016-11-22 21:33:11 +03:00
|
|
|
return pycompat.getcwd()
|
2014-02-01 03:13:15 +04:00
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
def getcwd(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Return the path from which a canonical path is calculated.
|
2015-09-20 14:08:22 +03:00
|
|
|
|
|
|
|
This path should be used to resolve file patterns or to convert
|
|
|
|
canonical paths back to file paths for display. It shouldn't be
|
|
|
|
used to get real file paths. Use vfs functions instead.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2014-02-01 03:13:15 +04:00
|
|
|
cwd = self._cwd
|
2010-01-25 09:05:27 +03:00
|
|
|
if cwd == self._root:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return ""
|
2007-06-18 22:24:34 +04:00
|
|
|
# self._root ends with a path separator if self._root is '/' or 'C:\'
|
|
|
|
rootsep = self._root
|
2008-01-09 15:30:35 +03:00
|
|
|
if not util.endswithsep(rootsep):
|
2016-12-17 17:32:50 +03:00
|
|
|
rootsep += pycompat.ossep
|
2007-03-16 06:22:58 +03:00
|
|
|
if cwd.startswith(rootsep):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return cwd[len(rootsep) :]
|
2007-03-16 06:22:58 +03:00
|
|
|
else:
|
|
|
|
# we're outside the repo. return an absolute path.
|
|
|
|
return cwd
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2007-06-09 06:49:12 +04:00
|
|
|
def pathto(self, f, cwd=None):
|
|
|
|
if cwd is None:
|
|
|
|
cwd = self.getcwd()
|
2007-06-18 22:24:34 +04:00
|
|
|
path = util.pathto(self._root, cwd, f)
|
2007-06-09 06:49:12 +04:00
|
|
|
if self._slash:
|
2013-05-17 23:31:06 +04:00
|
|
|
return util.pconvert(path)
|
2007-06-09 06:49:12 +04:00
|
|
|
return path
|
2007-06-09 06:49:12 +04:00
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
def __getitem__(self, key):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Return the current state of key (a filename) in the dirstate.
|
2009-12-28 01:24:05 +03:00
|
|
|
|
2009-10-01 23:36:45 +04:00
|
|
|
States are:
|
|
|
|
n normal
|
|
|
|
m needs merging
|
|
|
|
r marked for removal
|
|
|
|
a marked for addition
|
|
|
|
? not tracked
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2007-07-22 01:02:09 +04:00
|
|
|
return self._map.get(key, ("?",))[0]
|
2005-08-28 01:21:25 +04:00
|
|
|
|
|
|
|
def __contains__(self, key):
|
2007-06-18 22:24:34 +04:00
|
|
|
return key in self._map
|
|
|
|
|
|
|
|
def __iter__(self):
|
2017-08-08 21:53:13 +03:00
|
|
|
return iter(sorted(self._map))
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2017-05-29 07:00:02 +03:00
|
|
|
def items(self):
|
completion: add a debugpathcomplete command
The bash_completion code uses "hg status" to generate a list of
possible completions for commands that operate on files in the
working directory. In a large working directory, this can result
in a single tab-completion being very slow (several seconds) as a
result of checking the status of every file, even when there is no
need to check status or no possible matches.
The new debugpathcomplete command gains performance in a few simple
ways:
* Allow completion to operate on just a single directory. When used
to complete the right commands, this considerably reduces the
number of completions returned, at no loss in functionality.
* Never check the status of files. For completions that really must
know if a file is modified, it is faster to use status:
hg status -nm 'glob:myprefix**'
Performance:
Here are the commands used by bash_completion to complete, run in
the root of the mozilla-central working dir (~77,000 files) and
another repo (~165,000 files):
All "normal state" files (used by e.g. remove, revert):
mozilla other
status -nmcd 'glob:**' 1.77 4.10 sec
debugpathcomplete -f -n 0.53 1.26
debugpathcomplete -n 0.17 0.41
("-f" means "complete full paths", rather than the current directory)
Tracked files matching "a":
mozilla other
status -nmcd 'glob:a**' 0.26 0.47
debugpathcomplete -f -n a 0.10 0.24
debugpathcomplete -n a 0.10 0.22
We should be able to further improve completion performance once
the critbit work lands. Right now, our performance is limited by
the need to iterate over all keys in the dirstate.
2013-03-22 03:31:28 +04:00
|
|
|
return self._map.iteritems()
|
|
|
|
|
2017-05-29 07:00:02 +03:00
|
|
|
iteritems = items
|
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
def parents(self):
|
2010-11-22 21:43:31 +03:00
|
|
|
return [self._validate(p) for p in self._pl]
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2011-04-05 00:52:55 +04:00
|
|
|
def p1(self):
|
|
|
|
return self._validate(self._pl[0])
|
|
|
|
|
|
|
|
def p2(self):
|
|
|
|
return self._validate(self._pl[1])
|
|
|
|
|
2007-03-14 02:50:02 +03:00
|
|
|
def branch(self):
|
2010-11-25 00:56:32 +03:00
|
|
|
return encoding.tolocal(self._branch)
|
2007-03-14 02:50:02 +03:00
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
def setparents(self, p1, p2=nullid):
|
2012-04-30 00:25:55 +04:00
|
|
|
"""Set dirstate parents to p1 and p2.
|
|
|
|
|
|
|
|
When moving from two parents to one, 'm' merged entries a
|
|
|
|
adjusted to normal and previous copy records discarded and
|
|
|
|
returned by the call.
|
|
|
|
|
|
|
|
See localrepo.setparents()
|
|
|
|
"""
|
2014-09-05 22:37:44 +04:00
|
|
|
if self._parentwriters == 0:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise ValueError(
|
|
|
|
"cannot set dirstate parent without "
|
|
|
|
"calling dirstate.beginparentchange"
|
|
|
|
)
|
2014-09-05 22:37:44 +04:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
self._dirty = True
|
rebase: skip resolved but emptied revisions
When rebasing, if a conflict occurs and is resolved in a way the rebased
revision becomes empty, it is not skipped, unlike revisions being emptied
without conflicts.
The reason is:
- File 'x' is merged and resolved, merge.update() marks it as 'm' in the
dirstate.
- rebase.concludenode() calls localrepo.commit(), which calls
localrepo.status() which calls dirstate.status(). 'x' shows up as 'm' and is
unconditionnally added to the modified files list, instead of being checked
again.
- localrepo.commit() detects 'x' as changed an create a new revision where only
the manifest parents and linkrev differ.
Marking 'x' as modified without checking it makes sense for regular merges. But
in rebase case, the merge looks normal but the second parent is usually
discarded. When this happens, 'm' files in dirstate are a bit irrelevant and
should be considered 'n' possibly dirty instead. That is what the current patch
does.
Another approach, maybe more efficient, would be to pass another flag to
merge.update() saying the 'branchmerge' is a bit of a lie and recordupdate()
should call dirstate.normallookup() instead of merge().
It is also tempting to add this logic to dirstate.setparents(), moving from two
to one parent is what invalidates the 'm' markers. But this is a far bigger
change to make.
v2: succumb to the temptation and move the logic in dirstate.setparents(). mpm
suggested trying _filecommit() first but it is called by commitctx() which
knows nothing about the dirstate and comes too late into the game. A second
approach was to rewrite the 'm' state into 'n' on the fly in dirstate.status()
which failed for graft in the following case:
$ hg init repo
$ cd repo
$ echo a > a
$ hg ci -qAm0
$ echo a >> a
$ hg ci -m1
$ hg up 0
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg mv a b
$ echo c > b
$ hg ci -m2
created new head
$ hg graft 1 --tool internal:local
grafting revision 1
$ hg --config extensions.graphlog= glog --template '{rev} {desc|firstline}\n'
@ 3 1
|
o 2 2
|
| o 1 1
|/
o 0 0
$ hg log -r 3 --debug --patch --git --copies
changeset: 3:19cd7d1417952af13161b94c32e901769104560c
tag: tip
phase: draft
parent: 2:b5c505595c9e9a12d5dd457919c143e05fc16fb8
parent: -1:0000000000000000000000000000000000000000
manifest: 3:3d27ce8d02241aa59b60804805edf103c5c0cda4
user: test
date: Thu Jan 01 00:00:00 1970 +0000
extra: branch=default
extra: source=a03df74c41413a75c0a42997fc36c2de97b26658
description:
1
Here, revision 3 is created because there is a copy record for 'b' in the
dirstate and thus 'b' is considered modified. But this information is discarded
at commit time since 'b' content is unchanged. I do not know if discarding this
information is correct or not, but at this time we cannot represent it anyway.
This patch therefore implements the last solution of moving the logic into
dirstate.setparents(). It does not sound crazy as 'm' files makes no sense with
only one parent. It also makes dirstate.merge() calls .lookupnormal() if there
is one parent, to preserve the invariant.
I am a bit concerned about introducing this kind of stateful behaviour to
existing code which historically treated setparents() as a basic setter without
side-effects. And doing that during the code freeze.
2012-04-22 22:06:36 +04:00
|
|
|
oldp2 = self._pl[1]
|
2016-08-11 18:00:41 +03:00
|
|
|
if self._origpl is None:
|
|
|
|
self._origpl = self._pl
|
2017-09-26 13:56:20 +03:00
|
|
|
self._map.setparents(p1, p2)
|
2012-04-30 00:25:55 +04:00
|
|
|
copies = {}
|
2018-06-11 23:49:45 +03:00
|
|
|
copymap = self._map.copymap
|
rebase: skip resolved but emptied revisions
When rebasing, if a conflict occurs and is resolved in a way the rebased
revision becomes empty, it is not skipped, unlike revisions being emptied
without conflicts.
The reason is:
- File 'x' is merged and resolved, merge.update() marks it as 'm' in the
dirstate.
- rebase.concludenode() calls localrepo.commit(), which calls
localrepo.status() which calls dirstate.status(). 'x' shows up as 'm' and is
unconditionnally added to the modified files list, instead of being checked
again.
- localrepo.commit() detects 'x' as changed an create a new revision where only
the manifest parents and linkrev differ.
Marking 'x' as modified without checking it makes sense for regular merges. But
in rebase case, the merge looks normal but the second parent is usually
discarded. When this happens, 'm' files in dirstate are a bit irrelevant and
should be considered 'n' possibly dirty instead. That is what the current patch
does.
Another approach, maybe more efficient, would be to pass another flag to
merge.update() saying the 'branchmerge' is a bit of a lie and recordupdate()
should call dirstate.normallookup() instead of merge().
It is also tempting to add this logic to dirstate.setparents(), moving from two
to one parent is what invalidates the 'm' markers. But this is a far bigger
change to make.
v2: succumb to the temptation and move the logic in dirstate.setparents(). mpm
suggested trying _filecommit() first but it is called by commitctx() which
knows nothing about the dirstate and comes too late into the game. A second
approach was to rewrite the 'm' state into 'n' on the fly in dirstate.status()
which failed for graft in the following case:
$ hg init repo
$ cd repo
$ echo a > a
$ hg ci -qAm0
$ echo a >> a
$ hg ci -m1
$ hg up 0
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg mv a b
$ echo c > b
$ hg ci -m2
created new head
$ hg graft 1 --tool internal:local
grafting revision 1
$ hg --config extensions.graphlog= glog --template '{rev} {desc|firstline}\n'
@ 3 1
|
o 2 2
|
| o 1 1
|/
o 0 0
$ hg log -r 3 --debug --patch --git --copies
changeset: 3:19cd7d1417952af13161b94c32e901769104560c
tag: tip
phase: draft
parent: 2:b5c505595c9e9a12d5dd457919c143e05fc16fb8
parent: -1:0000000000000000000000000000000000000000
manifest: 3:3d27ce8d02241aa59b60804805edf103c5c0cda4
user: test
date: Thu Jan 01 00:00:00 1970 +0000
extra: branch=default
extra: source=a03df74c41413a75c0a42997fc36c2de97b26658
description:
1
Here, revision 3 is created because there is a copy record for 'b' in the
dirstate and thus 'b' is considered modified. But this information is discarded
at commit time since 'b' content is unchanged. I do not know if discarding this
information is correct or not, but at this time we cannot represent it anyway.
This patch therefore implements the last solution of moving the logic into
dirstate.setparents(). It does not sound crazy as 'm' files makes no sense with
only one parent. It also makes dirstate.merge() calls .lookupnormal() if there
is one parent, to preserve the invariant.
I am a bit concerned about introducing this kind of stateful behaviour to
existing code which historically treated setparents() as a basic setter without
side-effects. And doing that during the code freeze.
2012-04-22 22:06:36 +04:00
|
|
|
if oldp2 != nullid and p2 == nullid:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
candidatefiles = self._map.nonnormalset.union(self._map.otherparentset)
|
2017-03-09 04:35:20 +03:00
|
|
|
for f in candidatefiles:
|
|
|
|
s = self._map.get(f)
|
|
|
|
if s is None:
|
|
|
|
continue
|
|
|
|
|
2014-10-10 22:05:50 +04:00
|
|
|
# Discard 'm' markers when moving away from a merge state
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if s[0] == "m":
|
2018-06-11 23:49:45 +03:00
|
|
|
source = copymap.get(f)
|
2017-08-23 21:24:57 +03:00
|
|
|
if source:
|
|
|
|
copies[f] = source
|
rebase: skip resolved but emptied revisions
When rebasing, if a conflict occurs and is resolved in a way the rebased
revision becomes empty, it is not skipped, unlike revisions being emptied
without conflicts.
The reason is:
- File 'x' is merged and resolved, merge.update() marks it as 'm' in the
dirstate.
- rebase.concludenode() calls localrepo.commit(), which calls
localrepo.status() which calls dirstate.status(). 'x' shows up as 'm' and is
unconditionnally added to the modified files list, instead of being checked
again.
- localrepo.commit() detects 'x' as changed an create a new revision where only
the manifest parents and linkrev differ.
Marking 'x' as modified without checking it makes sense for regular merges. But
in rebase case, the merge looks normal but the second parent is usually
discarded. When this happens, 'm' files in dirstate are a bit irrelevant and
should be considered 'n' possibly dirty instead. That is what the current patch
does.
Another approach, maybe more efficient, would be to pass another flag to
merge.update() saying the 'branchmerge' is a bit of a lie and recordupdate()
should call dirstate.normallookup() instead of merge().
It is also tempting to add this logic to dirstate.setparents(), moving from two
to one parent is what invalidates the 'm' markers. But this is a far bigger
change to make.
v2: succumb to the temptation and move the logic in dirstate.setparents(). mpm
suggested trying _filecommit() first but it is called by commitctx() which
knows nothing about the dirstate and comes too late into the game. A second
approach was to rewrite the 'm' state into 'n' on the fly in dirstate.status()
which failed for graft in the following case:
$ hg init repo
$ cd repo
$ echo a > a
$ hg ci -qAm0
$ echo a >> a
$ hg ci -m1
$ hg up 0
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg mv a b
$ echo c > b
$ hg ci -m2
created new head
$ hg graft 1 --tool internal:local
grafting revision 1
$ hg --config extensions.graphlog= glog --template '{rev} {desc|firstline}\n'
@ 3 1
|
o 2 2
|
| o 1 1
|/
o 0 0
$ hg log -r 3 --debug --patch --git --copies
changeset: 3:19cd7d1417952af13161b94c32e901769104560c
tag: tip
phase: draft
parent: 2:b5c505595c9e9a12d5dd457919c143e05fc16fb8
parent: -1:0000000000000000000000000000000000000000
manifest: 3:3d27ce8d02241aa59b60804805edf103c5c0cda4
user: test
date: Thu Jan 01 00:00:00 1970 +0000
extra: branch=default
extra: source=a03df74c41413a75c0a42997fc36c2de97b26658
description:
1
Here, revision 3 is created because there is a copy record for 'b' in the
dirstate and thus 'b' is considered modified. But this information is discarded
at commit time since 'b' content is unchanged. I do not know if discarding this
information is correct or not, but at this time we cannot represent it anyway.
This patch therefore implements the last solution of moving the logic into
dirstate.setparents(). It does not sound crazy as 'm' files makes no sense with
only one parent. It also makes dirstate.merge() calls .lookupnormal() if there
is one parent, to preserve the invariant.
I am a bit concerned about introducing this kind of stateful behaviour to
existing code which historically treated setparents() as a basic setter without
side-effects. And doing that during the code freeze.
2012-04-22 22:06:36 +04:00
|
|
|
self.normallookup(f)
|
2014-10-10 22:05:50 +04:00
|
|
|
# Also fix up otherparent markers
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif s[0] == "n" and s[2] == -2:
|
2018-06-11 23:49:45 +03:00
|
|
|
source = copymap.get(f)
|
2017-08-23 21:24:57 +03:00
|
|
|
if source:
|
|
|
|
copies[f] = source
|
2014-10-10 22:05:50 +04:00
|
|
|
self.add(f)
|
2012-04-30 00:25:55 +04:00
|
|
|
return copies
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2007-03-14 02:50:02 +03:00
|
|
|
def setbranch(self, branch):
|
2010-11-25 00:56:32 +03:00
|
|
|
self._branch = encoding.fromlocal(branch)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
f = self._opener("branch", "w", atomictemp=True, checkambig=True)
|
2012-04-19 19:11:42 +04:00
|
|
|
try:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
f.write(self._branch + "\n")
|
2012-04-19 19:11:42 +04:00
|
|
|
f.close()
|
2012-12-16 22:33:00 +04:00
|
|
|
|
|
|
|
# make sure filecache has the correct stat info for _branch after
|
|
|
|
# replacing the underlying file
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
ce = self._filecache["_branch"]
|
2012-12-16 22:33:00 +04:00
|
|
|
if ce:
|
|
|
|
ce.refresh()
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
except: # re-raises
|
2012-12-15 22:19:07 +04:00
|
|
|
f.discard()
|
|
|
|
raise
|
2007-03-14 02:50:02 +03:00
|
|
|
|
2007-06-18 22:24:34 +04:00
|
|
|
def invalidate(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Causes the next access to reread the dirstate.
|
2017-06-05 02:08:50 +03:00
|
|
|
|
|
|
|
This is different from localrepo.invalidatedirstate() because it always
|
|
|
|
rereads the dirstate. Use localrepo.invalidatedirstate() if you want to
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
check whether the dirstate has changed before rereading it."""
|
2017-06-05 02:08:50 +03:00
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
for a in ("_map", "_branch", "_ignore"):
|
2007-07-20 02:43:25 +04:00
|
|
|
if a in self.__dict__:
|
|
|
|
delattr(self, a)
|
2012-01-08 21:15:54 +04:00
|
|
|
self._lastnormaltime = 0
|
2007-07-22 01:02:09 +04:00
|
|
|
self._dirty = False
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.clear()
|
2014-09-05 22:34:29 +04:00
|
|
|
self._parentwriters = 0
|
2016-08-11 18:00:41 +03:00
|
|
|
self._origpl = None
|
2007-04-24 23:02:51 +04:00
|
|
|
|
2005-08-28 01:21:25 +04:00
|
|
|
def copy(self, source, dest):
|
2009-12-28 01:24:05 +03:00
|
|
|
"""Mark dest as a copy of source. Unmark dest if source is None."""
|
2008-06-15 15:01:03 +04:00
|
|
|
if source == dest:
|
|
|
|
return
|
2007-07-22 01:02:09 +04:00
|
|
|
self._dirty = True
|
2018-06-11 23:49:45 +03:00
|
|
|
if self._istreestate:
|
|
|
|
self._map.copy(source, dest)
|
|
|
|
# treestatemap.copymap needs to be changed via the "copy" method.
|
|
|
|
# _updatedfiles is not used by treestatemap as it's tracked
|
|
|
|
# internally.
|
|
|
|
return
|
2009-01-04 23:32:40 +03:00
|
|
|
if source is not None:
|
2017-09-26 13:56:20 +03:00
|
|
|
self._map.copymap[dest] = source
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.add(source)
|
|
|
|
self._updatedfiles.add(dest)
|
2017-09-26 13:56:20 +03:00
|
|
|
elif self._map.copymap.pop(dest, None):
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.add(dest)
|
2005-08-28 01:21:25 +04:00
|
|
|
|
|
|
|
def copied(self, file):
|
2018-06-25 23:55:57 +03:00
|
|
|
if self._istreestate:
|
|
|
|
return self._map.copysource(file)
|
|
|
|
else:
|
|
|
|
return self._map.copymap.get(file, None)
|
2006-09-26 02:53:17 +04:00
|
|
|
|
|
|
|
def copies(self):
|
2017-09-26 13:56:20 +03:00
|
|
|
return self._map.copymap
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2018-06-15 07:23:07 +03:00
|
|
|
def needcheck(self, file):
|
|
|
|
"""Mark file as need-check"""
|
|
|
|
if not self._istreestate:
|
|
|
|
raise error.ProgrammingError("needcheck is only supported by treestate")
|
|
|
|
changed = self._map.needcheck(file)
|
|
|
|
self._dirty |= changed
|
|
|
|
return changed
|
|
|
|
|
2018-10-30 06:03:50 +03:00
|
|
|
def clearneedcheck(self, file):
|
|
|
|
if not self._istreestate:
|
|
|
|
raise error.ProgrammingError("needcheck is only supported by treestate")
|
|
|
|
changed = self._map.clearneedcheck(file)
|
|
|
|
self._dirty |= changed
|
|
|
|
|
2018-06-15 07:23:07 +03:00
|
|
|
def setclock(self, clock):
|
|
|
|
"""Set fsmonitor clock"""
|
2018-11-03 21:10:56 +03:00
|
|
|
return self.setmeta("clock", clock)
|
2018-06-15 07:23:07 +03:00
|
|
|
|
|
|
|
def getclock(self):
|
|
|
|
"""Get fsmonitor clock"""
|
2018-11-03 21:10:56 +03:00
|
|
|
return self.getmeta("clock")
|
|
|
|
|
|
|
|
def setmeta(self, name, value):
|
|
|
|
"""Set metadata"""
|
|
|
|
if not self._istreestate:
|
|
|
|
raise error.ProgrammingError("setmeta is only supported by treestate")
|
|
|
|
value = value or None
|
|
|
|
if value != self.getmeta(name):
|
|
|
|
self._map.updatemetadata({name: value})
|
|
|
|
self._dirty = True
|
|
|
|
|
|
|
|
def getmeta(self, name):
|
|
|
|
"""Get metadata"""
|
2018-06-15 07:23:07 +03:00
|
|
|
if not self._istreestate:
|
2018-11-03 21:10:56 +03:00
|
|
|
raise error.ProgrammingError("getmeta is only supported by treestate")
|
|
|
|
# Normalize "" to "None"
|
|
|
|
return self._map.getmetadata().get(name) or None
|
2018-06-15 07:23:07 +03:00
|
|
|
|
2012-07-04 03:31:37 +04:00
|
|
|
def _addpath(self, f, state, mode, size, mtime):
|
2007-11-05 20:05:44 +03:00
|
|
|
oldstate = self[f]
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if state == "a" or oldstate == "r":
|
2011-04-21 15:18:52 +04:00
|
|
|
scmutil.checkfilename(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
if self._map.hastrackeddir(f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.Abort(_("directory %r already in dirstate") % f)
|
2008-07-12 03:46:02 +04:00
|
|
|
# shadows
|
2015-04-07 00:36:08 +03:00
|
|
|
for d in util.finddirs(f):
|
2017-11-15 12:07:42 +03:00
|
|
|
if self._map.hastrackeddir(d):
|
2008-07-12 03:46:02 +04:00
|
|
|
break
|
2017-09-14 19:41:22 +03:00
|
|
|
entry = self._map.get(d)
|
2018-07-17 20:44:53 +03:00
|
|
|
if entry is not None and entry[0] not in "r?":
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.Abort(_("file %r in dirstate clashes with %r") % (d, f))
|
2012-06-18 19:06:42 +04:00
|
|
|
self._dirty = True
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
self._map.addfile(f, oldstate, state, mode, size, mtime)
|
2007-11-05 20:05:44 +03:00
|
|
|
|
2007-07-22 01:02:09 +04:00
|
|
|
def normal(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark a file normal and clean."""
|
2007-07-22 01:02:09 +04:00
|
|
|
s = os.lstat(self._join(f))
|
2015-11-19 22:15:17 +03:00
|
|
|
mtime = s.st_mtime
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._addpath(f, "n", s.st_mode, s.st_size & _rangemask, mtime & _rangemask)
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._map.copymap.pop(f, None)
|
2018-06-18 23:53:08 +03:00
|
|
|
if f in self._map.nonnormalset:
|
|
|
|
self._map.nonnormalset.remove(f)
|
2011-03-25 17:03:53 +03:00
|
|
|
if mtime > self._lastnormaltime:
|
|
|
|
# Remember the most recent modification timeslot for status(),
|
2011-03-24 20:39:54 +03:00
|
|
|
# to make sure we won't miss future size-preserving file content
|
|
|
|
# modifications that happen within the same timeslot.
|
2011-03-25 17:03:53 +03:00
|
|
|
self._lastnormaltime = mtime
|
dirstate: avoid a race with multiple commits in the same process
(issue2264, issue2516)
The race happens when two commits in a row change the same file
without changing its size, *if* those two commits happen in the same
second in the same process while holding the same repo lock. For
example:
commit 1:
M a
M b
commit 2: # same process, same second, same repo lock
M b # modify b without changing its size
M c
This first manifested in transplant, which is the most common way to
do multiple commits in the same process. But it can manifest in any
script or extension that does multiple commits under the same repo
lock. (Thus, the test script tests both transplant and a custom script.)
The problem was that dirstate.status() failed to notice the change to
b when localrepo is about to do the second commit, meaning that change
gets left in the working directory. In the context of transplant, that
means either a crash ("RuntimeError: nothing committed after
transplant") or a silently inaccurate transplant, depending on whether
any other files were modified by the second transplanted changeset.
The fix is to make status() work a little harder when we have
previously marked files as clean (state 'normal') in the same process.
Specifically, dirstate.normal() adds files to self._lastnormal, and
other state-changing methods remove them. Then dirstate.status() puts
any files in self._lastnormal into state 'lookup', which will make
localrepository.status() read file contents to see if it has really
changed. So we pay a small performance penalty for the second (and
subsequent) commits in the same process, without affecting the common
case. Anything that does lots of status updates and checks in the
same process could suffer a performance hit.
Incidentally, there is a simpler fix: call dirstate.normallookup() on
every file updated by commit() at the end of the commit. The trouble
with that solution is that it imposes a performance penalty on the
common case: it means the next status-dependent hg command after every
"hg commit" will be a little bit slower. The patch here is more
complex, but only affects performance for the uncommon case.
2011-03-21 00:41:09 +03:00
|
|
|
|
merge: forcefully mark files that we get from the second parent as dirty
After a hg merge, we want to include in the commit all the files that we
got from the second parent, so that we have the correct file-level
history. To make them visible to hg commit, we try to mark them as dirty.
Unfortunately, right now we can't really mark them as dirty[1] - the
best we can do is to mark them as needing a full comparison of their
contents, but they will still be considered clean if they happen to be
identical to the version in the first parent.
This changeset extends the dirstate format in a compatible way, so that
we can mark a file as dirty:
Right now we use a negative file size to indicate we don't have valid
stat data for this entry. In practice, this size is always -1.
This patch uses -2 to indicate that the entry is dirty. Older versions
of hg won't choke on this dirstate, but they may happily mark the file
as clean after a full comparison, destroying all of our hard work.
The patch adds a dirstate.normallookup method with the semantics of the
current normaldirty, and changes normaldirty to forcefully mark the
entry as dirty.
This should fix issue522.
[1] - well, we could put them in state 'm', but that state has a
different meaning.
2007-08-23 08:48:29 +04:00
|
|
|
def normallookup(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark a file normal, but possibly dirty."""
|
2017-09-14 19:41:22 +03:00
|
|
|
if self._pl[1] != nullid:
|
2008-03-18 10:07:39 +03:00
|
|
|
# if there is a merge going on and the file was either
|
2010-04-20 13:17:01 +04:00
|
|
|
# in state 'm' (-1) or coming from other parent (-2) before
|
|
|
|
# being removed, restore that state.
|
2017-09-14 19:41:22 +03:00
|
|
|
entry = self._map.get(f)
|
|
|
|
if entry is not None:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if entry[0] == "r" and entry[2] in (-1, -2):
|
2017-09-26 13:56:20 +03:00
|
|
|
source = self._map.copymap.get(f)
|
2017-09-14 19:41:22 +03:00
|
|
|
if entry[2] == -1:
|
|
|
|
self.merge(f)
|
|
|
|
elif entry[2] == -2:
|
|
|
|
self.otherparent(f)
|
|
|
|
if source:
|
|
|
|
self.copy(source, f)
|
|
|
|
return
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if entry[0] == "m" or entry[0] == "n" and entry[2] == -2:
|
2017-09-14 19:41:22 +03:00
|
|
|
return
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._addpath(f, "n", 0, -1, -1)
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._map.copymap.pop(f, None)
|
merge: forcefully mark files that we get from the second parent as dirty
After a hg merge, we want to include in the commit all the files that we
got from the second parent, so that we have the correct file-level
history. To make them visible to hg commit, we try to mark them as dirty.
Unfortunately, right now we can't really mark them as dirty[1] - the
best we can do is to mark them as needing a full comparison of their
contents, but they will still be considered clean if they happen to be
identical to the version in the first parent.
This changeset extends the dirstate format in a compatible way, so that
we can mark a file as dirty:
Right now we use a negative file size to indicate we don't have valid
stat data for this entry. In practice, this size is always -1.
This patch uses -2 to indicate that the entry is dirty. Older versions
of hg won't choke on this dirstate, but they may happily mark the file
as clean after a full comparison, destroying all of our hard work.
The patch adds a dirstate.normallookup method with the semantics of the
current normaldirty, and changes normaldirty to forcefully mark the
entry as dirty.
This should fix issue522.
[1] - well, we could put them in state 'm', but that state has a
different meaning.
2007-08-23 08:48:29 +04:00
|
|
|
|
2010-04-20 13:17:01 +04:00
|
|
|
def otherparent(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark as coming from the other parent, always dirty."""
|
2010-04-20 13:17:01 +04:00
|
|
|
if self._pl[1] == nullid:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.Abort(
|
|
|
|
_("setting %r to other parent " "only allowed in merges") % f
|
|
|
|
)
|
|
|
|
if f in self and self[f] == "n":
|
2014-10-10 22:31:06 +04:00
|
|
|
# merge-like
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._addpath(f, "m", 0, -2, -1)
|
2014-10-10 22:31:06 +04:00
|
|
|
else:
|
|
|
|
# add-like
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._addpath(f, "n", 0, -2, -1)
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._map.copymap.pop(f, None)
|
2007-07-22 01:02:09 +04:00
|
|
|
|
|
|
|
def add(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark a file added."""
|
|
|
|
self._addpath(f, "a", 0, -1, -1)
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._map.copymap.pop(f, None)
|
2007-07-22 01:02:09 +04:00
|
|
|
|
|
|
|
def remove(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark a file removed."""
|
2007-07-22 01:02:09 +04:00
|
|
|
self._dirty = True
|
2017-11-15 12:07:42 +03:00
|
|
|
oldstate = self[f]
|
2008-03-18 10:07:39 +03:00
|
|
|
size = 0
|
2017-09-14 19:41:22 +03:00
|
|
|
if self._pl[1] != nullid:
|
|
|
|
entry = self._map.get(f)
|
|
|
|
if entry is not None:
|
|
|
|
# backup the previous state
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if entry[0] == "m": # merge
|
2017-09-14 19:41:22 +03:00
|
|
|
size = -1
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif entry[0] == "n" and entry[2] == -2: # other parent
|
2017-09-14 19:41:22 +03:00
|
|
|
size = -2
|
2018-06-18 23:53:08 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._map.otherparentset.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
self._updatedfiles.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
self._map.removefile(f, oldstate, size)
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
if size == 0:
|
|
|
|
self._map.copymap.pop(f, None)
|
2007-07-22 01:02:09 +04:00
|
|
|
|
|
|
|
def merge(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Mark a file merged."""
|
rebase: skip resolved but emptied revisions
When rebasing, if a conflict occurs and is resolved in a way the rebased
revision becomes empty, it is not skipped, unlike revisions being emptied
without conflicts.
The reason is:
- File 'x' is merged and resolved, merge.update() marks it as 'm' in the
dirstate.
- rebase.concludenode() calls localrepo.commit(), which calls
localrepo.status() which calls dirstate.status(). 'x' shows up as 'm' and is
unconditionnally added to the modified files list, instead of being checked
again.
- localrepo.commit() detects 'x' as changed an create a new revision where only
the manifest parents and linkrev differ.
Marking 'x' as modified without checking it makes sense for regular merges. But
in rebase case, the merge looks normal but the second parent is usually
discarded. When this happens, 'm' files in dirstate are a bit irrelevant and
should be considered 'n' possibly dirty instead. That is what the current patch
does.
Another approach, maybe more efficient, would be to pass another flag to
merge.update() saying the 'branchmerge' is a bit of a lie and recordupdate()
should call dirstate.normallookup() instead of merge().
It is also tempting to add this logic to dirstate.setparents(), moving from two
to one parent is what invalidates the 'm' markers. But this is a far bigger
change to make.
v2: succumb to the temptation and move the logic in dirstate.setparents(). mpm
suggested trying _filecommit() first but it is called by commitctx() which
knows nothing about the dirstate and comes too late into the game. A second
approach was to rewrite the 'm' state into 'n' on the fly in dirstate.status()
which failed for graft in the following case:
$ hg init repo
$ cd repo
$ echo a > a
$ hg ci -qAm0
$ echo a >> a
$ hg ci -m1
$ hg up 0
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg mv a b
$ echo c > b
$ hg ci -m2
created new head
$ hg graft 1 --tool internal:local
grafting revision 1
$ hg --config extensions.graphlog= glog --template '{rev} {desc|firstline}\n'
@ 3 1
|
o 2 2
|
| o 1 1
|/
o 0 0
$ hg log -r 3 --debug --patch --git --copies
changeset: 3:19cd7d1417952af13161b94c32e901769104560c
tag: tip
phase: draft
parent: 2:b5c505595c9e9a12d5dd457919c143e05fc16fb8
parent: -1:0000000000000000000000000000000000000000
manifest: 3:3d27ce8d02241aa59b60804805edf103c5c0cda4
user: test
date: Thu Jan 01 00:00:00 1970 +0000
extra: branch=default
extra: source=a03df74c41413a75c0a42997fc36c2de97b26658
description:
1
Here, revision 3 is created because there is a copy record for 'b' in the
dirstate and thus 'b' is considered modified. But this information is discarded
at commit time since 'b' content is unchanged. I do not know if discarding this
information is correct or not, but at this time we cannot represent it anyway.
This patch therefore implements the last solution of moving the logic into
dirstate.setparents(). It does not sound crazy as 'm' files makes no sense with
only one parent. It also makes dirstate.merge() calls .lookupnormal() if there
is one parent, to preserve the invariant.
I am a bit concerned about introducing this kind of stateful behaviour to
existing code which historically treated setparents() as a basic setter without
side-effects. And doing that during the code freeze.
2012-04-22 22:06:36 +04:00
|
|
|
if self._pl[1] == nullid:
|
|
|
|
return self.normallookup(f)
|
2014-10-11 23:05:09 +04:00
|
|
|
return self.otherparent(f)
|
2007-07-22 01:02:09 +04:00
|
|
|
|
2018-10-12 19:35:04 +03:00
|
|
|
def untrack(self, f):
|
|
|
|
"""Stops tracking a file in the dirstate. This is useful during
|
|
|
|
operations that want to stop tracking a file, but still have it show up
|
|
|
|
as untracked (like hg forget)."""
|
2017-11-15 12:07:42 +03:00
|
|
|
oldstate = self[f]
|
2018-10-12 19:35:04 +03:00
|
|
|
if self._map.untrackfile(f, oldstate):
|
2011-11-02 00:19:37 +04:00
|
|
|
self._dirty = True
|
2018-06-11 23:49:45 +03:00
|
|
|
if not self._istreestate:
|
|
|
|
self._updatedfiles.add(f)
|
|
|
|
self._map.copymap.pop(f, None)
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2018-10-12 19:35:08 +03:00
|
|
|
def delete(self, f):
|
|
|
|
"""Removes a file from the dirstate entirely. This is useful during
|
|
|
|
operations like update, to remove files from the dirstate that are known
|
|
|
|
to be deleted."""
|
|
|
|
oldstate = self[f]
|
|
|
|
if self._map.deletefile(f, oldstate):
|
|
|
|
self._dirty = True
|
|
|
|
if not self._istreestate:
|
|
|
|
self._updatedfiles.add(f)
|
|
|
|
self._map.copymap.pop(f, None)
|
|
|
|
|
2015-03-30 05:23:05 +03:00
|
|
|
def _discoverpath(self, path, normed, ignoremissing, exists, storemap):
|
|
|
|
if exists is None:
|
|
|
|
exists = os.path.lexists(os.path.join(self._root, path))
|
|
|
|
if not exists:
|
|
|
|
# Maybe a path component exists
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if not ignoremissing and "/" in path:
|
|
|
|
d, f = path.rsplit("/", 1)
|
2015-03-30 05:23:05 +03:00
|
|
|
d = self._normalize(d, False, ignoremissing, None)
|
|
|
|
folded = d + "/" + f
|
|
|
|
else:
|
|
|
|
# No path components, preserve original case
|
|
|
|
folded = path
|
|
|
|
else:
|
|
|
|
# recursively normalize leading directory components
|
|
|
|
# against dirstate
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if "/" in normed:
|
|
|
|
d, f = normed.rsplit("/", 1)
|
2015-03-30 05:23:05 +03:00
|
|
|
d = self._normalize(d, False, ignoremissing, True)
|
|
|
|
r = self._root + "/" + d
|
|
|
|
folded = d + "/" + util.fspath(f, r)
|
|
|
|
else:
|
|
|
|
folded = util.fspath(normed, self._root)
|
|
|
|
storemap[normed] = folded
|
|
|
|
|
|
|
|
return folded
|
|
|
|
|
2015-03-29 04:53:54 +03:00
|
|
|
def _normalizefile(self, path, isknown, ignoremissing=False, exists=None):
|
|
|
|
normed = util.normcase(path)
|
2017-10-05 21:34:41 +03:00
|
|
|
folded = self._map.filefoldmap.get(normed, None)
|
2015-03-29 04:53:54 +03:00
|
|
|
if folded is None:
|
|
|
|
if isknown:
|
|
|
|
folded = path
|
|
|
|
else:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
folded = self._discoverpath(
|
|
|
|
path, normed, ignoremissing, exists, self._map.filefoldmap
|
|
|
|
)
|
2015-03-29 04:53:54 +03:00
|
|
|
return folded
|
|
|
|
|
2012-04-28 22:29:21 +04:00
|
|
|
def _normalize(self, path, isknown, ignoremissing=False, exists=None):
|
2011-11-16 00:25:11 +04:00
|
|
|
normed = util.normcase(path)
|
2017-10-05 21:34:41 +03:00
|
|
|
folded = self._map.filefoldmap.get(normed, None)
|
2015-04-01 05:34:37 +03:00
|
|
|
if folded is None:
|
2017-10-05 21:34:41 +03:00
|
|
|
folded = self._map.dirfoldmap.get(normed, None)
|
2011-03-22 19:59:43 +03:00
|
|
|
if folded is None:
|
2012-04-28 22:29:21 +04:00
|
|
|
if isknown:
|
2011-03-22 19:59:43 +03:00
|
|
|
folded = path
|
2008-10-01 01:23:08 +04:00
|
|
|
else:
|
2015-03-30 05:42:49 +03:00
|
|
|
# store discovered result in dirfoldmap so that future
|
|
|
|
# normalizefile calls don't start matching directories
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
folded = self._discoverpath(
|
|
|
|
path, normed, ignoremissing, exists, self._map.dirfoldmap
|
|
|
|
)
|
2011-03-22 19:59:43 +03:00
|
|
|
return folded
|
|
|
|
|
2012-04-28 22:29:21 +04:00
|
|
|
def normalize(self, path, isknown=False, ignoremissing=False):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2011-03-22 19:59:43 +03:00
|
|
|
normalize the case of a pathname when on a casefolding filesystem
|
|
|
|
|
|
|
|
isknown specifies whether the filename came from walking the
|
2012-04-28 22:29:21 +04:00
|
|
|
disk, to avoid extra filesystem access.
|
|
|
|
|
|
|
|
If ignoremissing is True, missing path are returned
|
|
|
|
unchanged. Otherwise, we try harder to normalize possibly
|
|
|
|
existing path components.
|
2011-03-22 19:59:43 +03:00
|
|
|
|
|
|
|
The normalized case is determined based on the following precedence:
|
|
|
|
|
|
|
|
- version of name already stored in the dirstate
|
|
|
|
- version of name stored on disk
|
|
|
|
- version provided via command arguments
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2011-03-22 19:59:43 +03:00
|
|
|
|
|
|
|
if self._checkcase:
|
2012-04-28 22:29:21 +04:00
|
|
|
return self._normalize(path, isknown, ignoremissing)
|
2011-03-22 19:59:43 +03:00
|
|
|
return path
|
2008-06-06 22:23:29 +04:00
|
|
|
|
2007-08-06 06:04:56 +04:00
|
|
|
def clear(self):
|
2017-10-27 02:15:31 +03:00
|
|
|
self._map.clear()
|
2012-01-08 21:15:54 +04:00
|
|
|
self._lastnormaltime = 0
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.clear()
|
2007-08-06 08:00:10 +04:00
|
|
|
self._dirty = True
|
2007-08-06 06:04:56 +04:00
|
|
|
|
2018-05-03 03:08:29 +03:00
|
|
|
def rebuild(self, parent, allfiles, changedfiles=None, exact=False):
|
|
|
|
# If exact is True, then assume only changedfiles can be changed, and
|
|
|
|
# other files cannot be possibly changed. This is used by "absorb" as
|
|
|
|
# a hint to perform a fast path for fsmonitor and sparse.
|
2015-06-05 08:10:32 +03:00
|
|
|
if changedfiles is None:
|
2018-05-03 03:08:29 +03:00
|
|
|
if exact:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.ProgrammingError("exact requires changedfiles")
|
2015-11-30 22:23:15 +03:00
|
|
|
# Rebuild entire dirstate
|
2015-06-05 08:10:32 +03:00
|
|
|
changedfiles = allfiles
|
2015-11-30 22:23:15 +03:00
|
|
|
lastnormaltime = self._lastnormaltime
|
|
|
|
self.clear()
|
|
|
|
self._lastnormaltime = lastnormaltime
|
|
|
|
|
2016-08-31 01:16:28 +03:00
|
|
|
if self._origpl is None:
|
|
|
|
self._origpl = self._pl
|
2017-09-26 13:56:20 +03:00
|
|
|
self._map.setparents(parent, nullid)
|
2015-11-30 22:23:15 +03:00
|
|
|
for f in changedfiles:
|
|
|
|
if f in allfiles:
|
2016-08-31 01:16:28 +03:00
|
|
|
self.normallookup(f)
|
2006-02-20 21:04:56 +03:00
|
|
|
else:
|
2018-10-12 19:35:04 +03:00
|
|
|
self.untrack(f)
|
2015-11-30 22:23:15 +03:00
|
|
|
|
2007-07-22 01:02:09 +04:00
|
|
|
self._dirty = True
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2017-06-09 07:07:48 +03:00
|
|
|
def identity(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Return identity of dirstate itself to detect changing in storage
|
2017-06-09 07:07:48 +03:00
|
|
|
|
|
|
|
If identity of previous dirstate is equal to this, writing
|
|
|
|
changes based on the former dirstate out can keep consistency.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2017-10-05 21:34:41 +03:00
|
|
|
return self._map.identity
|
2017-06-09 07:07:48 +03:00
|
|
|
|
2016-08-02 17:51:27 +03:00
|
|
|
def write(self, tr):
|
2007-06-18 22:24:34 +04:00
|
|
|
if not self._dirty:
|
2006-02-23 04:17:08 +03:00
|
|
|
return
|
2014-07-22 18:59:30 +04:00
|
|
|
|
2015-10-13 20:49:17 +03:00
|
|
|
filename = self._filename
|
2016-08-02 17:51:27 +03:00
|
|
|
if tr:
|
2015-10-13 20:49:17 +03:00
|
|
|
# 'dirstate.write()' is not only for writing in-memory
|
|
|
|
# changes out, but also for dropping ambiguous timestamp.
|
|
|
|
# delayed writing re-raise "ambiguous timestamp issue".
|
|
|
|
# See also the wiki page below for detail:
|
|
|
|
# https://www.mercurial-scm.org/wiki/DirstateTransactionPlan
|
|
|
|
|
|
|
|
# emulate dropping timestamp in 'parsers.pack_dirstate'
|
2015-10-16 19:15:34 +03:00
|
|
|
now = _getfsnow(self._opener)
|
2017-11-15 12:07:42 +03:00
|
|
|
self._map.clearambiguoustimes(self._updatedfiles, now)
|
2015-10-13 20:49:17 +03:00
|
|
|
|
|
|
|
# emulate that all 'dirstate.normal' results are written out
|
|
|
|
self._lastnormaltime = 0
|
2017-03-06 03:20:07 +03:00
|
|
|
self._updatedfiles.clear()
|
2015-10-13 20:49:17 +03:00
|
|
|
|
|
|
|
# delay writing in-memory changes out
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
tr.addfilegenerator(
|
2018-09-28 17:08:40 +03:00
|
|
|
"dirstate", (self._filename,), self._writedirstate, location="local"
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
)
|
2015-10-13 20:49:17 +03:00
|
|
|
return
|
|
|
|
|
2016-06-02 18:44:20 +03:00
|
|
|
st = self._opener(filename, "w", atomictemp=True, checkambig=True)
|
2015-10-07 19:41:30 +03:00
|
|
|
self._writedirstate(st)
|
|
|
|
|
2019-04-04 21:23:56 +03:00
|
|
|
@util.propertycache
|
|
|
|
def checkoutidentifier(self):
|
|
|
|
try:
|
|
|
|
return self._opener.read("checkoutidentifier")
|
|
|
|
except IOError as e:
|
|
|
|
if e.errno != errno.ENOENT:
|
|
|
|
raise
|
|
|
|
return ""
|
|
|
|
|
2016-08-11 18:00:41 +03:00
|
|
|
def addparentchangecallback(self, category, callback):
|
|
|
|
"""add a callback to be called when the wd parents are changed
|
|
|
|
|
|
|
|
Callback will be called with the following arguments:
|
|
|
|
dirstate, (oldp1, oldp2), (newp1, newp2)
|
|
|
|
|
|
|
|
Category is a unique identifier to allow overwriting an old callback
|
|
|
|
with a newer callback.
|
|
|
|
"""
|
|
|
|
self._plchangecallbacks[category] = callback
|
|
|
|
|
2015-10-07 19:41:30 +03:00
|
|
|
def _writedirstate(self, st):
|
2016-08-11 18:00:41 +03:00
|
|
|
# notify callbacks about parents change
|
|
|
|
if self._origpl is not None and self._origpl != self._pl:
|
|
|
|
for c, callback in sorted(self._plchangecallbacks.iteritems()):
|
|
|
|
callback(self, self._origpl, self._pl)
|
2019-04-04 21:23:56 +03:00
|
|
|
# if the first parent has changed then consider this a new checkout
|
|
|
|
if self._origpl[0] != self._pl[0]:
|
|
|
|
with self._opener("checkoutidentifier", "w", atomictemp=True) as f:
|
|
|
|
f.write(util.makerandomidentifier())
|
|
|
|
util.clearcachedproperty(self, "checkoutidentifier")
|
2016-08-11 18:00:41 +03:00
|
|
|
self._origpl = None
|
2009-10-01 19:17:52 +04:00
|
|
|
# use the modification time of the newly created temporary file as the
|
|
|
|
# filesystem's notion of 'now'
|
2015-11-19 22:15:17 +03:00
|
|
|
now = util.fstat(st).st_mtime & _rangemask
|
2015-12-17 05:46:53 +03:00
|
|
|
|
|
|
|
# enough 'delaywrite' prevents 'pack_dirstate' from dropping
|
|
|
|
# timestamp of each entries in dirstate, because of 'now > mtime'
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
delaywrite = self._ui.configint("debug", "dirstate.delaywrite")
|
2015-12-17 05:46:53 +03:00
|
|
|
if delaywrite > 0:
|
2015-12-17 05:49:18 +03:00
|
|
|
# do we have any files to delay for?
|
|
|
|
for f, e in self._map.iteritems():
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if e[0] == "n" and e[3] == now:
|
|
|
|
import time # to avoid useless import
|
|
|
|
|
2015-12-17 05:58:26 +03:00
|
|
|
# rather than sleep n seconds, sleep until the next
|
|
|
|
# multiple of n seconds
|
|
|
|
clock = time.time()
|
|
|
|
start = int(clock) - (int(clock) % delaywrite)
|
|
|
|
end = start + delaywrite
|
|
|
|
time.sleep(end - clock)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
now = end # trust our estimate that the end is near now
|
2015-12-17 05:49:18 +03:00
|
|
|
break
|
2015-12-17 05:46:53 +03:00
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
self._map.write(st, now)
|
2013-04-28 01:19:52 +04:00
|
|
|
self._lastnormaltime = 0
|
2017-10-05 21:34:41 +03:00
|
|
|
self._dirty = False
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2008-02-08 23:07:55 +03:00
|
|
|
def _dirignore(self, f):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if f == ".":
|
2008-04-05 20:15:04 +04:00
|
|
|
return False
|
dirstate: stop testing directories as files in ignore handling
Summary:
This is subtle.
`.hgignore`'s current behavior: if `^foo$` rule exists, then directory `foo/`
is ignored (ex. 'foo/bar' should be ignored).
However, that imposes problems for the sparse ignore matcher, which is the
"negate" of the "include" matcher. A user can write `[include]` glob patterns
like:
a*{b*,c*/d*}/e*
The ignore matcher will be the negate of the above patterns. Then because
`a1b2` does not match `a*{b*,c*/d*}/e`, the negate matcher returns "True",
and the ignore matcher will ignore the directory. So even if file `a1b2/e3`
should be selected, the parent directory being ignored cause the file to
be ignored.
That is clearly incorrect for sparse's usecase.
I think the issue is fundementally a layer violation - it's the *matcher*'s
responsibility to check whether one of the parent directory is matched (or
ignored), not the directory walker's responsibility.
This diff fixes the walker so it uses the visitdir interface, and moves back
the directory check to hgignore matcher to maintain compatibility. For three
matchers involved in ignore handling:
- hgignore matcher: updated to do the recursive directory handling on its own
- gitignore matcher: work out of box. already consider parent directories!
- sparse matcher: want the new behavior
`test-sparse-issues.t` is now green.
With this change, the `forceincludematcher` subdir hack used in sparse is no
longer necessary. Therefore removed.
Besides, all ignore matchers can handle "visitdir" correctly. That is, if
`visitdir('x')` returns `'all'`, then `visitdir('x/y')` will also return `'all'`.
Therefore the parent directory logic in `dirstate.dirignore` becomes
unnecessary and dropped.
Reviewed By: DurhamG
Differential Revision: D10861612
fbshipit-source-id: aa0c181ae64b361b85f08b8fecfdfe6331e9a4c2
2018-12-13 09:42:17 +03:00
|
|
|
visitdir = self._ignore.visitdir
|
|
|
|
if visitdir(f) == "all":
|
2008-02-08 23:07:55 +03:00
|
|
|
return True
|
|
|
|
return False
|
|
|
|
|
2015-12-23 22:52:54 +03:00
|
|
|
def _ignorefiles(self):
|
|
|
|
files = []
|
2019-04-30 04:19:49 +03:00
|
|
|
files += self._globalignorefiles()
|
2018-08-03 06:18:50 +03:00
|
|
|
return files
|
|
|
|
|
2019-04-30 04:19:49 +03:00
|
|
|
def _globalignorefiles(self):
|
2018-08-03 06:18:50 +03:00
|
|
|
files = []
|
2015-12-23 22:52:54 +03:00
|
|
|
for name, path in self._ui.configitems("ui"):
|
2018-08-03 06:18:50 +03:00
|
|
|
# A path could have an optional prefix (ex. "git:") to select file
|
|
|
|
# format
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if name == "ignore" or name.startswith("ignore."):
|
2015-12-23 22:52:54 +03:00
|
|
|
# we need to use os.path.join here rather than self._join
|
|
|
|
# because path is arbitrary and user-specified
|
2018-08-03 06:18:50 +03:00
|
|
|
fullpath = os.path.join(self._rootdir, util.expandpath(path))
|
2019-04-30 04:19:49 +03:00
|
|
|
files.append(fullpath)
|
2015-12-23 22:52:54 +03:00
|
|
|
return files
|
|
|
|
|
2019-03-11 20:37:29 +03:00
|
|
|
def _walkexplicit(self, match):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Get stat data about the files explicitly specified by match.
|
2006-10-27 08:54:24 +04:00
|
|
|
|
2013-05-08 01:19:04 +04:00
|
|
|
Return a triple (results, dirsfound, dirsnotfound).
|
2019-03-11 20:37:29 +03:00
|
|
|
- results is a mapping from filename to stat result.
|
2013-05-08 01:19:04 +04:00
|
|
|
- dirsfound is a list of files found to be directories.
|
2013-05-07 21:02:55 +04:00
|
|
|
- dirsnotfound is a list of files that the dirstate thinks are
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
directories and that were not found."""
|
2008-05-12 20:37:07 +04:00
|
|
|
|
2009-06-01 02:54:18 +04:00
|
|
|
def badtype(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("unknown")
|
2010-01-25 09:05:27 +03:00
|
|
|
if stat.S_ISCHR(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("character device")
|
2010-01-25 09:05:27 +03:00
|
|
|
elif stat.S_ISBLK(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("block device")
|
2010-01-25 09:05:27 +03:00
|
|
|
elif stat.S_ISFIFO(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("fifo")
|
2010-01-25 09:05:27 +03:00
|
|
|
elif stat.S_ISSOCK(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("socket")
|
2010-01-25 09:05:27 +03:00
|
|
|
elif stat.S_ISDIR(mode):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
kind = _("directory")
|
|
|
|
return _("unsupported file type (type is %s)") % kind
|
2008-07-22 22:03:23 +04:00
|
|
|
|
2013-05-04 01:39:28 +04:00
|
|
|
matchedir = match.explicitdir
|
2009-06-01 02:54:18 +04:00
|
|
|
badfn = match.bad
|
2008-07-22 22:03:24 +04:00
|
|
|
dmap = self._map
|
2007-07-26 21:02:58 +04:00
|
|
|
lstat = os.lstat
|
2008-07-22 22:03:23 +04:00
|
|
|
getkind = stat.S_IFMT
|
2008-07-22 22:03:20 +04:00
|
|
|
dirkind = stat.S_IFDIR
|
2008-07-22 22:03:23 +04:00
|
|
|
regkind = stat.S_IFREG
|
|
|
|
lnkkind = stat.S_IFLNK
|
2008-07-22 22:03:24 +04:00
|
|
|
join = self._join
|
2013-05-08 01:19:04 +04:00
|
|
|
dirsfound = []
|
|
|
|
foundadd = dirsfound.append
|
2013-05-07 21:02:55 +04:00
|
|
|
dirsnotfound = []
|
2013-05-08 01:20:34 +04:00
|
|
|
notfoundadd = dirsnotfound.append
|
2008-07-22 22:03:10 +04:00
|
|
|
|
2014-10-29 18:43:39 +03:00
|
|
|
if not match.isexact() and self._checkcase:
|
2010-11-01 22:18:42 +03:00
|
|
|
normalize = self._normalize
|
|
|
|
else:
|
2012-12-04 22:29:18 +04:00
|
|
|
normalize = None
|
2010-11-01 22:18:42 +03:00
|
|
|
|
2010-09-11 01:53:51 +04:00
|
|
|
files = sorted(match.files())
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if not files or "." in files:
|
|
|
|
files = ["."]
|
2019-03-11 20:37:29 +03:00
|
|
|
results = {".hg": None}
|
2007-07-26 21:02:58 +04:00
|
|
|
|
2010-09-11 01:53:51 +04:00
|
|
|
for ff in files:
|
2015-03-30 04:28:48 +03:00
|
|
|
# constructing the foldmap is expensive, so don't do it for the
|
|
|
|
# common case where files is ['.']
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if normalize and ff != ".":
|
2015-03-30 09:28:30 +03:00
|
|
|
nf = normalize(ff, False, True)
|
2012-12-04 22:29:18 +04:00
|
|
|
else:
|
2015-03-30 09:28:30 +03:00
|
|
|
nf = ff
|
2008-07-22 22:03:21 +04:00
|
|
|
if nf in results:
|
2008-07-22 22:03:10 +04:00
|
|
|
continue
|
|
|
|
|
|
|
|
try:
|
2008-07-22 22:03:24 +04:00
|
|
|
st = lstat(join(nf))
|
2008-07-22 22:03:23 +04:00
|
|
|
kind = getkind(st.st_mode)
|
|
|
|
if kind == dirkind:
|
2009-05-14 12:50:45 +04:00
|
|
|
if nf in dmap:
|
2013-10-03 20:01:21 +04:00
|
|
|
# file replaced by dir on disk but still in dirstate
|
2009-05-14 12:50:45 +04:00
|
|
|
results[nf] = None
|
2013-05-04 01:41:58 +04:00
|
|
|
if matchedir:
|
|
|
|
matchedir(nf)
|
2015-03-31 18:11:39 +03:00
|
|
|
foundadd((nf, ff))
|
2010-09-24 21:46:54 +04:00
|
|
|
elif kind == regkind or kind == lnkkind:
|
2008-07-22 22:03:23 +04:00
|
|
|
results[nf] = st
|
2008-07-22 22:03:20 +04:00
|
|
|
else:
|
2009-06-01 02:54:18 +04:00
|
|
|
badfn(ff, badtype(kind))
|
2008-07-22 22:03:23 +04:00
|
|
|
if nf in dmap:
|
2008-07-22 22:03:21 +04:00
|
|
|
results[nf] = None
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
except OSError as inst: # nf not found on disk - it is dirstate only
|
|
|
|
if nf in dmap: # does it exactly match a missing file?
|
2009-06-01 02:54:18 +04:00
|
|
|
results[nf] = None
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
else: # does it match a missing directory?
|
2017-11-15 12:07:42 +03:00
|
|
|
if self._map.hasdir(nf):
|
2014-11-20 10:15:07 +03:00
|
|
|
if matchedir:
|
|
|
|
matchedir(nf)
|
|
|
|
notfoundadd(nf)
|
2009-06-01 02:54:18 +04:00
|
|
|
else:
|
2017-08-23 03:03:07 +03:00
|
|
|
badfn(ff, encoding.strtolocal(inst.strerror))
|
2013-05-07 21:02:55 +04:00
|
|
|
|
2015-07-28 04:27:24 +03:00
|
|
|
# Case insensitive filesystems cannot rely on lstat() failing to detect
|
|
|
|
# a case-only rename. Prune the stat object for any file that does not
|
|
|
|
# match the case in the filesystem, if there are multiple files that
|
|
|
|
# normalize to the same path.
|
|
|
|
if match.isexact() and self._checkcase:
|
|
|
|
normed = {}
|
|
|
|
|
|
|
|
for f, st in results.iteritems():
|
|
|
|
if st is None:
|
|
|
|
continue
|
|
|
|
|
|
|
|
nc = util.normcase(f)
|
|
|
|
paths = normed.get(nc)
|
|
|
|
|
|
|
|
if paths is None:
|
|
|
|
paths = set()
|
|
|
|
normed[nc] = paths
|
|
|
|
|
|
|
|
paths.add(f)
|
|
|
|
|
|
|
|
for norm, paths in normed.iteritems():
|
|
|
|
if len(paths) > 1:
|
|
|
|
for path in paths:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
folded = self._discoverpath(
|
|
|
|
path, norm, True, None, self._map.dirfoldmap
|
|
|
|
)
|
2015-07-28 04:27:24 +03:00
|
|
|
if path != folded:
|
|
|
|
results[path] = None
|
|
|
|
|
2013-05-08 01:19:04 +04:00
|
|
|
return results, dirsfound, dirsnotfound
|
2013-05-07 21:02:55 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
@util.timefunction("dirstatewalk", 0, "_ui")
|
2019-03-11 20:37:29 +03:00
|
|
|
def walk(self, match, unknown, ignored, full=True):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2013-05-07 21:02:55 +04:00
|
|
|
Walk recursively through the directory tree, finding all files
|
|
|
|
matched by match.
|
|
|
|
|
2013-04-23 04:11:18 +04:00
|
|
|
If full is False, maybe skip some known-clean files.
|
|
|
|
|
2013-05-07 21:02:55 +04:00
|
|
|
Return a dict mapping filename to stat-like object (either
|
|
|
|
mercurial.osutil.stat instance or return value of os.stat()).
|
2013-04-23 04:11:18 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2013-04-23 04:11:18 +04:00
|
|
|
# full is a flag that extensions that hook into walk can use -- this
|
|
|
|
# implementation doesn't use it at all. This satisfies the contract
|
|
|
|
# because we only guarantee a "maybe".
|
2013-05-07 21:02:55 +04:00
|
|
|
|
|
|
|
if ignored:
|
|
|
|
ignore = util.never
|
|
|
|
dirignore = util.never
|
2013-10-03 20:01:21 +04:00
|
|
|
elif unknown:
|
|
|
|
ignore = self._ignore
|
|
|
|
dirignore = self._dirignore
|
|
|
|
else:
|
|
|
|
# if not unknown and not ignored, drop dir recursion and step 2
|
2013-05-07 21:02:55 +04:00
|
|
|
ignore = util.always
|
|
|
|
dirignore = util.always
|
|
|
|
|
|
|
|
matchfn = match.matchfn
|
|
|
|
matchalways = match.always()
|
|
|
|
matchtdir = match.traversedir
|
|
|
|
dmap = self._map
|
2017-04-26 16:26:28 +03:00
|
|
|
listdir = util.listdir
|
2013-05-07 21:02:55 +04:00
|
|
|
lstat = os.lstat
|
|
|
|
dirkind = stat.S_IFDIR
|
|
|
|
regkind = stat.S_IFREG
|
|
|
|
lnkkind = stat.S_IFLNK
|
|
|
|
join = self._join
|
|
|
|
|
|
|
|
exact = skipstep3 = False
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if match.isexact(): # match.exact
|
2013-05-07 21:02:55 +04:00
|
|
|
exact = True
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
dirignore = util.always # skip step 2
|
|
|
|
elif match.prefix(): # match.match, no patterns
|
2013-05-07 21:02:55 +04:00
|
|
|
skipstep3 = True
|
|
|
|
|
|
|
|
if not exact and self._checkcase:
|
2015-04-01 05:29:39 +03:00
|
|
|
normalize = self._normalize
|
dirstate.walk: use the file foldmap to normalize
Computing the set of directories in the dirstate is expensive. It turns out
that it isn't necessary for operations like 'hg status' at all.
Why? Consider the file 'foo/bar' on disk, which is represented in the dirstate
as 'FOO/BAR'.
On 'hg status', we'd walk down the directory tree, coming across 'foo' first.
Before: we'd normalize 'foo' to 'FOO', then add 'FOO' to our visited stack.
We'd then visit 'FOO', finding the file 'bar'. We'd normalize 'FOO/bar' to
'FOO/BAR', then add it to the results dict.
After: we wouldn't normalize 'foo' at all. We'd add it to our visited stack,
then visit 'foo', finding the file 'bar'. We'd normalize 'foo/bar' to
'FOO/BAR', then add it to the results dict.
So whether we normalize intermediate directories or not actually makes no
difference in most cases.
The only case where normalization matters at all is if a file is replaced with
a directory with the same case-folded name. In that case we can do a relatively
cheap file normalization instead and still get away with not computing the set
of directories.
This is a nice boost in status performance. On OS X with case-insensitive HFS+,
for a large repo with over 200,000 files, this brings down 'hg status' from
4.00 seconds to 3.62.
2015-03-30 05:47:16 +03:00
|
|
|
normalizefile = self._normalizefile
|
2013-05-07 21:02:55 +04:00
|
|
|
skipstep3 = False
|
|
|
|
else:
|
2015-04-01 05:29:39 +03:00
|
|
|
normalize = self._normalize
|
dirstate.walk: use the file foldmap to normalize
Computing the set of directories in the dirstate is expensive. It turns out
that it isn't necessary for operations like 'hg status' at all.
Why? Consider the file 'foo/bar' on disk, which is represented in the dirstate
as 'FOO/BAR'.
On 'hg status', we'd walk down the directory tree, coming across 'foo' first.
Before: we'd normalize 'foo' to 'FOO', then add 'FOO' to our visited stack.
We'd then visit 'FOO', finding the file 'bar'. We'd normalize 'FOO/bar' to
'FOO/BAR', then add it to the results dict.
After: we wouldn't normalize 'foo' at all. We'd add it to our visited stack,
then visit 'foo', finding the file 'bar'. We'd normalize 'foo/bar' to
'FOO/BAR', then add it to the results dict.
So whether we normalize intermediate directories or not actually makes no
difference in most cases.
The only case where normalization matters at all is if a file is replaced with
a directory with the same case-folded name. In that case we can do a relatively
cheap file normalization instead and still get away with not computing the set
of directories.
This is a nice boost in status performance. On OS X with case-insensitive HFS+,
for a large repo with over 200,000 files, this brings down 'hg status' from
4.00 seconds to 3.62.
2015-03-30 05:47:16 +03:00
|
|
|
normalizefile = None
|
2013-05-07 21:02:55 +04:00
|
|
|
|
|
|
|
# step 1: find all explicit files
|
2019-03-11 20:37:29 +03:00
|
|
|
results, work, dirsnotfound = self._walkexplicit(match)
|
2008-07-22 22:03:10 +04:00
|
|
|
|
2013-05-07 20:31:00 +04:00
|
|
|
skipstep3 = skipstep3 and not (work or dirsnotfound)
|
2015-03-31 18:11:39 +03:00
|
|
|
work = [d for d in work if not dirignore(d[0])]
|
2013-05-07 20:47:10 +04:00
|
|
|
|
2008-07-22 22:03:18 +04:00
|
|
|
# step 2: visit subdirectories
|
2015-04-01 05:29:39 +03:00
|
|
|
def traverse(work, alreadynormed):
|
2015-04-01 05:18:27 +03:00
|
|
|
wadd = work.append
|
|
|
|
while work:
|
2015-04-01 05:29:39 +03:00
|
|
|
nd = work.pop()
|
2017-05-05 18:49:46 +03:00
|
|
|
if not match.visitdir(nd):
|
|
|
|
continue
|
2015-04-01 05:18:27 +03:00
|
|
|
skip = None
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if nd == ".":
|
|
|
|
nd = ""
|
2012-12-04 22:29:18 +04:00
|
|
|
else:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
skip = ".hg"
|
2015-04-01 05:18:27 +03:00
|
|
|
try:
|
|
|
|
entries = listdir(join(nd), stat=True, skip=skip)
|
2015-06-24 08:20:08 +03:00
|
|
|
except OSError as inst:
|
2015-04-01 05:18:27 +03:00
|
|
|
if inst.errno in (errno.EACCES, errno.ENOENT):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
match.bad(self.pathto(nd), encoding.strtolocal(inst.strerror))
|
2015-04-01 05:18:27 +03:00
|
|
|
continue
|
|
|
|
raise
|
|
|
|
for f, kind, st in entries:
|
|
|
|
if normalizefile:
|
|
|
|
# even though f might be a directory, we're only
|
|
|
|
# interested in comparing it to files currently in the
|
|
|
|
# dmap -- therefore normalizefile is enough
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
nf = normalizefile(nd and (nd + "/" + f) or f, True, True)
|
2015-04-01 05:18:27 +03:00
|
|
|
else:
|
|
|
|
nf = nd and (nd + "/" + f) or f
|
|
|
|
if nf not in results:
|
|
|
|
if kind == dirkind:
|
dirstate: stop testing directories as files in ignore handling
Summary:
This is subtle.
`.hgignore`'s current behavior: if `^foo$` rule exists, then directory `foo/`
is ignored (ex. 'foo/bar' should be ignored).
However, that imposes problems for the sparse ignore matcher, which is the
"negate" of the "include" matcher. A user can write `[include]` glob patterns
like:
a*{b*,c*/d*}/e*
The ignore matcher will be the negate of the above patterns. Then because
`a1b2` does not match `a*{b*,c*/d*}/e`, the negate matcher returns "True",
and the ignore matcher will ignore the directory. So even if file `a1b2/e3`
should be selected, the parent directory being ignored cause the file to
be ignored.
That is clearly incorrect for sparse's usecase.
I think the issue is fundementally a layer violation - it's the *matcher*'s
responsibility to check whether one of the parent directory is matched (or
ignored), not the directory walker's responsibility.
This diff fixes the walker so it uses the visitdir interface, and moves back
the directory check to hgignore matcher to maintain compatibility. For three
matchers involved in ignore handling:
- hgignore matcher: updated to do the recursive directory handling on its own
- gitignore matcher: work out of box. already consider parent directories!
- sparse matcher: want the new behavior
`test-sparse-issues.t` is now green.
With this change, the `forceincludematcher` subdir hack used in sparse is no
longer necessary. Therefore removed.
Besides, all ignore matchers can handle "visitdir" correctly. That is, if
`visitdir('x')` returns `'all'`, then `visitdir('x/y')` will also return `'all'`.
Therefore the parent directory logic in `dirstate.dirignore` becomes
unnecessary and dropped.
Reviewed By: DurhamG
Differential Revision: D10861612
fbshipit-source-id: aa0c181ae64b361b85f08b8fecfdfe6331e9a4c2
2018-12-13 09:42:17 +03:00
|
|
|
if not dirignore(nf):
|
2015-04-01 05:18:27 +03:00
|
|
|
if matchtdir:
|
|
|
|
matchtdir(nf)
|
2015-04-01 05:29:39 +03:00
|
|
|
wadd(nf)
|
2015-04-01 05:18:27 +03:00
|
|
|
if nf in dmap and (matchalways or matchfn(nf)):
|
|
|
|
results[nf] = None
|
|
|
|
elif kind == regkind or kind == lnkkind:
|
|
|
|
if nf in dmap:
|
|
|
|
if matchalways or matchfn(nf):
|
|
|
|
results[nf] = st
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif (matchalways or matchfn(nf)) and not ignore(nf):
|
2015-04-01 05:29:39 +03:00
|
|
|
# unknown file -- normalize if necessary
|
|
|
|
if not alreadynormed:
|
|
|
|
nf = normalize(nf, False, True)
|
2008-07-22 22:03:25 +04:00
|
|
|
results[nf] = st
|
2015-04-01 05:18:27 +03:00
|
|
|
elif nf in dmap and (matchalways or matchfn(nf)):
|
|
|
|
results[nf] = None
|
|
|
|
|
2015-04-01 05:29:39 +03:00
|
|
|
for nd, d in work:
|
|
|
|
# alreadynormed means that processwork doesn't have to do any
|
|
|
|
# expensive directory normalization
|
|
|
|
alreadynormed = not normalize or nd == d
|
|
|
|
traverse([d], alreadynormed)
|
2008-07-22 22:03:18 +04:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
del results[".hg"]
|
2013-03-26 01:12:39 +04:00
|
|
|
|
2013-10-03 20:01:21 +04:00
|
|
|
# step 3: visit remaining files from dmap
|
2009-06-01 02:54:18 +04:00
|
|
|
if not skipstep3 and not exact:
|
2013-10-03 20:01:21 +04:00
|
|
|
# If a dmap file is not in results yet, it was either
|
|
|
|
# a) not matching matchfn b) ignored, c) missing, or d) under a
|
|
|
|
# symlink directory.
|
2013-03-23 04:03:49 +04:00
|
|
|
if not results and matchalways:
|
2017-03-16 06:30:27 +03:00
|
|
|
visit = [f for f in dmap]
|
2013-03-23 04:03:49 +04:00
|
|
|
else:
|
|
|
|
visit = [f for f in dmap if f not in results and matchfn(f)]
|
|
|
|
visit.sort()
|
|
|
|
|
2013-02-05 02:27:15 +04:00
|
|
|
if unknown:
|
2013-10-03 20:01:21 +04:00
|
|
|
# unknown == True means we walked all dirs under the roots
|
|
|
|
# that wasn't ignored, and everything that matched was stat'ed
|
|
|
|
# and is already in results.
|
|
|
|
# The rest must thus be ignored or under a symlink.
|
2017-07-26 16:10:15 +03:00
|
|
|
audit_path = pathutil.pathauditor(self._root, cached=True)
|
2013-02-05 02:27:15 +04:00
|
|
|
|
|
|
|
for nf in iter(visit):
|
dirstate.walk: don't report same file stat multiple times
dirstate.walk() generates pairs of filename and a stat-like
object. After "hg mv foo Foo", it generates one pair for "foo" and one
for "Foo", as it should. However, on case-insensitive file systems,
when it tries to stat to get the disk state as well, it gets the same
stat result for both names. This confuses at least
scmutil._interestingfiles(), making it think that "foo" was forgotten
rather than removed. That, in turn, makes "hg addremove" add "foo"
back, resulting in both cases in the dirstate, as reported in
issue4590.
This change only takes care of the "if unknown" branch. A similar fix
should perhaps be applied to the other branch.
2015-04-05 07:54:12 +03:00
|
|
|
# If a stat for the same file was already added with a
|
|
|
|
# different case, don't add one for this, since that would
|
|
|
|
# make it appear as if the file exists under both names
|
|
|
|
# on disk.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if normalizefile and normalizefile(nf, True, True) in results:
|
dirstate.walk: don't report same file stat multiple times
dirstate.walk() generates pairs of filename and a stat-like
object. After "hg mv foo Foo", it generates one pair for "foo" and one
for "Foo", as it should. However, on case-insensitive file systems,
when it tries to stat to get the disk state as well, it gets the same
stat result for both names. This confuses at least
scmutil._interestingfiles(), making it think that "foo" was forgotten
rather than removed. That, in turn, makes "hg addremove" add "foo"
back, resulting in both cases in the dirstate, as reported in
issue4590.
This change only takes care of the "if unknown" branch. A similar fix
should perhaps be applied to the other branch.
2015-04-05 07:54:12 +03:00
|
|
|
results[nf] = None
|
2013-02-05 02:27:15 +04:00
|
|
|
# Report ignored items in the dmap as long as they are not
|
|
|
|
# under a symlink directory.
|
dirstate.walk: don't report same file stat multiple times
dirstate.walk() generates pairs of filename and a stat-like
object. After "hg mv foo Foo", it generates one pair for "foo" and one
for "Foo", as it should. However, on case-insensitive file systems,
when it tries to stat to get the disk state as well, it gets the same
stat result for both names. This confuses at least
scmutil._interestingfiles(), making it think that "foo" was forgotten
rather than removed. That, in turn, makes "hg addremove" add "foo"
back, resulting in both cases in the dirstate, as reported in
issue4590.
This change only takes care of the "if unknown" branch. A similar fix
should perhaps be applied to the other branch.
2015-04-05 07:54:12 +03:00
|
|
|
elif audit_path.check(nf):
|
2013-02-11 00:23:39 +04:00
|
|
|
try:
|
|
|
|
results[nf] = lstat(join(nf))
|
2013-10-03 20:01:21 +04:00
|
|
|
# file was just ignored, no links, and exists
|
2013-02-11 00:23:39 +04:00
|
|
|
except OSError:
|
|
|
|
# file doesn't exist
|
|
|
|
results[nf] = None
|
2013-02-05 02:27:15 +04:00
|
|
|
else:
|
|
|
|
# It's either missing or under a symlink directory
|
2013-10-03 20:01:21 +04:00
|
|
|
# which we in this case report as missing
|
2013-02-05 02:27:15 +04:00
|
|
|
results[nf] = None
|
|
|
|
else:
|
|
|
|
# We may not have walked the full directory tree above,
|
2013-10-03 20:01:21 +04:00
|
|
|
# so stat and check everything we missed.
|
2017-03-19 08:08:17 +03:00
|
|
|
iv = iter(visit)
|
2015-11-18 00:47:16 +03:00
|
|
|
for st in util.statfiles([join(i) for i in visit]):
|
2017-03-19 08:08:17 +03:00
|
|
|
results[next(iv)] = st
|
2008-07-22 22:03:21 +04:00
|
|
|
return results
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2019-03-26 05:22:16 +03:00
|
|
|
@perftrace.tracefunc("Status")
|
2019-03-11 20:37:29 +03:00
|
|
|
def status(self, match, ignored, clean, unknown):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Determine the status of the working copy relative to the
|
2014-10-10 21:14:35 +04:00
|
|
|
dirstate and return a pair of (unsure, status), where status is of type
|
|
|
|
scmutil.status and:
|
2009-10-01 23:36:45 +04:00
|
|
|
|
|
|
|
unsure:
|
|
|
|
files that might have been modified since the dirstate was
|
|
|
|
written, but need to be read to be sure (size is the same
|
|
|
|
but mtime differs)
|
2014-10-10 21:14:35 +04:00
|
|
|
status.modified:
|
2009-10-01 23:36:45 +04:00
|
|
|
files that have definitely been modified since the dirstate
|
|
|
|
was written (different size or mode)
|
2014-10-10 21:14:35 +04:00
|
|
|
status.clean:
|
2009-10-01 23:36:45 +04:00
|
|
|
files that have definitely not been modified since the
|
|
|
|
dirstate was written
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2008-06-26 23:35:50 +04:00
|
|
|
listignored, listclean, listunknown = ignored, clean, unknown
|
2006-03-30 00:58:34 +04:00
|
|
|
lookup, modified, added, unknown, ignored = [], [], [], [], []
|
2006-07-21 03:21:07 +04:00
|
|
|
removed, deleted, clean = [], [], []
|
2005-08-28 01:21:25 +04:00
|
|
|
|
2007-07-26 21:02:58 +04:00
|
|
|
dmap = self._map
|
2017-10-28 22:35:54 +03:00
|
|
|
dmap.preload()
|
|
|
|
dget = dmap.__getitem__
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
ladd = lookup.append # aka "unsure"
|
2007-07-26 21:02:58 +04:00
|
|
|
madd = modified.append
|
|
|
|
aadd = added.append
|
|
|
|
uadd = unknown.append
|
|
|
|
iadd = ignored.append
|
|
|
|
radd = removed.append
|
|
|
|
dadd = deleted.append
|
|
|
|
cadd = clean.append
|
2012-12-04 02:21:45 +04:00
|
|
|
mexact = match.exact
|
dirstate: stop testing directories as files in ignore handling
Summary:
This is subtle.
`.hgignore`'s current behavior: if `^foo$` rule exists, then directory `foo/`
is ignored (ex. 'foo/bar' should be ignored).
However, that imposes problems for the sparse ignore matcher, which is the
"negate" of the "include" matcher. A user can write `[include]` glob patterns
like:
a*{b*,c*/d*}/e*
The ignore matcher will be the negate of the above patterns. Then because
`a1b2` does not match `a*{b*,c*/d*}/e`, the negate matcher returns "True",
and the ignore matcher will ignore the directory. So even if file `a1b2/e3`
should be selected, the parent directory being ignored cause the file to
be ignored.
That is clearly incorrect for sparse's usecase.
I think the issue is fundementally a layer violation - it's the *matcher*'s
responsibility to check whether one of the parent directory is matched (or
ignored), not the directory walker's responsibility.
This diff fixes the walker so it uses the visitdir interface, and moves back
the directory check to hgignore matcher to maintain compatibility. For three
matchers involved in ignore handling:
- hgignore matcher: updated to do the recursive directory handling on its own
- gitignore matcher: work out of box. already consider parent directories!
- sparse matcher: want the new behavior
`test-sparse-issues.t` is now green.
With this change, the `forceincludematcher` subdir hack used in sparse is no
longer necessary. Therefore removed.
Besides, all ignore matchers can handle "visitdir" correctly. That is, if
`visitdir('x')` returns `'all'`, then `visitdir('x/y')` will also return `'all'`.
Therefore the parent directory logic in `dirstate.dirignore` becomes
unnecessary and dropped.
Reviewed By: DurhamG
Differential Revision: D10861612
fbshipit-source-id: aa0c181ae64b361b85f08b8fecfdfe6331e9a4c2
2018-12-13 09:42:17 +03:00
|
|
|
ignore = self._ignore
|
2012-12-04 02:21:45 +04:00
|
|
|
checkexec = self._checkexec
|
2017-09-26 13:56:20 +03:00
|
|
|
copymap = self._map.copymap
|
2012-12-04 02:21:45 +04:00
|
|
|
lastnormaltime = self._lastnormaltime
|
2018-10-30 06:03:50 +03:00
|
|
|
cleanmarked = False
|
|
|
|
if self._istreestate:
|
|
|
|
markclean = self._map.clearneedcheck
|
|
|
|
else:
|
|
|
|
markclean = lambda path: False
|
2007-07-26 21:02:58 +04:00
|
|
|
|
2019-02-06 06:36:49 +03:00
|
|
|
# We have seen some rare issues that a few "M" or "R" files show up
|
|
|
|
# while the files are expected to be clean. Log the reason of first few
|
|
|
|
# "M" files.
|
|
|
|
mtolog = ltolog = self._ui.configint("experimental", "samplestatus")
|
|
|
|
|
2013-04-24 01:16:33 +04:00
|
|
|
# We need to do full walks when either
|
|
|
|
# - we're listing all clean files, or
|
|
|
|
# - match.traversedir does something, because match.traversedir should
|
|
|
|
# be called for every dir in the working dir
|
|
|
|
full = listclean or match.traversedir is not None
|
2019-03-11 20:37:29 +03:00
|
|
|
for fn, st in self.walk(match, listunknown, listignored, full=full).iteritems():
|
2018-01-26 18:01:45 +03:00
|
|
|
try:
|
|
|
|
t = dget(fn)
|
2018-06-15 07:23:07 +03:00
|
|
|
# This "?" state is only tracked by treestate, emulate the old
|
|
|
|
# behavior - KeyError.
|
|
|
|
if t[0] == "?":
|
|
|
|
raise KeyError
|
2018-01-26 18:01:45 +03:00
|
|
|
except KeyError:
|
dirstate: stop testing directories as files in ignore handling
Summary:
This is subtle.
`.hgignore`'s current behavior: if `^foo$` rule exists, then directory `foo/`
is ignored (ex. 'foo/bar' should be ignored).
However, that imposes problems for the sparse ignore matcher, which is the
"negate" of the "include" matcher. A user can write `[include]` glob patterns
like:
a*{b*,c*/d*}/e*
The ignore matcher will be the negate of the above patterns. Then because
`a1b2` does not match `a*{b*,c*/d*}/e`, the negate matcher returns "True",
and the ignore matcher will ignore the directory. So even if file `a1b2/e3`
should be selected, the parent directory being ignored cause the file to
be ignored.
That is clearly incorrect for sparse's usecase.
I think the issue is fundementally a layer violation - it's the *matcher*'s
responsibility to check whether one of the parent directory is matched (or
ignored), not the directory walker's responsibility.
This diff fixes the walker so it uses the visitdir interface, and moves back
the directory check to hgignore matcher to maintain compatibility. For three
matchers involved in ignore handling:
- hgignore matcher: updated to do the recursive directory handling on its own
- gitignore matcher: work out of box. already consider parent directories!
- sparse matcher: want the new behavior
`test-sparse-issues.t` is now green.
With this change, the `forceincludematcher` subdir hack used in sparse is no
longer necessary. Therefore removed.
Besides, all ignore matchers can handle "visitdir" correctly. That is, if
`visitdir('x')` returns `'all'`, then `visitdir('x/y')` will also return `'all'`.
Therefore the parent directory logic in `dirstate.dirignore` becomes
unnecessary and dropped.
Reviewed By: DurhamG
Differential Revision: D10861612
fbshipit-source-id: aa0c181ae64b361b85f08b8fecfdfe6331e9a4c2
2018-12-13 09:42:17 +03:00
|
|
|
if (listignored or mexact(fn)) and ignore(fn):
|
2008-06-26 23:35:50 +04:00
|
|
|
if listignored:
|
2008-02-08 23:07:55 +03:00
|
|
|
iadd(fn)
|
2013-10-14 08:25:29 +04:00
|
|
|
else:
|
2007-07-26 21:02:58 +04:00
|
|
|
uadd(fn)
|
2005-10-28 00:29:35 +04:00
|
|
|
continue
|
2008-05-12 20:37:08 +04:00
|
|
|
|
2014-05-28 08:02:16 +04:00
|
|
|
# This is equivalent to 'state, mode, size, time = dmap[fn]' but not
|
|
|
|
# written like that for performance reasons. dmap[fn] is not a
|
|
|
|
# Python tuple in compiled builds. The CPython UNPACK_SEQUENCE
|
|
|
|
# opcode has fast paths when the value to be unpacked is a tuple or
|
|
|
|
# a list, but falls back to creating a full-fledged iterator in
|
|
|
|
# general. That is much slower than simply accessing and storing the
|
|
|
|
# tuple members one by one.
|
|
|
|
state = t[0]
|
|
|
|
mode = t[1]
|
|
|
|
size = t[2]
|
|
|
|
time = t[3]
|
2008-05-12 20:37:08 +04:00
|
|
|
|
2008-07-22 22:02:36 +04:00
|
|
|
if not st and state in "nma":
|
|
|
|
dadd(fn)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif state == "n":
|
|
|
|
if (
|
|
|
|
size >= 0
|
|
|
|
and (
|
|
|
|
(size != st.st_size and size != st.st_size & _rangemask)
|
|
|
|
or ((mode ^ st.st_mode) & 0o100 and checkexec)
|
|
|
|
)
|
|
|
|
or size == -2 # other parent
|
|
|
|
or fn in copymap
|
|
|
|
):
|
2007-07-26 21:02:58 +04:00
|
|
|
madd(fn)
|
2019-02-06 06:36:49 +03:00
|
|
|
if mtolog > 0:
|
|
|
|
mtolog -= 1
|
|
|
|
reasons = []
|
|
|
|
if size == -2:
|
|
|
|
reasons.append("exists in p2")
|
|
|
|
elif size != st.st_size:
|
|
|
|
reasons.append(
|
|
|
|
"size changed (%s -> %s)" % (size, st.st_size)
|
|
|
|
)
|
2019-02-15 02:57:41 +03:00
|
|
|
# See T39234759. Sometimes watchman returns 0 size
|
|
|
|
# (st.st_size) and we suspect it's incorrect.
|
|
|
|
# Do a double check with os.stat and log it.
|
|
|
|
if st.st_size == 0:
|
|
|
|
path = self._join(fn)
|
|
|
|
try:
|
|
|
|
reasons.append(
|
|
|
|
"os.stat size = %s" % os.stat(path).st_size
|
|
|
|
)
|
|
|
|
except Exception as ex:
|
|
|
|
reasons.append("os.stat failed (%s)" % ex)
|
2019-02-06 06:36:49 +03:00
|
|
|
if mode != st.st_mode:
|
|
|
|
reasons.append(
|
|
|
|
"mode changed (%s -> %s)" % (mode, st.st_mode)
|
|
|
|
)
|
|
|
|
if fn in copymap:
|
|
|
|
reasons.append("has copy information")
|
|
|
|
self._ui.log("status", "M %s: %s" % (fn, ", ".join(reasons)))
|
|
|
|
|
2015-11-19 22:15:17 +03:00
|
|
|
elif time != st.st_mtime and time != st.st_mtime & _rangemask:
|
2019-02-06 06:36:49 +03:00
|
|
|
if ltolog:
|
|
|
|
ltolog -= 1
|
|
|
|
reason = "mtime changed (%s -> %s)" % (time, st.st_mtime)
|
|
|
|
self._ui.log("status", "L %s: %s" % (fn, reason))
|
2007-07-26 21:02:58 +04:00
|
|
|
ladd(fn)
|
2015-11-19 22:15:17 +03:00
|
|
|
elif st.st_mtime == lastnormaltime:
|
2015-01-14 03:15:26 +03:00
|
|
|
# fn may have just been marked as normal and it may have
|
|
|
|
# changed in the same second without changing its size.
|
|
|
|
# This can happen if we quickly do multiple commits.
|
2011-03-25 17:03:53 +03:00
|
|
|
# Force lookup, so we don't miss such a racy file change.
|
2019-02-06 06:36:49 +03:00
|
|
|
if ltolog:
|
|
|
|
ltolog -= 1
|
|
|
|
reason = "mtime untrusted (%s)" % (st.st_mtime)
|
|
|
|
self._ui.log("status", "L %s: %s" % (fn, reason))
|
dirstate: avoid a race with multiple commits in the same process
(issue2264, issue2516)
The race happens when two commits in a row change the same file
without changing its size, *if* those two commits happen in the same
second in the same process while holding the same repo lock. For
example:
commit 1:
M a
M b
commit 2: # same process, same second, same repo lock
M b # modify b without changing its size
M c
This first manifested in transplant, which is the most common way to
do multiple commits in the same process. But it can manifest in any
script or extension that does multiple commits under the same repo
lock. (Thus, the test script tests both transplant and a custom script.)
The problem was that dirstate.status() failed to notice the change to
b when localrepo is about to do the second commit, meaning that change
gets left in the working directory. In the context of transplant, that
means either a crash ("RuntimeError: nothing committed after
transplant") or a silently inaccurate transplant, depending on whether
any other files were modified by the second transplanted changeset.
The fix is to make status() work a little harder when we have
previously marked files as clean (state 'normal') in the same process.
Specifically, dirstate.normal() adds files to self._lastnormal, and
other state-changing methods remove them. Then dirstate.status() puts
any files in self._lastnormal into state 'lookup', which will make
localrepository.status() read file contents to see if it has really
changed. So we pay a small performance penalty for the second (and
subsequent) commits in the same process, without affecting the common
case. Anything that does lots of status updates and checks in the
same process could suffer a performance hit.
Incidentally, there is a simpler fix: call dirstate.normallookup() on
every file updated by commit() at the end of the commit. The trouble
with that solution is that it imposes a performance penalty on the
common case: it means the next status-dependent hg command after every
"hg commit" will be a little bit slower. The patch here is more
complex, but only affects performance for the uncommon case.
2011-03-21 00:41:09 +03:00
|
|
|
ladd(fn)
|
2018-10-30 06:03:50 +03:00
|
|
|
else:
|
|
|
|
cleanmarked |= markclean(fn)
|
|
|
|
if listclean:
|
|
|
|
cadd(fn)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif state == "m":
|
2007-07-26 21:02:58 +04:00
|
|
|
madd(fn)
|
2019-02-06 06:36:49 +03:00
|
|
|
if mtolog > 0:
|
|
|
|
mtolog -= 1
|
|
|
|
self._ui.log("status", "M %s: state is 'm' (merge)" % fn)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif state == "a":
|
2007-07-26 21:02:58 +04:00
|
|
|
aadd(fn)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
elif state == "r":
|
2007-07-26 21:02:58 +04:00
|
|
|
radd(fn)
|
2018-10-30 06:03:50 +03:00
|
|
|
if cleanmarked:
|
|
|
|
self._dirty = True
|
2005-10-28 00:29:35 +04:00
|
|
|
|
2019-03-26 05:22:16 +03:00
|
|
|
perftrace.tracevalue("A/M/R Files", len(modified) + len(added) + len(removed))
|
|
|
|
if len(unknown) > 0:
|
|
|
|
perftrace.tracevalue("Unknown Files", len(unknown))
|
|
|
|
if len(ignored) > 0:
|
|
|
|
perftrace.tracevalue("Ignored Files", len(ignored))
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return (
|
|
|
|
lookup,
|
|
|
|
scmutil.status(modified, added, removed, deleted, unknown, ignored, clean),
|
|
|
|
)
|
2014-08-02 09:05:16 +04:00
|
|
|
|
|
|
|
def matches(self, match):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2014-08-02 09:05:16 +04:00
|
|
|
return files in the dirstate (in whatever state) filtered by match
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""
|
2014-08-02 09:05:16 +04:00
|
|
|
dmap = self._map
|
|
|
|
if match.always():
|
|
|
|
return dmap.keys()
|
|
|
|
files = match.files()
|
2014-10-29 18:43:39 +03:00
|
|
|
if match.isexact():
|
2014-08-02 09:05:16 +04:00
|
|
|
# fast path -- filter the other way around, since typically files is
|
|
|
|
# much smaller than dmap
|
|
|
|
return [f for f in files if f in dmap]
|
2018-07-06 01:32:29 +03:00
|
|
|
if match.prefix():
|
|
|
|
if self._istreestate:
|
|
|
|
# treestate has a fast path to get files inside a subdirectory.
|
|
|
|
# files are prefixes
|
|
|
|
result = set()
|
2018-07-27 22:07:08 +03:00
|
|
|
fastpathvalid = True
|
2018-07-06 01:32:29 +03:00
|
|
|
for prefix in files:
|
|
|
|
if prefix in dmap:
|
|
|
|
# prefix is a file
|
|
|
|
result.add(prefix)
|
2018-07-27 22:07:08 +03:00
|
|
|
elif dmap.hastrackeddir(prefix + "/"):
|
2018-07-06 01:32:29 +03:00
|
|
|
# prefix is a directory
|
|
|
|
result.update(dmap.keys(prefix=prefix + "/"))
|
2018-07-27 22:07:08 +03:00
|
|
|
else:
|
|
|
|
# unknown pattern (ex. "."), fast path is invalid
|
|
|
|
fastpathvalid = False
|
|
|
|
break
|
|
|
|
if fastpathvalid:
|
|
|
|
return sorted(result)
|
2018-07-06 01:32:29 +03:00
|
|
|
else:
|
|
|
|
# fast path -- all the values are known to be files, so just
|
|
|
|
# return that
|
|
|
|
if all(fn in dmap for fn in files):
|
|
|
|
return list(files)
|
2014-08-02 09:05:16 +04:00
|
|
|
return [f for f in dmap if match(f)]
|
2015-10-13 20:49:17 +03:00
|
|
|
|
2015-10-16 19:15:33 +03:00
|
|
|
def _actualfilename(self, tr):
|
|
|
|
if tr:
|
dirstate: make functions for backup aware of transaction activity
Some comments in this patch assume that subsequent patch changes
'dirstate.write()' like as below:
def write(self, repo):
if not self._dirty:
return
tr = repo.currenttransaction()
if tr:
tr.addfilegenerator('dirstate', (self._filename,),
self._writedirstate, location='plain')
return # omit actual writing out
st = self._opener('dirstate', "w", atomictemp=True)
self._writedirstate(st)
This patch makes '_savebackup()' write in-memory changes out, and it
causes clearing 'self._dirty'. If dirstate isn't changed after
'_savebackup()', subsequent 'dirstate.write()' never invokes
'tr.addfilegenerator()' because 'not self._dirty' is true.
Then, 'tr.writepending()' unintentionally returns False, if there is
no other (e.g. changelog) changes pending, even though dirstate
changes are already written out at '_savebackup()'.
To avoid such situation, this patch makes '_savebackup()' explicitly
invoke 'tr.addfilegenerator()', if transaction is running.
'_savebackup()' should get awareness of transaction before 'write()',
because the former depends on the behavior of the latter before this
patch.
2015-10-13 20:49:17 +03:00
|
|
|
return self._pendingfilename
|
|
|
|
else:
|
|
|
|
return self._filename
|
|
|
|
|
2017-07-13 01:24:07 +03:00
|
|
|
def savebackup(self, tr, backupname):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Save current dirstate into backup file"""
|
2015-10-16 19:15:33 +03:00
|
|
|
filename = self._actualfilename(tr)
|
2017-07-13 01:24:07 +03:00
|
|
|
assert backupname != filename
|
dirstate: make functions for backup aware of transaction activity
Some comments in this patch assume that subsequent patch changes
'dirstate.write()' like as below:
def write(self, repo):
if not self._dirty:
return
tr = repo.currenttransaction()
if tr:
tr.addfilegenerator('dirstate', (self._filename,),
self._writedirstate, location='plain')
return # omit actual writing out
st = self._opener('dirstate', "w", atomictemp=True)
self._writedirstate(st)
This patch makes '_savebackup()' write in-memory changes out, and it
causes clearing 'self._dirty'. If dirstate isn't changed after
'_savebackup()', subsequent 'dirstate.write()' never invokes
'tr.addfilegenerator()' because 'not self._dirty' is true.
Then, 'tr.writepending()' unintentionally returns False, if there is
no other (e.g. changelog) changes pending, even though dirstate
changes are already written out at '_savebackup()'.
To avoid such situation, this patch makes '_savebackup()' explicitly
invoke 'tr.addfilegenerator()', if transaction is running.
'_savebackup()' should get awareness of transaction before 'write()',
because the former depends on the behavior of the latter before this
patch.
2015-10-13 20:49:17 +03:00
|
|
|
|
|
|
|
# use '_writedirstate' instead of 'write' to write changes certainly,
|
|
|
|
# because the latter omits writing out if transaction is running.
|
|
|
|
# output file will be used to create backup of dirstate at this point.
|
2017-03-02 05:21:06 +03:00
|
|
|
if self._dirty or not self._opener.exists(filename):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._writedirstate(
|
|
|
|
self._opener(filename, "w", atomictemp=True, checkambig=True)
|
|
|
|
)
|
dirstate: make functions for backup aware of transaction activity
Some comments in this patch assume that subsequent patch changes
'dirstate.write()' like as below:
def write(self, repo):
if not self._dirty:
return
tr = repo.currenttransaction()
if tr:
tr.addfilegenerator('dirstate', (self._filename,),
self._writedirstate, location='plain')
return # omit actual writing out
st = self._opener('dirstate', "w", atomictemp=True)
self._writedirstate(st)
This patch makes '_savebackup()' write in-memory changes out, and it
causes clearing 'self._dirty'. If dirstate isn't changed after
'_savebackup()', subsequent 'dirstate.write()' never invokes
'tr.addfilegenerator()' because 'not self._dirty' is true.
Then, 'tr.writepending()' unintentionally returns False, if there is
no other (e.g. changelog) changes pending, even though dirstate
changes are already written out at '_savebackup()'.
To avoid such situation, this patch makes '_savebackup()' explicitly
invoke 'tr.addfilegenerator()', if transaction is running.
'_savebackup()' should get awareness of transaction before 'write()',
because the former depends on the behavior of the latter before this
patch.
2015-10-13 20:49:17 +03:00
|
|
|
|
|
|
|
if tr:
|
|
|
|
# ensure that subsequent tr.writepending returns True for
|
|
|
|
# changes written out above, even if dirstate is never
|
|
|
|
# changed after this
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
tr.addfilegenerator(
|
2018-09-28 17:08:40 +03:00
|
|
|
"dirstate", (self._filename,), self._writedirstate, location="local"
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
)
|
dirstate: make functions for backup aware of transaction activity
Some comments in this patch assume that subsequent patch changes
'dirstate.write()' like as below:
def write(self, repo):
if not self._dirty:
return
tr = repo.currenttransaction()
if tr:
tr.addfilegenerator('dirstate', (self._filename,),
self._writedirstate, location='plain')
return # omit actual writing out
st = self._opener('dirstate', "w", atomictemp=True)
self._writedirstate(st)
This patch makes '_savebackup()' write in-memory changes out, and it
causes clearing 'self._dirty'. If dirstate isn't changed after
'_savebackup()', subsequent 'dirstate.write()' never invokes
'tr.addfilegenerator()' because 'not self._dirty' is true.
Then, 'tr.writepending()' unintentionally returns False, if there is
no other (e.g. changelog) changes pending, even though dirstate
changes are already written out at '_savebackup()'.
To avoid such situation, this patch makes '_savebackup()' explicitly
invoke 'tr.addfilegenerator()', if transaction is running.
'_savebackup()' should get awareness of transaction before 'write()',
because the former depends on the behavior of the latter before this
patch.
2015-10-13 20:49:17 +03:00
|
|
|
|
|
|
|
# ensure that pending file written above is unlinked at
|
|
|
|
# failure, even if tr.writepending isn't invoked until the
|
|
|
|
# end of this transaction
|
2018-09-28 17:08:40 +03:00
|
|
|
tr.registertmp(filename, location="local")
|
dirstate: make functions for backup aware of transaction activity
Some comments in this patch assume that subsequent patch changes
'dirstate.write()' like as below:
def write(self, repo):
if not self._dirty:
return
tr = repo.currenttransaction()
if tr:
tr.addfilegenerator('dirstate', (self._filename,),
self._writedirstate, location='plain')
return # omit actual writing out
st = self._opener('dirstate', "w", atomictemp=True)
self._writedirstate(st)
This patch makes '_savebackup()' write in-memory changes out, and it
causes clearing 'self._dirty'. If dirstate isn't changed after
'_savebackup()', subsequent 'dirstate.write()' never invokes
'tr.addfilegenerator()' because 'not self._dirty' is true.
Then, 'tr.writepending()' unintentionally returns False, if there is
no other (e.g. changelog) changes pending, even though dirstate
changes are already written out at '_savebackup()'.
To avoid such situation, this patch makes '_savebackup()' explicitly
invoke 'tr.addfilegenerator()', if transaction is running.
'_savebackup()' should get awareness of transaction before 'write()',
because the former depends on the behavior of the latter before this
patch.
2015-10-13 20:49:17 +03:00
|
|
|
|
2017-03-21 16:50:28 +03:00
|
|
|
self._opener.tryunlink(backupname)
|
2017-03-02 04:59:21 +03:00
|
|
|
# hardlink backup is okay because _writedirstate is always called
|
|
|
|
# with an "atomictemp=True" file.
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
util.copyfile(
|
|
|
|
self._opener.join(filename), self._opener.join(backupname), hardlink=True
|
|
|
|
)
|
2015-10-13 20:49:17 +03:00
|
|
|
|
2017-07-13 01:24:07 +03:00
|
|
|
def restorebackup(self, tr, backupname):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Restore dirstate by backup file"""
|
2015-10-13 20:49:17 +03:00
|
|
|
# this "invalidate()" prevents "wlock.release()" from writing
|
|
|
|
# changes of dirstate out after restoring from backup file
|
|
|
|
self.invalidate()
|
2015-10-16 19:15:33 +03:00
|
|
|
filename = self._actualfilename(tr)
|
2017-10-20 15:53:35 +03:00
|
|
|
o = self._opener
|
|
|
|
if util.samefile(o.join(backupname), o.join(filename)):
|
|
|
|
o.unlink(backupname)
|
|
|
|
else:
|
|
|
|
o.rename(backupname, filename, checkambig=True)
|
2017-07-13 01:24:07 +03:00
|
|
|
|
|
|
|
def clearbackup(self, tr, backupname):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Clear backup file"""
|
2017-07-13 01:24:07 +03:00
|
|
|
self._opener.unlink(backupname)
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2019-04-04 21:23:55 +03:00
|
|
|
def loginfo(self, ui, prefix):
|
|
|
|
try:
|
|
|
|
parents = [hex(p) if p != nullid else "" for p in self._pl]
|
|
|
|
except Exception:
|
|
|
|
# The dirstate may be too corrupt to read. We don't want to fail
|
|
|
|
# just because of logging, so log the parents as unknown.
|
|
|
|
parents = ("unknown", "unknown")
|
2019-04-04 21:23:56 +03:00
|
|
|
data = {
|
|
|
|
prefix + "checkoutidentifier": self.checkoutidentifier,
|
|
|
|
prefix + "wdirparent1": parents[0],
|
|
|
|
prefix + "wdirparent2": parents[1],
|
|
|
|
}
|
2019-04-23 12:45:38 +03:00
|
|
|
ui.log("dirstate_info", **data)
|
2019-04-04 21:23:55 +03:00
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
class dirstatemap(object):
|
2017-11-15 12:07:42 +03:00
|
|
|
"""Map encapsulating the dirstate's contents.
|
|
|
|
|
|
|
|
The dirstate contains the following state:
|
|
|
|
|
|
|
|
- `identity` is the identity of the dirstate file, which can be used to
|
|
|
|
detect when changes have occurred to the dirstate file.
|
|
|
|
|
|
|
|
- `parents` is a pair containing the parents of the working copy. The
|
|
|
|
parents are updated by calling `setparents`.
|
|
|
|
|
|
|
|
- the state map maps filenames to tuples of (state, mode, size, mtime),
|
|
|
|
where state is a single character representing 'normal', 'added',
|
2017-11-15 12:07:42 +03:00
|
|
|
'removed', or 'merged'. It is read by treating the dirstate as a
|
|
|
|
dict. File state is updated by calling the `addfile`, `removefile` and
|
2018-10-12 19:35:04 +03:00
|
|
|
`untrackfile` methods.
|
2017-11-15 12:07:42 +03:00
|
|
|
|
|
|
|
- `copymap` maps destination filenames to their source filename.
|
|
|
|
|
|
|
|
The dirstate also provides the following views onto the state:
|
|
|
|
|
|
|
|
- `nonnormalset` is a set of the filenames that have state other
|
|
|
|
than 'normal', or are normal but have an mtime of -1 ('normallookup').
|
|
|
|
|
|
|
|
- `otherparentset` is a set of the filenames that are marked as coming
|
|
|
|
from the second parent when the dirstate is currently being merged.
|
|
|
|
|
|
|
|
- `filefoldmap` is a dict mapping normalized filenames to the denormalized
|
|
|
|
form that they appear as in the dirstate.
|
|
|
|
|
|
|
|
- `dirfoldmap` is a dict mapping normalized directory names to the
|
|
|
|
denormalized form that they appear as in the dirstate.
|
|
|
|
"""
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def __init__(self, ui, opener, root):
|
|
|
|
self._ui = ui
|
|
|
|
self._opener = opener
|
|
|
|
self._root = root
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._filename = "dirstate"
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
self._parents = None
|
|
|
|
self._dirtyparents = False
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
# for consistent view between _pl() and _read() invocations
|
|
|
|
self._pendingmode = None
|
|
|
|
|
2017-10-27 02:15:36 +03:00
|
|
|
@propertycache
|
|
|
|
def _map(self):
|
|
|
|
self._map = {}
|
|
|
|
self.read()
|
|
|
|
return self._map
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def copymap(self):
|
|
|
|
self.copymap = {}
|
|
|
|
self._map
|
|
|
|
return self.copymap
|
|
|
|
|
2017-10-27 02:15:31 +03:00
|
|
|
def clear(self):
|
2017-10-28 22:35:54 +03:00
|
|
|
self._map.clear()
|
|
|
|
self.copymap.clear()
|
2017-10-27 02:15:31 +03:00
|
|
|
self.setparents(nullid, nullid)
|
2017-11-15 12:07:42 +03:00
|
|
|
util.clearcachedproperty(self, "_dirs")
|
|
|
|
util.clearcachedproperty(self, "_alldirs")
|
2017-11-08 20:23:53 +03:00
|
|
|
util.clearcachedproperty(self, "filefoldmap")
|
|
|
|
util.clearcachedproperty(self, "dirfoldmap")
|
|
|
|
util.clearcachedproperty(self, "nonnormalset")
|
|
|
|
util.clearcachedproperty(self, "otherparentset")
|
2017-10-27 02:15:31 +03:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def iteritems(self):
|
|
|
|
return self._map.iteritems()
|
|
|
|
|
2017-10-01 18:46:02 +03:00
|
|
|
def __len__(self):
|
|
|
|
return len(self._map)
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def __iter__(self):
|
|
|
|
return iter(self._map)
|
|
|
|
|
|
|
|
def get(self, key, default=None):
|
|
|
|
return self._map.get(key, default)
|
|
|
|
|
|
|
|
def __contains__(self, key):
|
|
|
|
return key in self._map
|
|
|
|
|
|
|
|
def __getitem__(self, key):
|
|
|
|
return self._map[key]
|
|
|
|
|
|
|
|
def keys(self):
|
|
|
|
return self._map.keys()
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-10-28 22:35:54 +03:00
|
|
|
def preload(self):
|
|
|
|
"""Loads the underlying data, if it's not already loaded"""
|
|
|
|
self._map
|
|
|
|
|
2017-11-15 12:07:42 +03:00
|
|
|
def addfile(self, f, oldstate, state, mode, size, mtime):
|
2017-11-15 12:07:42 +03:00
|
|
|
"""Add a tracked file to the dirstate."""
|
2017-11-15 12:07:42 +03:00
|
|
|
if oldstate in "?r" and "_dirs" in self.__dict__:
|
|
|
|
self._dirs.addpath(f)
|
|
|
|
if oldstate == "?" and "_alldirs" in self.__dict__:
|
|
|
|
self._alldirs.addpath(f)
|
2018-01-03 16:35:56 +03:00
|
|
|
self._insert_tuple(f, state, mode, size, mtime)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if state != "n" or mtime == -1:
|
2017-11-15 12:07:42 +03:00
|
|
|
self.nonnormalset.add(f)
|
|
|
|
if size == -2:
|
|
|
|
self.otherparentset.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
|
2017-11-15 12:07:42 +03:00
|
|
|
def removefile(self, f, oldstate, size):
|
2017-11-15 12:07:42 +03:00
|
|
|
"""
|
|
|
|
Mark a file as removed in the dirstate.
|
|
|
|
|
|
|
|
The `size` parameter is used to store sentinel values that indicate
|
|
|
|
the file's previous state. In the future, we should refactor this
|
|
|
|
to be more explicit about what that state is.
|
|
|
|
"""
|
2017-11-15 12:07:42 +03:00
|
|
|
if oldstate not in "?r" and "_dirs" in self.__dict__:
|
|
|
|
self._dirs.delpath(f)
|
|
|
|
if oldstate == "?" and "_alldirs" in self.__dict__:
|
|
|
|
self._alldirs.addpath(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
if "filefoldmap" in self.__dict__:
|
|
|
|
normed = util.normcase(f)
|
|
|
|
self.filefoldmap.pop(normed, None)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self._insert_tuple(f, "r", 0, size, 0)
|
2017-11-15 12:07:42 +03:00
|
|
|
self.nonnormalset.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
|
2018-10-12 19:35:08 +03:00
|
|
|
def deletefile(self, f, oldstat):
|
|
|
|
"""
|
|
|
|
Removes a file from the dirstate entirely, implying it doesn't even
|
|
|
|
exist on disk anymore and may not be untracked.
|
|
|
|
"""
|
|
|
|
# In the default dirstate implementation, deletefile is the same as
|
|
|
|
# untrackfile.
|
|
|
|
self.untrackfile(f, oldstat)
|
|
|
|
|
2018-10-12 19:35:04 +03:00
|
|
|
def untrackfile(self, f, oldstate):
|
2017-11-15 12:07:42 +03:00
|
|
|
"""
|
2018-10-12 19:35:04 +03:00
|
|
|
Remove a file from the dirstate, leaving it untracked. Returns True if
|
|
|
|
the file was previously recorded.
|
2017-11-15 12:07:42 +03:00
|
|
|
"""
|
2017-11-15 12:07:42 +03:00
|
|
|
exists = self._map.pop(f, None) is not None
|
2017-11-15 12:07:42 +03:00
|
|
|
if exists:
|
2017-11-15 12:07:42 +03:00
|
|
|
if oldstate != "r" and "_dirs" in self.__dict__:
|
|
|
|
self._dirs.delpath(f)
|
|
|
|
if "_alldirs" in self.__dict__:
|
|
|
|
self._alldirs.delpath(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
if "filefoldmap" in self.__dict__:
|
|
|
|
normed = util.normcase(f)
|
|
|
|
self.filefoldmap.pop(normed, None)
|
2017-11-15 12:07:42 +03:00
|
|
|
self.nonnormalset.discard(f)
|
|
|
|
return exists
|
|
|
|
|
|
|
|
def clearambiguoustimes(self, files, now):
|
|
|
|
for f in files:
|
|
|
|
e = self.get(f)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if e is not None and e[0] == "n" and e[3] == now:
|
2018-01-03 16:35:56 +03:00
|
|
|
self._insert_tuple(f, e[0], e[1], e[2], -1)
|
2017-11-15 12:07:42 +03:00
|
|
|
self.nonnormalset.add(f)
|
2017-11-15 12:07:42 +03:00
|
|
|
|
2018-01-03 16:35:56 +03:00
|
|
|
def _insert_tuple(self, f, state, mode, size, mtime):
|
|
|
|
self._map[f] = dirstatetuple(state, mode, size, mtime)
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def nonnormalentries(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
"""Compute the nonnormal dirstate entries from the dmap"""
|
2017-09-26 13:56:20 +03:00
|
|
|
try:
|
|
|
|
return parsers.nonnormalotherparententries(self._map)
|
|
|
|
except AttributeError:
|
|
|
|
nonnorm = set()
|
|
|
|
otherparent = set()
|
|
|
|
for fname, e in self._map.iteritems():
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if e[0] != "n" or e[3] == -1:
|
2017-09-26 13:56:20 +03:00
|
|
|
nonnorm.add(fname)
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if e[0] == "n" and e[2] == -2:
|
2017-09-26 13:56:20 +03:00
|
|
|
otherparent.add(fname)
|
|
|
|
return nonnorm, otherparent
|
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
@propertycache
|
2017-09-26 13:56:20 +03:00
|
|
|
def filefoldmap(self):
|
|
|
|
"""Returns a dictionary mapping normalized case paths to their
|
|
|
|
non-normalized versions.
|
|
|
|
"""
|
|
|
|
try:
|
|
|
|
makefilefoldmap = parsers.make_file_foldmap
|
|
|
|
except AttributeError:
|
|
|
|
pass
|
|
|
|
else:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return makefilefoldmap(self._map, util.normcasespec, util.normcasefallback)
|
2017-09-26 13:56:20 +03:00
|
|
|
|
|
|
|
f = {}
|
|
|
|
normcase = util.normcase
|
|
|
|
for name, s in self._map.iteritems():
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if s[0] != "r":
|
2017-09-26 13:56:20 +03:00
|
|
|
f[normcase(name)] = name
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
f["."] = "." # prevents useless util.fspath() invocation
|
2017-09-26 13:56:20 +03:00
|
|
|
return f
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-11-15 12:07:42 +03:00
|
|
|
def hastrackeddir(self, d):
|
|
|
|
"""
|
|
|
|
Returns True if the dirstate contains a tracked (not removed) file
|
|
|
|
in this directory.
|
|
|
|
"""
|
|
|
|
return d in self._dirs
|
|
|
|
|
|
|
|
def hasdir(self, d):
|
2017-09-26 13:56:20 +03:00
|
|
|
"""
|
2017-11-15 12:07:42 +03:00
|
|
|
Returns True if the dirstate contains a file (tracked or removed)
|
|
|
|
in this directory.
|
|
|
|
"""
|
|
|
|
return d in self._alldirs
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def _dirs(self):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
return util.dirs(self._map, "r")
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-11-15 12:07:42 +03:00
|
|
|
@propertycache
|
|
|
|
def _alldirs(self):
|
|
|
|
return util.dirs(self._map)
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def _opendirstatefile(self):
|
|
|
|
fp, mode = txnutil.trypending(self._root, self._opener, self._filename)
|
|
|
|
if self._pendingmode is not None and self._pendingmode != mode:
|
|
|
|
fp.close()
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.Abort(_("working directory state may be " "changed parallelly"))
|
2017-09-26 13:56:20 +03:00
|
|
|
self._pendingmode = mode
|
|
|
|
return fp
|
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
def parents(self):
|
2017-09-26 13:56:20 +03:00
|
|
|
if not self._parents:
|
|
|
|
try:
|
|
|
|
fp = self._opendirstatefile()
|
|
|
|
st = fp.read(40)
|
|
|
|
fp.close()
|
|
|
|
except IOError as err:
|
|
|
|
if err.errno != errno.ENOENT:
|
|
|
|
raise
|
|
|
|
# File doesn't exist, so the current state is empty
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
st = ""
|
2017-09-26 13:56:20 +03:00
|
|
|
|
2017-09-26 13:56:20 +03:00
|
|
|
l = len(st)
|
|
|
|
if l == 40:
|
2017-09-26 13:56:20 +03:00
|
|
|
self._parents = st[:20], st[20:40]
|
|
|
|
elif l == 0:
|
|
|
|
self._parents = [nullid, nullid]
|
|
|
|
else:
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
raise error.Abort(_("working directory state appears " "damaged!"))
|
2017-09-26 13:56:20 +03:00
|
|
|
|
|
|
|
return self._parents
|
|
|
|
|
|
|
|
def setparents(self, p1, p2):
|
|
|
|
self._parents = (p1, p2)
|
|
|
|
self._dirtyparents = True
|
2017-10-05 21:34:41 +03:00
|
|
|
|
|
|
|
def read(self):
|
2017-10-05 21:34:41 +03:00
|
|
|
# ignore HG_PENDING because identity is used only for writing
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
self.identity = util.filestat.frompath(self._opener.join(self._filename))
|
2017-10-05 21:34:41 +03:00
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
try:
|
|
|
|
fp = self._opendirstatefile()
|
|
|
|
try:
|
|
|
|
st = fp.read()
|
|
|
|
finally:
|
|
|
|
fp.close()
|
|
|
|
except IOError as err:
|
|
|
|
if err.errno != errno.ENOENT:
|
|
|
|
raise
|
|
|
|
return
|
|
|
|
if not st:
|
|
|
|
return
|
|
|
|
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
if util.safehasattr(parsers, "dict_new_presized"):
|
2017-10-05 21:34:41 +03:00
|
|
|
# Make an estimate of the number of files in the dirstate based on
|
|
|
|
# its size. From a linear regression on a set of real-world repos,
|
|
|
|
# all over 10,000 files, the size of a dirstate entry is 85
|
|
|
|
# bytes. The cost of resizing is significantly higher than the cost
|
|
|
|
# of filling in a larger presized dict, so subtract 20% from the
|
|
|
|
# size.
|
|
|
|
#
|
|
|
|
# This heuristic is imperfect in many ways, so in a future dirstate
|
|
|
|
# format update it makes sense to just record the number of entries
|
|
|
|
# on write.
|
|
|
|
self._map = parsers.dict_new_presized(len(st) / 71)
|
|
|
|
|
|
|
|
# Python's garbage collector triggers a GC each time a certain number
|
|
|
|
# of container objects (the number being defined by
|
|
|
|
# gc.get_threshold()) are allocated. parse_dirstate creates a tuple
|
|
|
|
# for each file in the dirstate. The C version then immediately marks
|
|
|
|
# them as not to be tracked by the collector. However, this has no
|
|
|
|
# effect on when GCs are triggered, only on what objects the GC looks
|
|
|
|
# into. This means that O(number of files) GCs are unavoidable.
|
|
|
|
# Depending on when in the process's lifetime the dirstate is parsed,
|
|
|
|
# this can get very expensive. As a workaround, disable GC while
|
|
|
|
# parsing the dirstate.
|
|
|
|
#
|
|
|
|
# (we cannot decorate the function directly since it is in a C module)
|
|
|
|
parse_dirstate = util.nogc(parsers.parse_dirstate)
|
|
|
|
p = parse_dirstate(self._map, self.copymap, st)
|
|
|
|
if not self._dirtyparents:
|
|
|
|
self.setparents(*p)
|
2017-10-05 21:34:41 +03:00
|
|
|
|
2017-10-28 22:35:54 +03:00
|
|
|
# Avoid excess attribute lookups by fast pathing certain checks
|
|
|
|
self.__contains__ = self._map.__contains__
|
|
|
|
self.__getitem__ = self._map.__getitem__
|
|
|
|
self.get = self._map.get
|
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
def write(self, st, now):
|
codemod: join the auto-formatter party
Summary:
Turned on the auto formatter. Ran `arc lint --apply-patches --take BLACK **/*.py`.
Then run `arc lint` again so some other autofixers like spellchecker etc. looked
at the code base. Manually accept the changes whenever they make sense, or use
a workaround (ex. changing "dict()" to "dict constructor") where autofix is false
positive. Disabled linters on files that are hard (i18n/polib.py) to fix, or less
interesting to fix (hgsubversion tests), or cannot be fixed without breaking
OSS build (FBPYTHON4).
Conflicted linters (test-check-module-imports.t, part of test-check-code.t,
test-check-pyflakes.t) are removed or disabled.
Duplicated linters (test-check-pyflakes.t, test-check-pylint.t) are removed.
An issue of the auto-formatter is lines are no longer guarnateed to be <= 80
chars. But that seems less important comparing with the benefit auto-formatter
provides.
As we're here, also remove test-check-py3-compat.t, as it is currently broken
if `PYTHON3=/bin/python3` is set.
Reviewed By: wez, phillco, simpkins, pkaush, singhsrb
Differential Revision: D8173629
fbshipit-source-id: 90e248ae0c5e6eaadbe25520a6ee42d32005621b
2018-05-26 07:34:37 +03:00
|
|
|
st.write(parsers.pack_dirstate(self._map, self.copymap, self.parents(), now))
|
2017-10-05 21:34:41 +03:00
|
|
|
st.close()
|
|
|
|
self._dirtyparents = False
|
2017-10-05 21:34:41 +03:00
|
|
|
self.nonnormalset, self.otherparentset = self.nonnormalentries()
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def nonnormalset(self):
|
|
|
|
nonnorm, otherparents = self.nonnormalentries()
|
|
|
|
self.otherparentset = otherparents
|
|
|
|
return nonnorm
|
|
|
|
|
|
|
|
@propertycache
|
|
|
|
def otherparentset(self):
|
|
|
|
nonnorm, otherparents = self.nonnormalentries()
|
|
|
|
self.nonnormalset = nonnorm
|
|
|
|
return otherparents
|
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
@propertycache
|
|
|
|
def identity(self):
|
2017-10-27 02:15:36 +03:00
|
|
|
self._map
|
2017-10-05 21:34:41 +03:00
|
|
|
return self.identity
|
|
|
|
|
2017-10-05 21:34:41 +03:00
|
|
|
@propertycache
|
|
|
|
def dirfoldmap(self):
|
|
|
|
f = {}
|
|
|
|
normcase = util.normcase
|
2017-11-15 12:07:42 +03:00
|
|
|
for name in self._dirs:
|
2017-10-05 21:34:41 +03:00
|
|
|
f[normcase(name)] = name
|
|
|
|
return f
|