sapling/eden/fs/store/RocksDbLocalStore.cpp

557 lines
18 KiB
C++
Raw Normal View History

/*
* Copyright (c) 2016-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
*/
#include "eden/fs/store/RocksDbLocalStore.h"
#include <array>
#include <folly/Format.h>
#include <folly/String.h>
#include <folly/futures/Future.h>
#include <folly/io/Cursor.h>
#include <folly/io/IOBuf.h>
#include <folly/lang/Bits.h>
#include <folly/logging/xlog.h>
#include <rocksdb/convenience.h>
#include <rocksdb/db.h>
#include <rocksdb/filter_policy.h>
#include <rocksdb/table.h>
#include "eden/fs/rocksdb/RocksException.h"
#include "eden/fs/rocksdb/RocksHandles.h"
#include "eden/fs/store/KeySpaces.h"
#include "eden/fs/store/StoreResult.h"
Fix deadlock when restarting during RocksDbLocalStore::get() Summary: If TreeInode::startLoadingInode() is in progress, and EdenServer::startTakeoverShutdown() is called, edenfs can deadlock: 1. Thread A: A FUSE request calls TreeInode::readdir() -> TreeInode::prefetch() -> TreeInode::startLoadingInode() on the children TreeInode-s -> RocksDbLocalStore::getFuture(). 2. Thread B: A takeover request calls EdenServer::performTakeoverShutdown() -> InodeMap::shutdown(). 3. Thread C: RocksDbLocalStore::getFuture() (called in step 1) completes -> TreeInode::inodeLoadComplete(). (The inodeLoadComplete continuation was registered by TreeInode::registerInodeLoadComplete().) 4. Thread C: After TreeInode::inodeLoadComplete() returns, the TreeInode's InodePtr is destructed, dropping the reference count to 0. 5. Thread C: InodeMap::onInodeUnreferenced() -> InodeMap::shutdownComplete() -> EdenMount::shutdown() (called in step 2) completes -> EdenServer::performTakeoverShutdown(). 6. Thread C: EdenServer::performTakeoverShutdown() -> localStore_.reset() -> RocksDbLocalStore::~RocksDbLocalStore(). 7. Thread C: RocksDbLocalStore::~RocksDbLocalStore() signals the thread pool to exit and waits for the pool's threads to exit. Because thread C is one of the threads managed by RocksDbLocalStore's thread pool, the signal is never handled and RocksDbLocalStore::~RocksDbLocalStore() never finishes. Fix this deadlock by executing EdenServer::shutdown()'s callback (in EdenServer::performTakeoverShutdown()) on a different thread. Reviewed By: simpkins Differential Revision: D14337058 fbshipit-source-id: 1d63b4e7d8f5103a2dde31e329150bf763be3db7
2019-03-13 05:25:54 +03:00
#include "eden/fs/utils/FaultInjector.h"
using facebook::eden::Hash;
using folly::ByteRange;
using folly::IOBuf;
using folly::StringPiece;
using folly::io::Cursor;
using rocksdb::FlushOptions;
using rocksdb::ReadOptions;
using rocksdb::Slice;
using rocksdb::SliceParts;
using rocksdb::WriteBatch;
using rocksdb::WriteOptions;
using std::string;
using std::unique_ptr;
namespace {
using namespace facebook::eden;
rocksdb::ColumnFamilyOptions makeColumnOptions(uint64_t LRUblockCacheSizeMB) {
rocksdb::ColumnFamilyOptions options;
// We'll never perform range scans on any of the keys that we store.
// This enables bloom filters and a hash policy that improves our
// get/put performance.
options.OptimizeForPointLookup(LRUblockCacheSizeMB);
options.OptimizeLevelStyleCompaction();
return options;
}
/**
* The different key spaces that we desire.
* The ordering is coupled with the values of the LocalStore::KeySpace enum.
*/
const std::vector<rocksdb::ColumnFamilyDescriptor>& columnFamilies() {
auto makeColumnFamilyDescriptors = [] {
// Most of the column families will share the same cache. We
// want the blob data to live in its own smaller cache; the assumption
// is that the vfs cache will compensate for that, together with the
// idea that we shouldn't need to materialize a great many files.
auto options = makeColumnOptions(64);
auto blobOptions = makeColumnOptions(8);
// Meyers singleton to avoid SIOF issues
std::vector<rocksdb::ColumnFamilyDescriptor> families;
for (size_t ks = 0; ks < kKeySpaceRecords.size(); ++ks) {
families.emplace_back(
kKeySpaceRecords[ks].name.str(),
(ks == LocalStore::BlobFamily) ? blobOptions : options);
}
// Put the default column family last.
// This way the KeySpace enum values can be used directly as indexes
// into our column family vectors.
families.emplace_back(rocksdb::kDefaultColumnFamilyName, options);
return families;
};
// Meyers singleton to avoid SIOF issues
static const std::vector<rocksdb::ColumnFamilyDescriptor> families =
makeColumnFamilyDescriptors();
return families;
}
/**
* Return a rocksdb::Range that contains all possible keys that we store.
*
* The input string will be used to store data for the Range slices.
* The caller must ensure that the rangeStorage parameter remains valid and
* unmodified until they are done using the returned Range.
*/
rocksdb::Range getFullRange(std::string& rangeStorage) {
// An empty slice is the lowest possible value.
Slice begin;
// All of our keys are currently 20 bytes.
// Use a longer key to ensure that this is greater than any valid key.
rangeStorage = std::string(
21, static_cast<char>(std::numeric_limits<unsigned char>::max()));
Slice end(rangeStorage);
return rocksdb::Range(begin, end);
}
rocksdb::Slice _createSlice(folly::ByteRange bytes) {
return Slice(reinterpret_cast<const char*>(bytes.data()), bytes.size());
}
class RocksDbWriteBatch : public LocalStore::WriteBatch {
public:
void put(
LocalStore::KeySpace keySpace,
folly::ByteRange key,
folly::ByteRange value) override;
void put(
LocalStore::KeySpace keySpace,
folly::ByteRange key,
std::vector<folly::ByteRange> valueSlices) override;
void flush() override;
~RocksDbWriteBatch() override;
// Use LocalStore::beginWrite() to create a write batch
RocksDbWriteBatch(RocksHandles& dbHandles, size_t bufferSize);
void flushIfNeeded();
RocksHandles& dbHandles_;
rocksdb::WriteBatch writeBatch_;
size_t bufSize_;
};
void RocksDbWriteBatch::flush() {
auto pending = writeBatch_.Count();
if (pending == 0) {
return;
}
XLOG(DBG5) << "Flushing " << pending << " entries with data size of "
<< writeBatch_.GetDataSize();
auto status = dbHandles_.db->Write(WriteOptions(), &writeBatch_);
XLOG(DBG5) << "... Flushed";
if (!status.ok()) {
throw RocksException::build(
status, "error putting blob batch in local store");
}
writeBatch_.Clear();
}
void RocksDbWriteBatch::flushIfNeeded() {
auto needFlush = bufSize_ > 0 && writeBatch_.GetDataSize() >= bufSize_;
if (needFlush) {
flush();
}
}
RocksDbWriteBatch::RocksDbWriteBatch(RocksHandles& dbHandles, size_t bufSize)
: LocalStore::WriteBatch(),
dbHandles_(dbHandles),
writeBatch_(bufSize),
bufSize_(bufSize) {}
RocksDbWriteBatch::~RocksDbWriteBatch() {
if (writeBatch_.Count() > 0) {
XLOG(ERR) << "WriteBatch being destroyed with " << writeBatch_.Count()
<< " items pending flush";
}
}
void RocksDbWriteBatch::put(
LocalStore::KeySpace keySpace,
folly::ByteRange key,
folly::ByteRange value) {
writeBatch_.Put(
dbHandles_.columns[keySpace].get(),
_createSlice(key),
_createSlice(value));
flushIfNeeded();
}
void RocksDbWriteBatch::put(
LocalStore::KeySpace keySpace,
folly::ByteRange key,
std::vector<folly::ByteRange> valueSlices) {
std::vector<Slice> slices;
for (auto& valueSlice : valueSlices) {
slices.emplace_back(_createSlice(valueSlice));
}
auto keySlice = _createSlice(key);
SliceParts keyParts(&keySlice, 1);
writeBatch_.Put(
dbHandles_.columns[keySpace].get(),
keyParts,
SliceParts(slices.data(), slices.size()));
flushIfNeeded();
}
rocksdb::Options getRocksdbOptions() {
rocksdb::Options options;
// Optimize RocksDB. This is the easiest way to get RocksDB to perform well.
options.IncreaseParallelism();
// Create the DB if it's not already present.
options.create_if_missing = true;
// Automatically create column families as we define new ones.
options.create_missing_column_families = true;
return options;
}
RocksHandles openDB(AbsolutePathPiece path, RocksDBOpenMode mode) {
auto options = getRocksdbOptions();
try {
return RocksHandles(path.stringPiece(), mode, options, columnFamilies());
} catch (const RocksException& ex) {
XLOG(ERR) << "Error opening RocksDB storage at " << path << ": "
<< ex.what();
if (mode == RocksDBOpenMode::ReadOnly) {
// In read-only mode fail rather than attempting to repair the DB.
throw;
}
// Fall through and attempt to repair the DB
}
RocksDbLocalStore::repairDB(path);
// Now try opening the DB again.
return RocksHandles(path.stringPiece(), mode, options, columnFamilies());
}
} // namespace
namespace facebook {
namespace eden {
RocksDbLocalStore::RocksDbLocalStore(
AbsolutePathPiece pathToRocksDb,
FaultInjector* faultInjector,
RocksDBOpenMode mode)
: faultInjector_(*faultInjector),
dbHandles_(openDB(pathToRocksDb, mode)),
ioPool_(12, "RocksLocalStore") {}
RocksDbLocalStore::~RocksDbLocalStore() {
#ifdef FOLLY_SANITIZE_ADDRESS
// RocksDB has some race conditions around setting up and tearing down
// the threads that it uses to maintain the database. This manifests
// in our test harness, particularly in a test where we quickly mount
// and then unmount. We see this as an abort with the message:
// "pthread lock: Invalid Argument".
// My assumption is that we're shutting things down before rocks has
// completed initializing. This sleep call is present in the destructor
// to make it more likely that rocks is past that critical point and
// so that we can shutdown successfully.
/* sleep override */ sleep(1);
#endif
}
void RocksDbLocalStore::close() {
dbHandles_.close();
}
void RocksDbLocalStore::repairDB(AbsolutePathPiece path) {
XLOG(ERR) << "Attempting to repair RocksDB " << path;
rocksdb::ColumnFamilyOptions unknownColumFamilyOptions;
unknownColumFamilyOptions.OptimizeForPointLookup(8);
unknownColumFamilyOptions.OptimizeLevelStyleCompaction();
const auto& columnDescriptors = columnFamilies();
auto dbPathStr = path.stringPiece().str();
rocksdb::DBOptions dbOptions(getRocksdbOptions());
auto status = RepairDB(
dbPathStr, dbOptions, columnDescriptors, unknownColumFamilyOptions);
if (!status.ok()) {
throw RocksException::build(status, "unable to repair RocksDB at ", path);
}
}
void RocksDbLocalStore::clearKeySpace(KeySpace keySpace) {
auto columnFamily = dbHandles_.columns[keySpace].get();
std::unique_ptr<rocksdb::Iterator> it{
dbHandles_.db->NewIterator(ReadOptions(), columnFamily)};
XLOG(DBG2) << "clearing column family \"" << columnFamily->GetName() << "\"";
std::string rangeStorage;
const auto fullRange = getFullRange(rangeStorage);
// Delete all SST files that only contain keys in the specified range.
// Since we are deleting everything in this column family this should
// effectively delete everything.
auto status = DeleteFilesInRange(
dbHandles_.db.get(), columnFamily, &fullRange.start, &fullRange.limit);
if (!status.ok()) {
throw RocksException::build(
status,
"error deleting data in \"",
columnFamily->GetName(),
"\" column family");
}
// Call DeleteRange() as well. In theory DeleteFilesInRange may not delete
// everything in the range (but it probably will in our case since we are
// intending to delete everything).
const WriteOptions writeOptions;
status = dbHandles_.db->DeleteRange(
writeOptions, columnFamily, fullRange.start, fullRange.limit);
if (!status.ok()) {
throw RocksException::build(
status,
"error deleting data in \"",
columnFamily->GetName(),
"\" column family");
}
}
void RocksDbLocalStore::compactKeySpace(KeySpace keySpace) {
auto options = rocksdb::CompactRangeOptions{};
options.allow_write_stall = true;
auto columnFamily = dbHandles_.columns[keySpace].get();
XLOG(DBG2) << "compacting column family \"" << columnFamily->GetName()
<< "\"";
auto status = dbHandles_.db->CompactRange(
options, columnFamily, /*begin=*/nullptr, /*end=*/nullptr);
if (!status.ok()) {
throw RocksException::build(
status,
"error compacting \"",
columnFamily->GetName(),
"\" column family");
}
}
StoreResult RocksDbLocalStore::get(LocalStore::KeySpace keySpace, ByteRange key)
const {
string value;
auto status = dbHandles_.db->Get(
ReadOptions(),
dbHandles_.columns[keySpace].get(),
_createSlice(key),
&value);
if (!status.ok()) {
if (status.IsNotFound()) {
// Return an empty StoreResult
return StoreResult();
}
// TODO: RocksDB can return a "TryAgain" error.
// Should we try again for the user, rather than re-throwing the error?
// We don't use RocksException::check(), since we don't want to waste our
// time computing the hex string of the key if we succeeded.
throw RocksException::build(
status, "failed to get ", folly::hexlify(key), " from local store");
}
return StoreResult(std::move(value));
}
FOLLY_NODISCARD folly::Future<StoreResult> RocksDbLocalStore::getFuture(
KeySpace keySpace,
folly::ByteRange key) const {
// We're really just passing key through to the get() method, but we need to
// make a copy of it on the way through. It will usually be an eden::Hash
// but can potentially be an arbitrary length so we can't just use Hash as
// the storage here. std::string is appropriate, but there's some noise
// with the conversion from unsigned/signed and back again.
Fix deadlock when restarting during RocksDbLocalStore::get() Summary: If TreeInode::startLoadingInode() is in progress, and EdenServer::startTakeoverShutdown() is called, edenfs can deadlock: 1. Thread A: A FUSE request calls TreeInode::readdir() -> TreeInode::prefetch() -> TreeInode::startLoadingInode() on the children TreeInode-s -> RocksDbLocalStore::getFuture(). 2. Thread B: A takeover request calls EdenServer::performTakeoverShutdown() -> InodeMap::shutdown(). 3. Thread C: RocksDbLocalStore::getFuture() (called in step 1) completes -> TreeInode::inodeLoadComplete(). (The inodeLoadComplete continuation was registered by TreeInode::registerInodeLoadComplete().) 4. Thread C: After TreeInode::inodeLoadComplete() returns, the TreeInode's InodePtr is destructed, dropping the reference count to 0. 5. Thread C: InodeMap::onInodeUnreferenced() -> InodeMap::shutdownComplete() -> EdenMount::shutdown() (called in step 2) completes -> EdenServer::performTakeoverShutdown(). 6. Thread C: EdenServer::performTakeoverShutdown() -> localStore_.reset() -> RocksDbLocalStore::~RocksDbLocalStore(). 7. Thread C: RocksDbLocalStore::~RocksDbLocalStore() signals the thread pool to exit and waits for the pool's threads to exit. Because thread C is one of the threads managed by RocksDbLocalStore's thread pool, the signal is never handled and RocksDbLocalStore::~RocksDbLocalStore() never finishes. Fix this deadlock by executing EdenServer::shutdown()'s callback (in EdenServer::performTakeoverShutdown()) on a different thread. Reviewed By: simpkins Differential Revision: D14337058 fbshipit-source-id: 1d63b4e7d8f5103a2dde31e329150bf763be3db7
2019-03-13 05:25:54 +03:00
return faultInjector_.checkAsync("local store get single", "")
.via(&ioPool_)
.thenValue([keySpace,
key = std::string(
reinterpret_cast<const char*>(key.data()), key.size()),
this](folly::Unit&&) {
return get(
keySpace,
folly::ByteRange(
reinterpret_cast<const unsigned char*>(key.data()),
key.size()));
});
}
FOLLY_NODISCARD folly::Future<std::vector<StoreResult>>
RocksDbLocalStore::getBatch(
KeySpace keySpace,
const std::vector<folly::ByteRange>& keys) const {
std::vector<folly::Future<std::vector<StoreResult>>> futures;
std::vector<std::shared_ptr<std::vector<std::string>>> batches;
batches.emplace_back(std::make_shared<std::vector<std::string>>());
for (auto& key : keys) {
if (batches.back()->size() >= 2048) {
batches.emplace_back(std::make_shared<std::vector<std::string>>());
}
batches.back()->emplace_back(
reinterpret_cast<const char*>(key.data()), key.size());
}
for (auto& batch : batches) {
futures.emplace_back(
Fix deadlock when restarting during RocksDbLocalStore::get() Summary: If TreeInode::startLoadingInode() is in progress, and EdenServer::startTakeoverShutdown() is called, edenfs can deadlock: 1. Thread A: A FUSE request calls TreeInode::readdir() -> TreeInode::prefetch() -> TreeInode::startLoadingInode() on the children TreeInode-s -> RocksDbLocalStore::getFuture(). 2. Thread B: A takeover request calls EdenServer::performTakeoverShutdown() -> InodeMap::shutdown(). 3. Thread C: RocksDbLocalStore::getFuture() (called in step 1) completes -> TreeInode::inodeLoadComplete(). (The inodeLoadComplete continuation was registered by TreeInode::registerInodeLoadComplete().) 4. Thread C: After TreeInode::inodeLoadComplete() returns, the TreeInode's InodePtr is destructed, dropping the reference count to 0. 5. Thread C: InodeMap::onInodeUnreferenced() -> InodeMap::shutdownComplete() -> EdenMount::shutdown() (called in step 2) completes -> EdenServer::performTakeoverShutdown(). 6. Thread C: EdenServer::performTakeoverShutdown() -> localStore_.reset() -> RocksDbLocalStore::~RocksDbLocalStore(). 7. Thread C: RocksDbLocalStore::~RocksDbLocalStore() signals the thread pool to exit and waits for the pool's threads to exit. Because thread C is one of the threads managed by RocksDbLocalStore's thread pool, the signal is never handled and RocksDbLocalStore::~RocksDbLocalStore() never finishes. Fix this deadlock by executing EdenServer::shutdown()'s callback (in EdenServer::performTakeoverShutdown()) on a different thread. Reviewed By: simpkins Differential Revision: D14337058 fbshipit-source-id: 1d63b4e7d8f5103a2dde31e329150bf763be3db7
2019-03-13 05:25:54 +03:00
faultInjector_.checkAsync("local store get batch", "")
.via(&ioPool_)
.thenValue(
[this, keySpace, keys = std::move(batch)](folly::Unit&&) {
XLOG(DBG3) << __func__ << " starting to actually do work";
Fix deadlock when restarting during RocksDbLocalStore::get() Summary: If TreeInode::startLoadingInode() is in progress, and EdenServer::startTakeoverShutdown() is called, edenfs can deadlock: 1. Thread A: A FUSE request calls TreeInode::readdir() -> TreeInode::prefetch() -> TreeInode::startLoadingInode() on the children TreeInode-s -> RocksDbLocalStore::getFuture(). 2. Thread B: A takeover request calls EdenServer::performTakeoverShutdown() -> InodeMap::shutdown(). 3. Thread C: RocksDbLocalStore::getFuture() (called in step 1) completes -> TreeInode::inodeLoadComplete(). (The inodeLoadComplete continuation was registered by TreeInode::registerInodeLoadComplete().) 4. Thread C: After TreeInode::inodeLoadComplete() returns, the TreeInode's InodePtr is destructed, dropping the reference count to 0. 5. Thread C: InodeMap::onInodeUnreferenced() -> InodeMap::shutdownComplete() -> EdenMount::shutdown() (called in step 2) completes -> EdenServer::performTakeoverShutdown(). 6. Thread C: EdenServer::performTakeoverShutdown() -> localStore_.reset() -> RocksDbLocalStore::~RocksDbLocalStore(). 7. Thread C: RocksDbLocalStore::~RocksDbLocalStore() signals the thread pool to exit and waits for the pool's threads to exit. Because thread C is one of the threads managed by RocksDbLocalStore's thread pool, the signal is never handled and RocksDbLocalStore::~RocksDbLocalStore() never finishes. Fix this deadlock by executing EdenServer::shutdown()'s callback (in EdenServer::performTakeoverShutdown()) on a different thread. Reviewed By: simpkins Differential Revision: D14337058 fbshipit-source-id: 1d63b4e7d8f5103a2dde31e329150bf763be3db7
2019-03-13 05:25:54 +03:00
std::vector<Slice> keySlices;
std::vector<std::string> values;
std::vector<rocksdb::ColumnFamilyHandle*> columns;
for (auto& key : *keys) {
keySlices.emplace_back(key);
columns.emplace_back(dbHandles_.columns[keySpace].get());
}
auto statuses = dbHandles_.db->MultiGet(
ReadOptions(), columns, keySlices, &values);
std::vector<StoreResult> results;
for (size_t i = 0; i < keys->size(); ++i) {
auto& status = statuses[i];
if (!status.ok()) {
if (status.IsNotFound()) {
// Return an empty StoreResult
results.emplace_back(); // StoreResult();
continue;
}
// TODO: RocksDB can return a "TryAgain" error.
// Should we try again for the user, rather than
// re-throwing the error?
// We don't use RocksException::check(), since we don't
// want to waste our time computing the hex string of the
// key if we succeeded.
throw RocksException::build(
status,
"failed to get ",
folly::hexlify(keys->at(i)),
" from local store");
}
results.emplace_back(std::move(values[i]));
}
return results;
}));
}
return folly::collect(futures).thenValue(
[](std::vector<std::vector<StoreResult>>&& tries) {
std::vector<StoreResult> results;
for (auto& batch : tries) {
results.insert(
results.end(),
make_move_iterator(batch.begin()),
make_move_iterator(batch.end()));
}
return results;
});
}
bool RocksDbLocalStore::hasKey(
LocalStore::KeySpace keySpace,
folly::ByteRange key) const {
string value;
auto status = dbHandles_.db->Get(
ReadOptions(),
dbHandles_.columns[keySpace].get(),
_createSlice(key),
&value);
if (!status.ok()) {
if (status.IsNotFound()) {
return false;
}
// TODO: RocksDB can return a "TryAgain" error.
// Should we try again for the user, rather than re-throwing the error?
// We don't use RocksException::check(), since we don't want to waste our
// time computing the hex string of the key if we succeeded.
throw RocksException::build(
status, "failed to get ", folly::hexlify(key), " from local store");
}
return true;
}
std::unique_ptr<LocalStore::WriteBatch> RocksDbLocalStore::beginWrite(
size_t bufSize) {
return std::make_unique<RocksDbWriteBatch>(dbHandles_, bufSize);
}
void RocksDbLocalStore::put(
LocalStore::KeySpace keySpace,
folly::ByteRange key,
folly::ByteRange value) {
dbHandles_.db->Put(
WriteOptions(),
dbHandles_.columns[keySpace].get(),
_createSlice(key),
_createSlice(value));
}
uint64_t RocksDbLocalStore::getApproximateSize(
LocalStore::KeySpace keySpace) const {
uint64_t size = 0;
// kLiveSstFilesSize reports the size of all "live" sst files.
// This excludes sst files from older snapshot versions that RocksDB may
// still be holding onto. e.g., to provide a consistent view to iterators.
// kTotalSstFilesSize would report the size of all sst files if we wanted to
// report that.
uint64_t sstFilesSize;
auto result = dbHandles_.db->GetIntProperty(
dbHandles_.columns[keySpace].get(),
rocksdb::DB::Properties::kLiveSstFilesSize,
&sstFilesSize);
if (result) {
size += sstFilesSize;
} else {
XLOG(WARN) << "unable to retrieve SST file size from RocksDB for key space "
<< dbHandles_.columns[keySpace]->GetName();
}
// kSizeAllMemTables reports the size of the memtables.
// This is the in-memory space for tracking the data in *.log files that have
// not yet been compacted into a .sst file.
//
// We use this as a something that will hopefully roughly approximate the size
// of the *.log files. In practice this generally seems to be a fair amount
// smaller than the on-disk *.log file size, except immediately after a
// compaction when there is still a couple MB of in-memory metadata despite
// having no uncompacted on-disk data.
uint64_t memtableSize;
result = dbHandles_.db->GetIntProperty(
dbHandles_.columns[keySpace].get(),
rocksdb::DB::Properties::kSizeAllMemTables,
&memtableSize);
if (result) {
size += memtableSize;
} else {
XLOG(WARN) << "unable to retrieve memtable size from RocksDB for key space "
<< dbHandles_.columns[keySpace]->GetName();
}
return size;
}
} // namespace eden
} // namespace facebook