facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 16:57:49 +03:00
Code Issues Projects Releases Wiki Activity
9151a3cc24
sapling/tests/test-check-code.t

169 lines
12 KiB
Perl
Raw Normal View History

tests: change some #ifs to #requires
2014-08-06 20:53:08 +04:00
#require test-repo
test-check-code-hg: use test-repo check
2014-05-05 22:42:58 +04:00
tests: silence test-repo obsolete warning refactoring test-check-commit.t HGRCPATH bits as helpers-testrepo.sh
2016-05-11 07:49:27 +03:00
$ . "$TESTDIR/helpers-testrepo.sh"
tests: convert test-check-code-hg.py to .t
2011-11-23 05:50:58 +04:00
$ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/..
tests: check-code all python files in one run
2013-07-06 23:47:56 +04:00
New errors are not allowed. Warnings are strongly discouraged.
check-code: always report when a file is skipped by "no-check-code" Skipping an entire file generally from checking is an important event, so report it always. Do not tell the check name because skipping does not depend on it. Directly skip the entire file instead of checking more patterns and skip again. The pragma no-check-code was introduced by accident in the past. (Fixed in bc3ff9741549 and aa06d5c0d698.) This now is prevented because the files to skip have to be listed in the test output of test-check-code-hg.t.
2014-01-08 01:29:15 +04:00
(The writing "no-che?k-code" is for not skipping this file when checking.)
tests: check-code all python files in one run
2013-07-06 23:47:56 +04:00
codemod: move Python packages to edenscm Summary: Move top-level Python packages `mercurial`, `hgext` and `hgdemandimport` to a new top-level package `edenscm`. This allows the Python packages provided by the upstream Mercurial to be installed side-by-side. To maintain compatibility, `edenscm/` gets added to `sys.path` in `mercurial/__init__.py`. Reviewed By: phillco, ikostia Differential Revision: D13853115 fbshipit-source-id: b296b0673dc54c61ef6a591ebc687057ff53b22e
2019-01-29 05:29:48 +03:00
$ testrepohg files . | egrep -v "^(edenscm/hgext/extlib/pywatchman|edenscm/hgext/p4fastimport|lib/cdatapack|lib/third-party|edenscm/mercurial/thirdparty|fb|newdoc)" \
tests: run check-code.py in parallel via xargs (2x-4x speedup) Summary: This cuts the total time for this test from: Laptop: 24s -> 12.4s Devserver: 23s -> 5.8s Reviewed By: quark-zju Differential Revision: D8721177 fbshipit-source-id: f2922093a72c29f05d08967a77d83fbc65c0ed14
2018-07-03 21:20:37 +03:00
> | sed 's-\\-/-g' > $TESTTMP/files.txt
$ NPROC=`python -c 'import multiprocessing; print(multiprocessing.cpu_count())'`
$ cat $TESTTMP/files.txt | xargs -n64 -P $NPROC contrib/check-code.py --warnings --per-file=0 | sort
codemod: move Python packages to edenscm Summary: Move top-level Python packages `mercurial`, `hgext` and `hgdemandimport` to a new top-level package `edenscm`. This allows the Python packages provided by the upstream Mercurial to be installed side-by-side. To maintain compatibility, `edenscm/` gets added to `sys.path` in `mercurial/__init__.py`. Reviewed By: phillco, ikostia Differential Revision: D13853115 fbshipit-source-id: b296b0673dc54c61ef6a591ebc687057ff53b22e
2019-01-29 05:29:48 +03:00
Skipping edenscm/hgext/extlib/cfastmanifest.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/bsearch.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/bsearch.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/bsearch_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/checksum.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/checksum.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/checksum_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/internal_result.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/node.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/node.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/node_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/path_buffer.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/result.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tests.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tests.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_arena.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_arena.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_convert.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_convert_rt.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_convert_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_copy.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_copy_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_diff.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_diff_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_disk.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_disk_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_dump.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_iterate_rt.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_iterator.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_iterator.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_iterator_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_path.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_path.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cfastmanifest/tree_test.c it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/datapackstore.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/datapackstore.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/datastore.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/deltachain.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/deltachain.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/key.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/match.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/py-cdatapack.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/py-cstore.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/py-datapackstore.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/py-structs.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/py-treemanifest.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/pythondatastore.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/pythondatastore.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/pythonkeyiterator.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/pythonutil.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/pythonutil.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/store.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/uniondatapackstore.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/cstore/uniondatapackstore.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_entry.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_entry.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_fetcher.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_fetcher.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_ptr.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/manifest_ptr.h it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/treemanifest.cpp it has no-che?k-code (glob)
Skipping edenscm/hgext/extlib/ctreemanifest/treemanifest.h it has no-che?k-code (glob)
Skipping edenscm/hgext/globalrevs.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsql.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/__init__.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/compathacks.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/editor.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/hooks/updatemeta.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/layouts/base.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/layouts/custom.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/layouts/standard.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/maps.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/pushmod.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/stupid.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svncommands.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnexternals.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnmeta.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnrepo.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnwrap/__init__.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnwrap/common.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnwrap/subvertpy_wrapper.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/svnwrap/svn_swig_wrapper.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/util.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/verify.py it has no-che?k-code (glob)
Skipping edenscm/hgext/hgsubversion/wrappers.py it has no-che?k-code (glob)
Skipping edenscm/mercurial/httpclient/__init__.py it has no-che?k-code (glob)
Skipping edenscm/mercurial/httpclient/_readers.py it has no-che?k-code (glob)
Skipping edenscm/mercurial/statprof.py it has no-che?k-code (glob)
check-code: always report when a file is skipped by "no-check-code" Skipping an entire file generally from checking is an important event, so report it always. Do not tell the check name because skipping does not depend on it. Directly skip the entire file instead of checking more patterns and skip again. The pragma no-check-code was introduced by accident in the past. (Fixed in bc3ff9741549 and aa06d5c0d698.) This now is prevented because the files to skip have to be listed in the test output of test-check-code-hg.t.
2014-01-08 01:29:15 +04:00
Skipping i18n/polib.py it has no-che?k-code (glob)
clib: move fb-hgext/clib/ to lib Summary: cdatapack depends on clib, so let's move it to lib/ outside of fb-hgext. None of the consumers of these files were changed. They will be changed as they are moved into the main part of the repo. Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48 Reviewers: mitrandir, #mercurial Reviewed By: mitrandir Differential Revision: https://phabricator.intern.facebook.com/D6677197 Signature: 6677197:1515447873:399fb3e7beb5cc1ad8db18f42b359ffbfbeb21f2
2018-01-09 02:08:18 +03:00
Skipping lib/clib/buffer.c it has no-che?k-code (glob)
Skipping lib/clib/buffer.h it has no-che?k-code (glob)
Skipping lib/clib/convert.h it has no-che?k-code (glob)
Skipping lib/clib/null_test.c it has no-che?k-code (glob)
hg: fix test-checks broken in windows treemanifest stack Reviewed By: quark-zju Differential Revision: D7560133 fbshipit-source-id: 98b016d0911aaecc1058263c134a5e4ecd0be9e5
2018-04-10 11:06:47 +03:00
Skipping lib/clib/portability/dirent.h it has no-che?k-code (glob)
clib: move fb-hgext/clib/ to lib Summary: cdatapack depends on clib, so let's move it to lib/ outside of fb-hgext. None of the consumers of these files were changed. They will be changed as they are moved into the main part of the repo. Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48 Reviewers: mitrandir, #mercurial Reviewed By: mitrandir Differential Revision: https://phabricator.intern.facebook.com/D6677197 Signature: 6677197:1515447873:399fb3e7beb5cc1ad8db18f42b359ffbfbeb21f2
2018-01-09 02:08:18 +03:00
Skipping lib/clib/portability/inet.h it has no-che?k-code (glob)
hg: start using imported mman-win32 in the portability headers Summary: Let's create a new portability header, which can be used on both Windows and Posix. Reviewed By: quark-zju Differential Revision: D6970928 fbshipit-source-id: a3970c50260f52bfc0a9420a4ff11d93ace304b0
2018-02-13 18:47:38 +03:00
Skipping lib/clib/portability/mman.h it has no-che?k-code (glob)
clib: move fb-hgext/clib/ to lib Summary: cdatapack depends on clib, so let's move it to lib/ outside of fb-hgext. None of the consumers of these files were changed. They will be changed as they are moved into the main part of the repo. Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48 Reviewers: mitrandir, #mercurial Reviewed By: mitrandir Differential Revision: https://phabricator.intern.facebook.com/D6677197 Signature: 6677197:1515447873:399fb3e7beb5cc1ad8db18f42b359ffbfbeb21f2
2018-01-09 02:08:18 +03:00
Skipping lib/clib/portability/portability.h it has no-che?k-code (glob)
Skipping lib/clib/portability/unistd.h it has no-che?k-code (glob)
Skipping lib/clib/sha1.h it has no-che?k-code (glob)
tests: add tests for poorly behaving HTTP server I've spent several hours over the past few weeks investigating networking failures involving hg.mozilla.org. As part of this, it has become clear that the Mercurial client's error handling when it encounters network failures is far from robust. To prove this is true, I've devised a battery of tests simulating various network failures, notably premature connection closes. To achieve this, I've implemented an extension that monkeypatches the built-in HTTP server and hooks in at the socket level and allows various events to occur based on config options. For example, you can refuse to accept() a client socket or you can close() the socket after N bytes have been sent or received. The latter effectively simulates an unexpected connection drop (and these occur all the time in the real world). The new test file launches servers exhibiting various "bad" behaviors and points a client at them. As the many TODO comments in the test call attention to, Mercurial often displays unhelpful errors when network-related failures occur. This makes it difficult for users to understand what's going on and difficult for server administrators to pinpoint root causes without packet tracing. Upcoming patches will attempt to fix these error handling deficiencies.
2017-04-14 08:19:28 +03:00
Skipping tests/badserverext.py it has no-che?k-code (glob)
hgsubversion: accept some test-check line reshuffles Summary: Since we moved some files, these failures changed. Depends on D6719894 Test Plan: - ./run-tests, see passing Reviewers: #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6719911
2018-01-17 14:23:44 +03:00
Skipping tests/comprehensive/test-hgsubversion-custom-layout.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-obsstore-on.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-rebuildmeta.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-sqlite-revmap.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-stupid-pull.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-updatemeta.py it has no-che?k-code (glob)
Skipping tests/comprehensive/test-hgsubversion-verify-and-startrev.py it has no-che?k-code (glob)
fb-hgext: temporarily accept failures for test-check-code.t Summary: This is a temporary commit, meant to be fixed later. Test Plan: - test passes now Reviewers: #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6675412
2018-01-09 15:45:57 +03:00
Skipping tests/conduithttp.py it has no-che?k-code (glob)
hgsubversion: accept some test-check line reshuffles Summary: Since we moved some files, these failures changed. Depends on D6719894 Test Plan: - ./run-tests, see passing Reviewers: #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6719911
2018-01-17 14:23:44 +03:00
Skipping tests/fixtures/rsvn.py it has no-che?k-code (glob)
remotefilelog: move to hgext/ Summary: Moves the remotefilelog extension into hgext/ and it's tests into tests/. I did not fix up all the check-module errors, since it's a ton of work for very little impact at this point. Test Plan: make local && ./run-tests.py Reviewers: #mercurial Differential Revision: https://phabricator.intern.facebook.com/D6680030
2018-01-09 05:58:08 +03:00
Skipping tests/test-fb-hgext-remotefilelog-bad-configs.t it has no-che?k-code (glob)
hgsql: update check-code test output Summary: Update check-code test output to reflect new locations of hgsql. Test Plan: Run tests. Reviewers: rmcelroy, #sourcecontrol Reviewed By: rmcelroy Differential Revision: https://phabricator.intern.facebook.com/D6661008 Tasks: T24908724 Signature: 6661008:1515089234:3c082103ebe6ec083b02281777c1f1d159528c27
2018-01-04 21:54:02 +03:00
Skipping tests/test-hgsql-encoding.t it has no-che?k-code (glob)
Skipping tests/test-hgsql-race-conditions.t it has no-che?k-code (glob)
hgsubversion: accept some test-check line reshuffles Summary: Since we moved some files, these failures changed. Depends on D6719894 Test Plan: - ./run-tests, see passing Reviewers: #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6719911
2018-01-17 14:23:44 +03:00
Skipping tests/test-hgsubversion-externals.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-fetch-command-regexes.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-fetch-command.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-fetch-exec.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-fetch-mappings.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-fetch-symlinks.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-push-command.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-push-dirs.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-push-renames.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-single-dir-clone.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-single-dir-push.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-svn-pre-commit-hooks.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-svnwrap.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-tags.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-template-keywords.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-urls.py it has no-che?k-code (glob)
Skipping tests/test-hgsubversion-utility-commands.py it has no-che?k-code (glob)
rust: reinvent Python's threading.Condition Summary: Python 2's `threading.Condition` and `threading.RLock` implementation are in pure Python. Part of `RLock.acquire` looks like (simplified): def acquire(self, blocking=1): me = _get_ident() if self.__owner == me: self.__count = self.__count + 1 return 1 rc = self.__block.acquire(blocking) ########## Here ######### if rc: self.__owner = me self.__count = 1 return rc If an interruption (ex. SIGTERM) happens at "HERE". The lock would be in an inconsistent state. And if some `finally` block, or `__exit__` in a context manager tries to release the lock, it could deadlock. Similar problems also apply to `release`, `_acquire_restore`, and `_release_save`. Basically, `self.__owner`, `self.__count` and `self.__block` (i.e. the real lock) cannot be guaranteed in a consistent state in pure Python world, because interruption can happen before any Python bytecode instruction (but not inside a single Python bytecode instruction). Therefore the interruption-safe implementation cannot be done in pure Python. Use Rust to rescue. The added test `streetest-condint.py` has a high chance to reproduce the deadlock issue with Python 2. Python 3 has a native RLock implementation, which makes things better. The "Condition" implementation is not native and I haven't checked whether it is sound or not. Unfortunately, as part of testing, I hit https://bugs.python.org/issue29988 and confirmed from the Rust world. That is, `__exit__` is not guarnateed called (!!) That means native implementations still have a chance to be wrong, and there is no easy way to fix it. `streetest-condint.py` was then updated to expose the issue more easily. The implementation is better than Python 2 stdlib, though. Reviewed By: markbt Differential Revision: D10517920 fbshipit-source-id: 394c9050c512ce2a0f9743c28ccfafe0f560141a
2018-10-25 23:07:11 +03:00
Skipping tests/test-rustthreading.py it has no-che?k-code (glob)
hgsubversion: accept some test-check line reshuffles Summary: Since we moved some files, these failures changed. Depends on D6719894 Test Plan: - ./run-tests, see passing Reviewers: #sourcecontrol Differential Revision: https://phabricator.intern.facebook.com/D6719911
2018-01-17 14:23:44 +03:00
Skipping tests/test_hgsubversion_util.py it has no-che?k-code (glob)
debugedenimporthelper get file size Summary: `hg debugedenimporthelper --get-file-size PATH:REV` will print the size of the given file Reviewed By: chadaustin, xavierd Differential Revision: D16009279 fbshipit-source-id: 6edb01dd154a467cdd26c0ced1d4ae82411088f1
2019-06-27 03:05:14 +03:00
edenscm/mercurial/commands/eden.py:408: use foobar, not foo_bar naming --> def cmd_get_file_size(self, request):
hggit: sort git-mapfile and use bisect to do git-getmeta Summary: Previously, git-getmeta would have to scan through the entire git map file, which was extremely expensive. Let's shift this cost to write time by sorting the map file before writing, then using bisect to lookup nodes. A while ago we switch hggit to only serialize the mapfile every 100 commits or so, so the additional time here shouldn't be excessive. Reviewed By: quark-zju Differential Revision: D10470293 fbshipit-source-id: 47e23d251adde5456e7b593bfcc5976259a497f2
2018-10-20 01:39:13 +03:00
tests/test-revset.t:*: warning: ^ must be quoted --> > . + (glob)
tests: add test that @commands in debugcommands.py are sorted I felt like inline Python in test-check-code.t was the most appropriate place for this, as other linters in contrib/ seem to be source file agnostic. The test currently fails.
2016-11-25 20:55:05 +03:00
@commands in debugcommands.py should be in alphabetical order.
>>> import re
>>> commands = []
codemod: move Python packages to edenscm Summary: Move top-level Python packages `mercurial`, `hgext` and `hgdemandimport` to a new top-level package `edenscm`. This allows the Python packages provided by the upstream Mercurial to be installed side-by-side. To maintain compatibility, `edenscm/` gets added to `sys.path` in `mercurial/__init__.py`. Reviewed By: phillco, ikostia Differential Revision: D13853115 fbshipit-source-id: b296b0673dc54c61ef6a591ebc687057ff53b22e
2019-01-29 05:29:48 +03:00
>>> with open('edenscm/mercurial/commands/debug.py', 'rb') as fh:
tests: add test that @commands in debugcommands.py are sorted I felt like inline Python in test-check-code.t was the most appropriate place for this, as other linters in contrib/ seem to be source file agnostic. The test currently fails.
2016-11-25 20:55:05 +03:00
... for line in fh:
... m = re.match("^@command\('([a-z]+)", line)
... if m:
... commands.append(m.group(1))
>>> scommands = list(sorted(commands))
>>> for i, command in enumerate(scommands):
... if command != commands[i]:
... print('commands in debugcommands.py not sorted; first differing '
... 'command is %s; expected %s' % (commands[i], command))
... break
test-check-code: prevent files being added to the root directory Adding new files in the root directory is probably a mistake, and is usually discouraged [1]. The test catches it to avoid mistakes like [2]. Modify the test if files need to be added in the root. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-July/086442.html [2]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095836.html
2017-03-29 22:14:20 +03:00
Reference in New Issue Copy Permalink