facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-11 17:27:53 +03:00
Code Issues Projects Releases Wiki Activity
abe72eab0a
sapling/tests/test-dispatch-debug-prefix-t.py

27 lines
599 B
Python
Raw Normal View History

tests: add a test showing "hg d" regression Summary: `hg d` should not match debug commands. Reviewed By: kulshrax Differential Revision: D16557267 fbshipit-source-id: d7936ab530fce4e302b7e410f8abbe619898e941
2019-07-30 05:30:30 +03:00
# Copyright (c) Facebook, Inc. and its affiliates.
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from testutil.dott import feature, sh, testtmp # noqa: F401
sh % "newrepo"
cliparser: special handle debug commands Summary: When doing command name prefix match, if there are a unique match for non-debug commands, use it. This solves `hg d` regression. Note: we cannot simply use `starts_with("debug")` to test debug commands. That is because debug commands can have aliases (ex. `debug|dbsh` as the command name definition, and `dbsh` is also a debug command that does not starts with `debug`). Therefore it gets a bit complex. Reviewed By: kulshrax Differential Revision: D16557266 fbshipit-source-id: 42d814940c9217d9e554bd0fe2769a53e0ee467f
2019-07-30 05:30:30 +03:00
sh % "hg d" == ""
commands: assign 'd' alias to 'diff' Summary: Git does not have command name prefix matching. We now use `commands.names` config options as a hint to avoid going to the Python land for command prefix matching. It works but is not "correct". If we drop the prefix matching feature, then the problems are gone - fast paths won't need prefix matching aka. the command name list, and slow path (ex. wrong command) can afford loading Python for all command names. `hg d` is the single most used prefix matching command. Assign an explicit alias to it to avoid regression if we do drop prefix matching (or, make that more expensive than resolving commands direcly). Reviewed By: sfilipco Differential Revision: D16733274 fbshipit-source-id: 8904288b8a1ddf1fc6e6ec54ffaa36e503ebdb77
2019-08-20 05:24:40 +03:00
sh % "hg di --config alias.did=root" == r"""
hg: command 'di' is ambiguous:
testutil/dott: use bindings.commands to run commands Summary: This makes it possible to execute Rust commands from the Python tests. Test changes: - test-command-template-t: non-utf8 command-line arguments are rejected at the function signature level - test-dispatch-debug-prefix-t: the error is now printed by Rust code, which uses spaces instead of tabs. - test-root-t: the test now passes Reviewed By: xavierd Differential Revision: D16866459 fbshipit-source-id: 386931c5497b04c53efc08fbb4de708812517ad9
2019-08-29 05:22:46 +03:00
did
diff
cliparser: special handle debug commands Summary: When doing command name prefix match, if there are a unique match for non-debug commands, use it. This solves `hg d` regression. Note: we cannot simply use `starts_with("debug")` to test debug commands. That is because debug commands can have aliases (ex. `debug|dbsh` as the command name definition, and `dbsh` is also a debug command that does not starts with `debug`). Therefore it gets a bit complex. Reviewed By: kulshrax Differential Revision: D16557266 fbshipit-source-id: 42d814940c9217d9e554bd0fe2769a53e0ee467f
2019-07-30 05:30:30 +03:00
[255]"""
sh % "hg debugf" == r"""
hg: command 'debugf' is ambiguous:
tests: add a test showing "hg d" regression Summary: `hg d` should not match debug commands. Reviewed By: kulshrax Differential Revision: D16557267 fbshipit-source-id: d7936ab530fce4e302b7e410f8abbe619898e941
2019-07-30 05:30:30 +03:00
debugfilerevision
debugfileset
debugformat
debugfsinfo
[255]"""
Reference in New Issue Copy Permalink