facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 08:47:12 +03:00
Code Issues Projects Releases Wiki Activity
aeeba5db75
sapling/tests/test-check-code.t

120 lines
6.3 KiB
Perl
Raw Normal View History

tests: change some #ifs to #requires
2014-08-06 20:53:08 +04:00
#require test-repo
test-check-code-hg: use test-repo check
2014-05-05 22:42:58 +04:00
tests: silence test-repo obsolete warning refactoring test-check-commit.t HGRCPATH bits as helpers-testrepo.sh
2016-05-11 07:49:27 +03:00
$ . "$TESTDIR/helpers-testrepo.sh"
tests: convert test-check-code-hg.py to .t
2011-11-23 05:50:58 +04:00
$ check_code="$TESTDIR"/../contrib/check-code.py
$ cd "$TESTDIR"/..
tests: check-code all python files in one run
2013-07-06 23:47:56 +04:00
New errors are not allowed. Warnings are strongly discouraged.
check-code: always report when a file is skipped by "no-check-code" Skipping an entire file generally from checking is an important event, so report it always. Do not tell the check name because skipping does not depend on it. Directly skip the entire file instead of checking more patterns and skip again. The pragma no-check-code was introduced by accident in the past. (Fixed in bc3ff9741549 and aa06d5c0d698.) This now is prevented because the files to skip have to be listed in the test output of test-check-code-hg.t.
2014-01-08 01:29:15 +04:00
(The writing "no-che?k-code" is for not skipping this file when checking.)
tests: check-code all python files in one run
2013-07-06 23:47:56 +04:00
tests: disable lints on mercurial/thirdparty In the next patch, this directory will be used to vendor in some third-party code. Differential Revision: https://phab.mercurial-scm.org/D866
2017-10-01 13:24:19 +03:00
$ testrepohg locate \
> -X contrib/python-zstandard \
> -X hgext/fsmonitor/pywatchman \
> -X mercurial/thirdparty \
sha1: add sha1detectcoll library to setup.py Summary: cdatapack depends on sha1detectcoll, so let's add the library to setup.py before we add cdatapack. Test Plan: hg purge --all && make local && cd tests/ && ./run-tests.py -S -j 48 Verified sha1dc was in the build output and the tests passed. Reviewers: quark, #mercurial Reviewed By: quark Differential Revision: https://phabricator.intern.facebook.com/D6676405 Signature: 6676405:1515444508:2da65c6c3a18267a1d3c151c8e9acf60b674ffc2
2018-01-08 23:54:57 +03:00
> -X lib/third-party \
fb-hgext: ignore test-check-code failures
2018-01-03 20:46:16 +03:00
> -X fb-hgext \
hg-git: exclude hg-git from checks
2018-01-03 21:03:16 +03:00
> -X hg-git \
tests: disable lints on mercurial/thirdparty In the next patch, this directory will be used to vendor in some third-party code. Differential Revision: https://phab.mercurial-scm.org/D866
2017-10-01 13:24:19 +03:00
> | sed 's-\\-/-g' | "$check_code" --warnings --per-file=0 - || false
hgsql: update check-code test output Summary: Update check-code test output to reflect new locations of hgsql. Test Plan: Run tests. Reviewers: rmcelroy, #sourcecontrol Reviewed By: rmcelroy Differential Revision: https://phabricator.intern.facebook.com/D6661008 Tasks: T24908724 Signature: 6661008:1515089234:3c082103ebe6ec083b02281777c1f1d159528c27
2018-01-04 21:54:02 +03:00
Skipping hgext/hgsql.py it has no-che?k-code (glob)
hgsubversion: changes to pass check-code
2018-01-03 22:51:20 +03:00
Skipping hgsubversion/hgsubversion/__init__.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/compathacks.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/editor.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/hooks/updatemeta.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/layouts/base.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/layouts/custom.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/layouts/standard.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/maps.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/pushmod.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/stupid.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svncommands.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnexternals.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnmeta.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnrepo.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnwrap/__init__.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnwrap/common.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnwrap/subvertpy_wrapper.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/svnwrap/svn_swig_wrapper.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/util.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/verify.py it has no-che?k-code (glob)
Skipping hgsubversion/hgsubversion/wrappers.py it has no-che?k-code (glob)
Skipping hgsubversion/setup.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_custom_layout.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_obsstore_on.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_rebuildmeta.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_sqlite_revmap.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_stupid_pull.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_updatemeta.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/comprehensive/test_verify_and_startrev.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/fixtures/rsvn.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/run.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_externals.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_branches.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_command.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_command_regexes.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_exec.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_mappings.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_fetch_symlinks.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_push_command.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_push_dirs.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_push_renames.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_single_dir_clone.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_single_dir_push.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_svn_pre_commit_hooks.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_svnwrap.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_tags.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_template_keywords.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_urls.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_util.py it has no-che?k-code (glob)
Skipping hgsubversion/tests/test_utility_commands.py it has no-che?k-code (glob)
check-code: always report when a file is skipped by "no-check-code" Skipping an entire file generally from checking is an important event, so report it always. Do not tell the check name because skipping does not depend on it. Directly skip the entire file instead of checking more patterns and skip again. The pragma no-check-code was introduced by accident in the past. (Fixed in bc3ff9741549 and aa06d5c0d698.) This now is prevented because the files to skip have to be listed in the test output of test-check-code-hg.t.
2014-01-08 01:29:15 +04:00
Skipping i18n/polib.py it has no-che?k-code (glob)
clib: move fb-hgext/clib/ to lib Summary: cdatapack depends on clib, so let's move it to lib/ outside of fb-hgext. None of the consumers of these files were changed. They will be changed as they are moved into the main part of the repo. Test Plan: hg purge --all && make local && cd tests && ./run-tests.py -S -j 48 Reviewers: mitrandir, #mercurial Reviewed By: mitrandir Differential Revision: https://phabricator.intern.facebook.com/D6677197 Signature: 6677197:1515447873:399fb3e7beb5cc1ad8db18f42b359ffbfbeb21f2
2018-01-09 02:08:18 +03:00
Skipping lib/clib/buffer.c it has no-che?k-code (glob)
Skipping lib/clib/buffer.h it has no-che?k-code (glob)
Skipping lib/clib/convert.h it has no-che?k-code (glob)
Skipping lib/clib/null_test.c it has no-che?k-code (glob)
Skipping lib/clib/portability/inet.h it has no-che?k-code (glob)
Skipping lib/clib/portability/portability.h it has no-che?k-code (glob)
Skipping lib/clib/portability/unistd.h it has no-che?k-code (glob)
Skipping lib/clib/sha1.h it has no-che?k-code (glob)
check-code: always report when a file is skipped by "no-check-code" Skipping an entire file generally from checking is an important event, so report it always. Do not tell the check name because skipping does not depend on it. Directly skip the entire file instead of checking more patterns and skip again. The pragma no-check-code was introduced by accident in the past. (Fixed in bc3ff9741549 and aa06d5c0d698.) This now is prevented because the files to skip have to be listed in the test output of test-check-code-hg.t.
2014-01-08 01:29:15 +04:00
Skipping mercurial/httpclient/__init__.py it has no-che?k-code (glob)
Skipping mercurial/httpclient/_readers.py it has no-che?k-code (glob)
statprof: vendor statprof.py Vendored from https://bitbucket.org/facebook/hg-experimental changeset 73f9db47ae5a1a9fa29a98dfe92d557ad51234c3 without modification. This introduces a number of code style violations. The file already has the magic words to skip test-check-code.t. I'll make additional changes to clean up the test-check-py3-compat.t warnings and to change some behavior in the code that isn't suitable for general use. test-check-commit.t also complains about numerous things. But there's nothing we can do if we're importing as-is.
2016-11-02 04:54:03 +03:00
Skipping mercurial/statprof.py it has no-che?k-code (glob)
tests: add tests for poorly behaving HTTP server I've spent several hours over the past few weeks investigating networking failures involving hg.mozilla.org. As part of this, it has become clear that the Mercurial client's error handling when it encounters network failures is far from robust. To prove this is true, I've devised a battery of tests simulating various network failures, notably premature connection closes. To achieve this, I've implemented an extension that monkeypatches the built-in HTTP server and hooks in at the socket level and allows various events to occur based on config options. For example, you can refuse to accept() a client socket or you can close() the socket after N bytes have been sent or received. The latter effectively simulates an unexpected connection drop (and these occur all the time in the real world). The new test file launches servers exhibiting various "bad" behaviors and points a client at them. As the many TODO comments in the test call attention to, Mercurial often displays unhelpful errors when network-related failures occur. This makes it difficult for users to understand what's going on and difficult for server administrators to pinpoint root causes without packet tracing. Upcoming patches will attempt to fix these error handling deficiencies.
2017-04-14 08:19:28 +03:00
Skipping tests/badserverext.py it has no-che?k-code (glob)
hgsql: update check-code test output Summary: Update check-code test output to reflect new locations of hgsql. Test Plan: Run tests. Reviewers: rmcelroy, #sourcecontrol Reviewed By: rmcelroy Differential Revision: https://phabricator.intern.facebook.com/D6661008 Tasks: T24908724 Signature: 6661008:1515089234:3c082103ebe6ec083b02281777c1f1d159528c27
2018-01-04 21:54:02 +03:00
Skipping tests/test-hgsql-encoding.t it has no-che?k-code (glob)
Skipping tests/test-hgsql-race-conditions.t it has no-che?k-code (glob)
tests: add test that @commands in debugcommands.py are sorted I felt like inline Python in test-check-code.t was the most appropriate place for this, as other linters in contrib/ seem to be source file agnostic. The test currently fails.
2016-11-25 20:55:05 +03:00
@commands in debugcommands.py should be in alphabetical order.
>>> import re
>>> commands = []
>>> with open('mercurial/debugcommands.py', 'rb') as fh:
... for line in fh:
... m = re.match("^@command\('([a-z]+)", line)
... if m:
... commands.append(m.group(1))
>>> scommands = list(sorted(commands))
>>> for i, command in enumerate(scommands):
... if command != commands[i]:
... print('commands in debugcommands.py not sorted; first differing '
... 'command is %s; expected %s' % (commands[i], command))
... break
test-check-code: prevent files being added to the root directory Adding new files in the root directory is probably a mistake, and is usually discouraged [1]. The test catches it to avoid mistakes like [2]. Modify the test if files need to be added in the root. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-July/086442.html [2]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095836.html
2017-03-29 22:14:20 +03:00
Prevent adding new files in the root directory accidentally.
tests: alias syshg and syshgenv so they can be switched conditionally
2017-07-02 07:14:20 +03:00
$ testrepohg files 'glob:*'
phabricator: include the suggested arc config in the repo Test Plan: I uploaded this revision with `arc diff` Differential Revision: https://phab.mercurial-scm.org/D171
2017-07-21 17:22:08 +03:00
.arcconfig
clang-format: configuration for the clang-format source formatter Differential Revision: https://phab.mercurial-scm.org/D1129
2015-01-25 01:04:25 +03:00
.clang-format
test-check-code: prevent files being added to the root directory Adding new files in the root directory is probably a mistake, and is usually discouraged [1]. The test catches it to avoid mistakes like [2]. Modify the test if files need to be added in the root. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-July/086442.html [2]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095836.html
2017-03-29 22:14:20 +03:00
.editorconfig
.hgignore
.hgsigs
.hgtags
hgweb: add .jshintrc with some basic rules This file is picked up automatically by jshint, so no extra changes required in test-check-jshint.t.
2017-11-22 17:18:06 +03:00
.jshintrc
test-check-code: prevent files being added to the root directory Adding new files in the root directory is probably a mistake, and is usually discouraged [1]. The test catches it to avoid mistakes like [2]. Modify the test if files need to be added in the root. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-July/086442.html [2]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095836.html
2017-03-29 22:14:20 +03:00
CONTRIBUTING
CONTRIBUTORS
COPYING
Makefile
doc: rename README to README.rst Many hosting services consider README without extension as plain text. By using .rst extension, we bring better formatting on many services (e.g. bitbucket).
2017-09-26 09:37:17 +03:00
README.rst
test-check-code: prevent files being added to the root directory Adding new files in the root directory is probably a mistake, and is usually discouraged [1]. The test catches it to avoid mistakes like [2]. Modify the test if files need to be added in the root. [1]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-July/086442.html [2]: https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-March/095836.html
2017-03-29 22:14:20 +03:00
hg
hgeditor
hgweb.cgi
setup.py
Reference in New Issue Copy Permalink