From 0766f36b2996f67105951adbf88505302e58d65a Mon Sep 17 00:00:00 2001 From: Saurabh Singh Date: Thu, 18 Jul 2019 12:19:29 -0700 Subject: [PATCH] hgsubversion: refactor method for svnrev template keyword to easy wrapping Summary: This commit is just a simple refactor of the method for the resolving the `svnrev` template keyword. In particular, we split the method so that it can be easily wrapped by other extensions like globalrevs in D16361887. Reviewed By: quark-zju Differential Revision: D16361888 fbshipit-source-id: 9f20fb33afd2b286c4f30571fa257b8284f2bb54 --- edenscm/hgext/hgsubversion/__init__.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/edenscm/hgext/hgsubversion/__init__.py b/edenscm/hgext/hgsubversion/__init__.py index 2256b34e8a..4f6d7b4212 100644 --- a/edenscm/hgext/hgsubversion/__init__.py +++ b/edenscm/hgext/hgsubversion/__init__.py @@ -432,9 +432,18 @@ configitem("hgsubversion", "rewritesvncommitwithhghash", default=False) @templatekeyword("svnrev") -def svnrevkw(**args): +def svnrevkw(repo, ctx, **kwargs): """:svnrev: String. Converted subversion revision number.""" - convertinfo = util.getsvnrev(args["ctx"], "") + return _svnrevkw(repo, ctx, **kwargs) + + +def _svnrevkw(repo, ctx, **kwargs): + """:svnrev: String. Converted subversion revision number. + + Isolating this method allows easy wrapping by other extensions like + globalrevs. + """ + convertinfo = util.getsvnrev(ctx, "") if not convertinfo or not convertinfo.startswith("svn:"): return ""