facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-11 01:07:15 +03:00
Code Issues Projects Releases Wiki Activity

mononoke: resolve CHashMap::with_capacity TODO in skiplist deserialization

Browse Source 
Summary: Resolve TODO in skiplist deserialization, as we now point at a CHashMap version with fixes to with_capacity

Reviewed By: krallin

Differential Revision: D18207126

fbshipit-source-id: 71f2a7c0897ed3d345553ce481853f7be1ed95df
This commit is contained in:
Alex Hornby 2019-11-03 23:23:21 -08:00 committed by Facebook Github Bot
parent 7c9d47937c
commit 09a02b13e5
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
reachabilityindex/skiplist/src/lib.rs
View File

@ -160,13 +160,7 @@ pub fn fetch_skiplist_index(
pub fn deserialize_skiplist_index(logger: Logger, bytes: Bytes) -> Result<SkiplistIndex> {
let map: HashMap<_, skiplist_thrift::SkiplistNodeType> = compact_protocol::deserialize(&bytes)?;
// chashmap 2.2.2 load factor len/buckets before expanding in CHashMap::insert is 85/100.
// Unfortunately CHashMap::with_capacity ignores load factor and adds in a factor of 4
// This takes into account load factor and removes the factor of 4 so we can preallocate to
// right size and that insert won't reallocate. CHashMap::shrink_to_fit has same 4x issue.
// TODO - try to fix upstream
let cmap: CHashMap<ChangesetId, SkiplistNodeType> =
CHashMap::with_capacity((map.len() * 100 / 85 + 4) / 4);
let cmap: CHashMap<ChangesetId, SkiplistNodeType> = CHashMap::with_capacity(map.len());
let mut pnodecount = 0;
let mut snodecount = 0;
let mut maxsedgelen = 0;