facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-08 07:49:11 +03:00
Code Issues Projects Releases Wiki Activity

Minor refactor replacing if with switch and a loop control comparison.

Browse Source 
Summary: Minor refactor replacing if with switch and a loop control comparison.

Reviewed By: wez

Differential Revision: D6730849

fbshipit-source-id: 69ac7be9fae3be6274b56dd2baea433ed2437f7c
This commit is contained in:
Sergey Zhupanov 2018-01-16 18:24:29 -08:00 committed by Facebook Github Bot
parent 0b4fea5374
commit 09f8707b81
1 changed files with 26 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
eden/fs/fuse/privhelper/PrivHelperServer.cpp
View File

@ -308,24 +308,33 @@ void PrivHelperServer::messageLoop() {
while (1) {
conn_.recvMsg(&msg, nullptr);
auto msgType = msg.msgType;
if (msgType == PrivHelperConn::REQ_MOUNT_FUSE) {
processMountMsg(&msg);
} else if (msgType == PrivHelperConn::REQ_MOUNT_BIND) {
processBindMountMsg(&msg);
} else if (msgType == PrivHelperConn::REQ_UNMOUNT_FUSE) {
processUnmountMsg(&msg);
} else if (msgType == PrivHelperConn::REQ_TAKEOVER_SHUTDOWN) {
processTakeoverShutdownMsg(&msg);
} else if (msgType == PrivHelperConn::REQ_TAKEOVER_STARTUP) {
processTakeoverStartupMsg(&msg);
} else {
// This shouldn't ever happen unless we have a bug.
// Crash if it does occur. (We could send back an error message and
// continue, but it seems better to fail hard to make sure this bug gets
// noticed and debugged.)
XLOG(FATAL) << "unsupported privhelper message type: " << msg.msgType;
switch (msg.msgType) {
case PrivHelperConn::REQ_MOUNT_FUSE:
processMountMsg(&msg);
continue;
case PrivHelperConn::REQ_MOUNT_BIND:
processBindMountMsg(&msg);
continue;
case PrivHelperConn::REQ_UNMOUNT_FUSE:
processUnmountMsg(&msg);
continue;
case PrivHelperConn::REQ_TAKEOVER_SHUTDOWN:
processTakeoverShutdownMsg(&msg);
continue;
case PrivHelperConn::REQ_TAKEOVER_STARTUP:
processTakeoverStartupMsg(&msg);
continue;
case PrivHelperConn::MSG_TYPE_NONE:
case PrivHelperConn::RESP_ERROR:
case PrivHelperConn::RESP_EMPTY:
break;
}
// This shouldn't ever happen unless we have a bug.
// Crash if it does occur. (We could send back an error message and
// continue, but it seems better to fail hard to make sure this bug gets
// noticed and debugged.)
XLOG(FATAL) << "unsupported privhelper message type: " << msg.msgType;
}
}