facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 23:07:18 +03:00
Code Issues Projects Releases Wiki Activity

config: remove overlay.enable_tree_overlay

Browse Source 
Summary:
This config has been enabled for many months now, let's simply assume it is set
to true on Windows.

Reviewed By: genevievehelsel

Differential Revision: D32192585

fbshipit-source-id: 76829a031f859594a5139dd09a6479cabeda2089
This commit is contained in:
Xavier Deguillard 2021-11-10 10:00:51 -08:00 committed by Facebook GitHub Bot
parent 349408805a
commit 0a820ed7d0
3 changed files with 2 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eden/fs/cli/main.py
View File

@ -815,13 +815,9 @@ class CloneCmd(Subcmd):
def _get_enable_tree_overlay(
self, instance: EdenInstance, overlay_type: Optional[str]
) -> bool:
if sys.platform != "win32":
# Tree overlay does not support non-Windows platform yet
return False
if overlay_type is None:
# If no flag is specified from the user, follow system configuration
return instance.get_config_bool("overlay.enable_tree_overlay", False)
# Tree overlay does not support non-Windows platform yet
return sys.platform == "win32"
return overlay_type == "tree"

8
eden/fs/config/EdenConfig.cpp
View File

@ -85,14 +85,6 @@ std::pair<StringPiece, StringPiece> parseKey(StringPiece fullKey) {
EDEN_BUG() << "not a valid section name: " << fullKey;
}
}
// This one slipped in:
if (key != "enable_tree_overlay") {
for (char c : key) {
if (!isConfigChar(c)) {
EDEN_BUG() << "not a valid key name: " << fullKey;
}
}
}
return {section, key};
}

9
eden/fs/config/EdenConfig.h
View File

@ -743,15 +743,6 @@ class EdenConfig : private ConfigSettingManager {
10000,
this};
/**
* Only used in CLI to control if new clones are using TreeOverlay by default.
* Adding here to avoid unknown configuration warning.
*/
ConfigSetting<bool> cliOnlyOverlayEnableTreeOverlay{
"overlay:enable_tree_overlay",
false,
this};
/**
* DANGER: this option will put overlay into memory and skip persisting any
* actual data to disk. This will guarantee to cause EdenFS corruption after