facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 16:31:02 +03:00
Code Issues Projects Releases Wiki Activity

commitcloud: avoid inefficient remote commit hash lookups

Browse Source 
Summary:
Running `hasnode` in a loop is inefficient with lazy changelog.
Update it so it does batch filtering and does not ask remote service.

With the change, BackupState.heads will only contain locally known heads.
So the extra filtering is removed.

Reviewed By: andll

Differential Revision: D29404056

fbshipit-source-id: 327bd4c292ad75fd14a47587482440b6ece1d2d5
This commit is contained in:
Jun Wu 2021-06-25 14:33:55 -07:00 committed by Facebook GitHub Bot
parent e6ea02372c
commit 0a8dd803f8
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
eden/scm/edenscm/hgext/commitcloud/backupstate.py
View File

@ -47,7 +47,6 @@ class BackupState(object):
if filename.startswith(cls.prefix)
]
heads = set()
hasnode = repo.changelog.hasnode
threshold = time.time() - cls.oldbackupcache
# union the recent cache files
for filename in files:
@ -60,7 +59,7 @@ class BackupState(object):
if len(lines) < 2 or lines[0].strip() != FORMAT_VERSION:
continue
heads = heads.union([nodemod.bin(head.strip()) for head in lines[2:]])
heads = {h for h in heads if hasnode(h)}
heads = set(repo.changelog.filternodes(list(heads), local=True))
# return the cached backedup heads in found
if heads:
return heads
@ -94,9 +93,9 @@ class BackupState(object):
)
self.initfromserver()
return
heads = (nodemod.bin(head.strip()) for head in lines[2:])
hasnode = repo.changelog.hasnode
self.heads = {h for h in heads if hasnode(h)}
heads = [nodemod.bin(head.strip()) for head in lines[2:]]
heads = repo.changelog.filternodes(heads, local=True)
self.heads = set(heads)
else:
self.initfromserver()
@ -136,9 +135,7 @@ class BackupState(object):
@util.propertycache
def backedup(self):
unfi = self.repo
hasnode = unfi.changelog.hasnode
heads = [head for head in self.heads if hasnode(head)]
return set(unfi.nodes("not public() & ::%ln", heads))
return set(unfi.nodes("not public() & ::%ln", self.heads))
def _write(self, f):
f.write(encodeutf8("%s\n" % FORMAT_VERSION))