facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-11 01:07:15 +03:00
Code Issues Projects Releases Wiki Activity

blobrepo: move signal_parent_ready before processing the entires

Browse Source 
Summary: Since signal_parent_ready purpose is to ensure that the child Changesets might perform their own checks it is good enough to send signal_parent_ready after all blobs have been written out, but before the parent did it's own checks

Reviewed By: farnz

Differential Revision: D8202108

fbshipit-source-id: 15ac85bd18bcf9ded61363a6380ad05462c189d6
This commit is contained in:
Lukas Piatkowski 2018-05-30 12:01:55 -07:00 committed by Facebook Github Bot
parent b2978095e2
commit 0eb217cdf8
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
blobrepo/src/repo.rs
View File

@ -755,15 +755,20 @@ impl CreateChangeset {
"changeset_uuid" => format!("{}", uuid),
"changeset_id" => format!("{}", cs_id));
// NOTE(luk): an attempt was made in D8187210 to split the
// upload_entries signal into upload_entries and processed_entries
// and to signal_parent_ready after upload_entries, so that one
// doesn't need to wait for the entries to be processed. There were
// no performance gains from that experiment
//
// We deliberately eat this error - this is only so that another
// changeset can start verifying data in the blob store while we
// verify this one
let _ = signal_parent_ready.send((cs_id, manifest_id));
blobcs
.save(blobstore)
.join(entry_processor.finalize(filenodes, cs_id))
.map(move |_| {
// We deliberately eat this error - this is only so that
// another changeset can start uploading to the blob store
// while we complete this one
let _ = signal_parent_ready.send((cs_id, manifest_id));
})
.map(move |_| blobcs)
.boxify()
}