facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 16:57:49 +03:00
Code Issues Projects Releases Wiki Activity

mononoke: Remove hit and miss metrics from CountedBlobstore

Browse Source 
Summary:
CountedBlobstore is a Blobstore that wraps another blobstore in order
to report metrics about it, such as the number of gets or errors. It's commonly
used to wrap a CacheBlob blobstore, which itself is a caching wrapper over an
inner blobstore.

CountedBlobstore exposes metrics that are supposed to track the number of hits
or misses when fetching blobs. However, these metrics don't make sense as the
CountedBlobstore has no view into cache activity. These metrics actually report
the number of requests and the number of missing blobs rather than hits and
misses.

Remove these misleading counters.

Reviewed By: krallin

Differential Revision: D21640923

fbshipit-source-id: 07b9fc9864c70991415c2b84f35d631b702c17d1
This commit is contained in:
Harvey Hunt 2020-05-21 03:17:39 -07:00 committed by Facebook GitHub Bot
parent a5eaa551e8
commit 0ee0131454
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
eden/mononoke/blobstore/src/counted_blobstore.rs
View File

@ -20,15 +20,13 @@ use crate::{Blobstore, BlobstoreBytes, BlobstoreGetData};
define_stats_struct! {
CountedBlobstoreStats("mononoke.blobstore.{}", prefix: String),
get: timeseries(Rate, Sum),
get_miss: timeseries(Rate, Sum),
get_hit: timeseries(Rate, Sum),
get_ok: timeseries(Rate, Sum),
get_err: timeseries(Rate, Sum),
put: timeseries(Rate, Sum),
put_ok: timeseries(Rate, Sum),
put_err: timeseries(Rate, Sum),
is_present: timeseries(Rate, Sum),
is_present_miss: timeseries(Rate, Sum),
is_present_hit: timeseries(Rate, Sum),
is_present_ok: timeseries(Rate, Sum),
is_present_err: timeseries(Rate, Sum),
assert_present: timeseries(Rate, Sum),
assert_present_ok: timeseries(Rate, Sum),
@ -66,8 +64,7 @@ impl<T: Blobstore> Blobstore for CountedBlobstore<T> {
.get(ctx, key)
.then(move |res| {
match res {
Ok(Some(_)) => stats.get_hit.add_value(1),
Ok(None) => stats.get_miss.add_value(1),
Ok(_) => stats.get_ok.add_value(1),
Err(_) => stats.get_err.add_value(1),
}
res
@ -97,8 +94,7 @@ impl<T: Blobstore> Blobstore for CountedBlobstore<T> {
.is_present(ctx, key)
.then(move |res| {
match res {
Ok(true) => stats.is_present_hit.add_value(1),
Ok(false) => stats.is_present_miss.add_value(1),
Ok(_) => stats.is_present_ok.add_value(1),
Err(_) => stats.is_present_err.add_value(1),
}
res