From 1021cd1238662e060be7a7dad6e2282e434bc89b Mon Sep 17 00:00:00 2001 From: Mateusz Kwapich Date: Fri, 30 Oct 2020 13:09:24 -0700 Subject: [PATCH] py3: fix hanging read of SSH subprocesses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Previously, reading from SSH subprocesses did’t return on Python 3. bufsize=0 is default on Python 2, but not Python 3. This is a backport of: https://foss.heptapod.net/mercurial/hg-git/-/commit/0fc8020ebea6d184601d138fa614eb9706a1540e Reviewed By: krallin Differential Revision: D24652418 fbshipit-source-id: 1140c76b6f711bfe1726108bd4fe6948e6ee41a0 --- eden/scm/edenscm/hgext/hggit/_ssh.py | 1 + 1 file changed, 1 insertion(+) diff --git a/eden/scm/edenscm/hgext/hggit/_ssh.py b/eden/scm/edenscm/hgext/hggit/_ssh.py index d25e357087..c20c45c2ee 100644 --- a/eden/scm/edenscm/hgext/hggit/_ssh.py +++ b/eden/scm/edenscm/hgext/hggit/_ssh.py @@ -30,6 +30,7 @@ def generate_ssh_vendor(ui): ui.debug("calling ssh: %s\n" % cmd) proc = subprocess.Popen( util.quotecommand(cmd), + bufsize=0, shell=True, stdin=subprocess.PIPE, stdout=subprocess.PIPE,