facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-12-29 08:02:24 +03:00
Code Issues Projects Releases Wiki Activity

run-tests: silent some errors from run-tests itself

Browse Source 
Summary:
I have seen errors like:

  Traceback (most recent call last):
    File "/usr/lib64/python2.7/threading.py", line 812, in __bootstrap_inner
      self.run()
    File "/usr/lib64/python2.7/threading.py", line 765, in run
      self.__target(*self.__args, **self.__kwargs)
    File "./run-tests.py", line 2636, in job
      del runningtests[test.name]
    File "/usr/lib64/python2.7/collections.py", line 68, in __delitem__
      dict_delitem(self, key)
  KeyError: 'test-empty-t.py'

It's not fatal and is caused by race condition. So let's just ignore it.

Reviewed By: ikostia

Differential Revision: D18538388

fbshipit-source-id: 85e38578bea4c9b27439e6f10abb7619a8bb9238
This commit is contained in:
Jun Wu 2019-11-18 11:38:59 -08:00 committed by Facebook Github Bot
parent b4f7ff744e
commit 13a6237c1d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
eden/scm/tests/run-tests.py
View File

@ -2647,7 +2647,10 @@ class TestSuite(unittest.TestSuite):
done.put(("!", test, "run-test raised an error, see traceback"))
raise
finally:
del runningtests[test.name]
try:
del runningtests[test.name]
except KeyError:
pass
try:
channels[channel] = ""
except IndexError: