facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 16:57:49 +03:00
Code Issues Projects Releases Wiki Activity

svn metacommand: improved argument checking

Browse Source 
We now fail gracefully in case of a missing or invalid argument to
'update', and in case of an unknown subcommand.
This commit is contained in:
Dan Villiom Podlaski Christiansen 2010-11-18 14:03:39 +01:00
parent ee2c3c6bcd
commit 1618736125
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hgsubversion/svncommands.py
View File

@ -302,8 +302,15 @@ def update(ui, args, repo, clean=False, **opts):
"""update to a specified Subversion revision number
"""
assert len(args) == 1
rev = int(args[0])
try:
rev = int(args[0])
except IndexError:
raise error.CommandError('svn',
"no revision number specified for 'update'")
except ValueError:
raise error.Abort("'%s' is not a valid Subversion revision number"
% args[0])
meta = repo.svnmeta()
answers = []
@ -457,6 +464,9 @@ def svn(ui, repo, subcommand, *args, **opts):
candidates.append(c)
if len(candidates) == 1:
subcommand = candidates[0]
elif not candidates:
raise error.CommandError('svn',
"unknown subcommand '%s'" % subcommand)
else:
raise error.AmbiguousCommand(subcommand, candidates)