facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 00:45:18 +03:00
Code Issues Projects Releases Wiki Activity

hgrepo: ensure all git-origin tags are bytes

Browse Source 
If we don't do this we might end up with unicodes being written using
ui, which then breaks in popbuffer in test-encoding.t. This appears to
be an academic concern until we start passing unicode paths to git
repos, which we need to do in order to resolve some other problems. Yay.
This commit is contained in:
Augie Fackler 2015-12-31 18:48:01 -05:00
parent 1c80236266
commit 1695f5ea63
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hggit/hgrepo.py
View File

@ -45,9 +45,15 @@ def generate_repo_subclass(baseclass):
(tags, tagtypes) = super(hgrepo, self)._findtags()
for tag, rev in self.githandler.tags.iteritems():
if isinstance(tag, unicode):
tag = tag.encode('utf-8')
tags[tag] = bin(rev)
tagtypes[tag] = 'git'
for tag, rev in self.githandler.remote_refs.iteritems():
if isinstance(tag, unicode):
tag = tag.encode('utf-8')
tags[tag] = rev
tagtypes[tag] = 'git-remote'
tags.update(self.githandler.remote_refs)
return (tags, tagtypes)