facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-10 00:45:18 +03:00
Code Issues Projects Releases Wiki Activity

segmented_changelog: add jitter to periodic reload

Browse Source 
Summary:
In production, all repos are instantiated roughly the same time so all reload
processes are started roughly the same time. Reload makes a bunch of requests
and could potentially cause load. Jitter spreads out the load of the reload.
Avoiding the load spike will make overall server behavior more predictable.

Reviewed By: krallin

Differential Revision: D27280117

fbshipit-source-id: 0727af2e7f231a5b6c948424022788a8e7071f82
This commit is contained in:
Stefan Filip 2021-03-25 21:10:09 -07:00 committed by Facebook GitHub Bot
parent 4349fa4aed
commit 181a3753f4
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
eden/mononoke/segmented_changelog/src/periodic_reload.rs
View File

@ -13,8 +13,8 @@ use anyhow::Result;
use arc_swap::ArcSwap;
use async_trait::async_trait;
use futures::future::{BoxFuture, FutureExt};
use rand::Rng;
use tokio::sync::Notify;
use tokio::time::Instant;
use futures_ext::future::{spawn_controlled, ControlledHandle};
@ -46,8 +46,12 @@ impl PeriodicReloadSegmentedChangelog {
let my_sc = Arc::clone(&sc);
let my_notify = Arc::clone(&update_notify);
async move {
let start = Instant::now() + period;
let mut interval = tokio::time::interval_at(start, period);
// jitter is here so not all repos try to reload at the same time
// 10% of the period seems good enough
let jitter = rand::thread_rng().gen_range(Duration::from_secs(0), period / 10);
tokio::time::delay_for(period + jitter).await;
let mut interval = tokio::time::interval(period);
loop {
interval.tick().await;
match load_fn().await {