facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 07:17:55 +03:00
Code Issues Projects Releases Wiki Activity

pathencode: don't use alloca() for safety/portability

Browse Source
This commit is contained in:
Matt Mackall 2013-01-19 17:20:39 -06:00
parent e0122c56e3
commit 197aa5594e
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
mercurial/pathencode.c
View File

@ -696,22 +696,22 @@ static int sha1hash(char hash[20], const char *str, Py_ssize_t len)
return 0;
}
#define MAXENCODE 4096 * 3
static PyObject *hashencode(const char *src, Py_ssize_t len)
{
const Py_ssize_t baselen = (len - 5) * 3;
#ifndef _MSC_VER
/* alloca is surprisingly slow, so avoid when possible */
char dired[baselen];
char lowered[baselen];
char auxed[baselen];
#else
char *dired = alloca(baselen);
char *lowered = alloca(baselen);
char *auxed = alloca(baselen);
#endif
Py_ssize_t dirlen, lowerlen, auxlen;
char dired[MAXENCODE];
char lowered[MAXENCODE];
char auxed[MAXENCODE];
Py_ssize_t dirlen, lowerlen, auxlen, baselen;
char sha[20];
baselen = (len - 5) * 3;
if (baselen >= MAXENCODE) {
PyErr_SetString(PyExc_ValueError, "string too long");
return NULL;
}
dirlen = _encodedir(dired, baselen, src, len);
if (sha1hash(sha, dired, dirlen - 1) == -1)
return NULL;