From 20f211acb816919347eee590144c5a0f9447f861 Mon Sep 17 00:00:00 2001 From: Adam Simpkins Date: Wed, 12 Jun 2019 13:57:10 -0700 Subject: [PATCH] remove unused python imports Summary: Remove a number of unused imports detected by the linter. Reviewed By: wez Differential Revision: D15776268 fbshipit-source-id: 221f45d275664d037bbabcac9858b40266b4833e --- eden/cli/config.py | 4 ---- eden/cli/debug.py | 1 - eden/cli/doctor/check_bind_mounts.py | 1 - eden/cli/doctor/check_hg.py | 8 +------- eden/cli/fsck.py | 1 - eden/cli/hg_util.py | 1 - eden/cli/main.py | 3 --- eden/cli/process_finder.py | 4 ---- eden/cli/test/config_test.py | 2 -- eden/integration/clone_test.py | 2 -- eden/integration/fsck/basic_snapshot_tests.py | 2 -- eden/integration/fsck_test.py | 1 - eden/integration/hg/lib/hg_extension_test_base.py | 1 - eden/integration/hg/non_eden_operation_test.py | 1 - eden/integration/lib/overlay.py | 1 - eden/integration/lib/systemd.py | 2 -- eden/integration/lib/testcase.py | 2 +- eden/integration/mount_test.py | 1 - eden/integration/persistence_test.py | 1 - eden/integration/restart_test.py | 2 -- eden/integration/service_log_test.py | 2 -- eden/integration/setattr_test.py | 1 - eden/integration/stale_test.py | 3 +-- make-client.py | 1 - 24 files changed, 3 insertions(+), 45 deletions(-) diff --git a/eden/cli/config.py b/eden/cli/config.py index 3651b2915e..2f450d1e6a 100644 --- a/eden/cli/config.py +++ b/eden/cli/config.py @@ -9,18 +9,14 @@ import binascii import collections -import configparser import datetime import errno import fcntl import json import os import shutil -import signal import stat -import subprocess import tempfile -import time import types import typing from pathlib import Path diff --git a/eden/cli/debug.py b/eden/cli/debug.py index 4f27081303..619571387e 100644 --- a/eden/cli/debug.py +++ b/eden/cli/debug.py @@ -40,7 +40,6 @@ from facebook.eden.overlay.ttypes import OverlayDir from facebook.eden.ttypes import ( DebugGetRawJournalParams, DebugJournalDelta, - FileDelta, JournalPosition, NoValueForKeyError, TimeSpec, diff --git a/eden/cli/doctor/check_bind_mounts.py b/eden/cli/doctor/check_bind_mounts.py index d57bf30495..25fb963a26 100644 --- a/eden/cli/doctor/check_bind_mounts.py +++ b/eden/cli/doctor/check_bind_mounts.py @@ -7,7 +7,6 @@ # LICENSE file in the root directory of this source tree. An additional grant # of patent rights can be found in the PATENTS file in the same directory. -import collections import errno import os import stat diff --git a/eden/cli/doctor/check_hg.py b/eden/cli/doctor/check_hg.py index 3b44e6f4bf..2ff94348ee 100644 --- a/eden/cli/doctor/check_hg.py +++ b/eden/cli/doctor/check_hg.py @@ -9,7 +9,6 @@ import abc import binascii -import errno import os import subprocess from pathlib import Path @@ -19,12 +18,7 @@ import eden.dirstate import facebook.eden.ttypes as eden_ttypes from eden.cli import hg_util from eden.cli.config import EdenCheckout -from eden.cli.doctor.problem import ( - FixableProblem, - Problem, - ProblemTracker, - UnexpectedCheckError, -) +from eden.cli.doctor.problem import FixableProblem, ProblemTracker, UnexpectedCheckError from thrift.Thrift import TApplicationException diff --git a/eden/cli/fsck.py b/eden/cli/fsck.py index 8e5faba7fa..cc1e3d5579 100644 --- a/eden/cli/fsck.py +++ b/eden/cli/fsck.py @@ -7,7 +7,6 @@ # LICENSE file in the root directory of this source tree. An additional grant # of patent rights can be found in the PATENTS file in the same directory. -import binascii import contextlib import enum import logging diff --git a/eden/cli/hg_util.py b/eden/cli/hg_util.py index dfc25cdaf2..c84e2a6982 100644 --- a/eden/cli/hg_util.py +++ b/eden/cli/hg_util.py @@ -16,7 +16,6 @@ from typing import BinaryIO, Dict, Tuple import eden.dirstate -from . import config as config_mod from .config import EdenCheckout diff --git a/eden/cli/main.py b/eden/cli/main.py index b0fc38e4ea..97d3478700 100644 --- a/eden/cli/main.py +++ b/eden/cli/main.py @@ -9,7 +9,6 @@ import argparse import errno -import glob import json import os import signal @@ -36,7 +35,6 @@ from . import ( filesystem, fsck as fsck_mod, mtab, - overlay as overlay_mod, process_finder, rage as rage_mod, stats as stats_mod, @@ -78,7 +76,6 @@ def infer_client_from_cwd(instance: EdenInstance, clientname: str) -> str: def do_version(args: argparse.Namespace) -> int: instance = get_eden_instance(args) print("Installed: %s" % version_mod.get_installed_eden_rpm_version()) - import eden try: rv = version_mod.get_running_eden_version(instance) diff --git a/eden/cli/process_finder.py b/eden/cli/process_finder.py index ee8b69d1d5..3a48a05faa 100644 --- a/eden/cli/process_finder.py +++ b/eden/cli/process_finder.py @@ -9,14 +9,10 @@ import abc import logging import os -import subprocess import sys -import typing from pathlib import Path from typing import Dict, Iterable, List, NamedTuple, Optional -from . import util - ProcessID = int diff --git a/eden/cli/test/config_test.py b/eden/cli/test/config_test.py index b5f3bf6307..195c28aad3 100644 --- a/eden/cli/test/config_test.py +++ b/eden/cli/test/config_test.py @@ -7,13 +7,11 @@ # LICENSE file in the root directory of this source tree. An additional grant # of patent rights can be found in the PATENTS file in the same directory. -import abc import configparser import io import os import unittest from pathlib import Path -from typing import Dict, List, Optional import toml import toml.decoder diff --git a/eden/integration/clone_test.py b/eden/integration/clone_test.py index 4dc23a4d8a..05e810c9ff 100644 --- a/eden/integration/clone_test.py +++ b/eden/integration/clone_test.py @@ -9,7 +9,6 @@ import json import os -import stat import subprocess import sys import typing @@ -18,7 +17,6 @@ from textwrap import dedent from typing import Optional, Sequence, Set import pexpect -from eden.cli import util from eden.integration.lib.hgrepo import HgRepository from .lib import edenclient, testcase diff --git a/eden/integration/fsck/basic_snapshot_tests.py b/eden/integration/fsck/basic_snapshot_tests.py index da542e7acf..e9f9d67230 100644 --- a/eden/integration/fsck/basic_snapshot_tests.py +++ b/eden/integration/fsck/basic_snapshot_tests.py @@ -9,8 +9,6 @@ import abc import binascii -import itertools -import os import stat as stat_mod import struct import typing diff --git a/eden/integration/fsck_test.py b/eden/integration/fsck_test.py index c6bf534725..25fa242bb4 100644 --- a/eden/integration/fsck_test.py +++ b/eden/integration/fsck_test.py @@ -7,7 +7,6 @@ # LICENSE file in the root directory of this source tree. An additional grant # of patent rights can be found in the PATENTS file in the same directory. -import os import pathlib import subprocess import unittest diff --git a/eden/integration/hg/lib/hg_extension_test_base.py b/eden/integration/hg/lib/hg_extension_test_base.py index b1692b2c6d..7466e0dc47 100644 --- a/eden/integration/hg/lib/hg_extension_test_base.py +++ b/eden/integration/hg/lib/hg_extension_test_base.py @@ -14,7 +14,6 @@ import json import logging import os import re -import subprocess import textwrap from textwrap import dedent from typing import Any, Dict, List, Optional, Set, Tuple, Union diff --git a/eden/integration/hg/non_eden_operation_test.py b/eden/integration/hg/non_eden_operation_test.py index cae9ce4dfb..285d520017 100644 --- a/eden/integration/hg/non_eden_operation_test.py +++ b/eden/integration/hg/non_eden_operation_test.py @@ -8,7 +8,6 @@ # of patent rights can be found in the PATENTS file in the same directory. import os -import unittest from eden.integration.hg.lib.hg_extension_test_base import EdenHgTestCase, hg_test from eden.integration.lib import hgrepo diff --git a/eden/integration/lib/overlay.py b/eden/integration/lib/overlay.py index c2e38634e9..f2076d15d1 100644 --- a/eden/integration/lib/overlay.py +++ b/eden/integration/lib/overlay.py @@ -11,7 +11,6 @@ import os import pathlib import stat import tempfile -import typing import eden.integration.lib.edenclient as edenclient diff --git a/eden/integration/lib/systemd.py b/eden/integration/lib/systemd.py index 5288ddfa8a..9cba2cb2aa 100644 --- a/eden/integration/lib/systemd.py +++ b/eden/integration/lib/systemd.py @@ -9,7 +9,6 @@ import abc import contextlib -import errno import logging import os import os.path @@ -18,7 +17,6 @@ import re import subprocess import sys import tempfile -import threading import types import typing diff --git a/eden/integration/lib/testcase.py b/eden/integration/lib/testcase.py index 0483584dd9..ef70d84995 100644 --- a/eden/integration/lib/testcase.py +++ b/eden/integration/lib/testcase.py @@ -36,7 +36,7 @@ from eden.test_support.temporary_directory import TemporaryDirectoryMixin from eden.thrift import EdenClient from hypothesis.internal.detection import is_hypothesis_test -from . import edenclient, gitrepo, hgrepo, repobase, util +from . import edenclient, gitrepo, hgrepo, repobase set_up_hypothesis() diff --git a/eden/integration/mount_test.py b/eden/integration/mount_test.py index 676f66e817..4c3b18a434 100644 --- a/eden/integration/mount_test.py +++ b/eden/integration/mount_test.py @@ -10,7 +10,6 @@ import os import shutil import subprocess -import unittest from pathlib import Path from typing import Optional, Set diff --git a/eden/integration/persistence_test.py b/eden/integration/persistence_test.py index c78f30a76e..0d4ebe4c87 100644 --- a/eden/integration/persistence_test.py +++ b/eden/integration/persistence_test.py @@ -8,7 +8,6 @@ # of patent rights can be found in the PATENTS file in the same directory. import os -import unittest from typing import Dict from .lib import testcase diff --git a/eden/integration/restart_test.py b/eden/integration/restart_test.py index 095ca573f7..0e80cd538a 100644 --- a/eden/integration/restart_test.py +++ b/eden/integration/restart_test.py @@ -7,8 +7,6 @@ # LICENSE file in the root directory of this source tree. An additional grant # of patent rights can be found in the PATENTS file in the same directory. -import os -import pathlib import subprocess import sys import typing diff --git a/eden/integration/service_log_test.py b/eden/integration/service_log_test.py index 88c599bd5f..9e5609acad 100644 --- a/eden/integration/service_log_test.py +++ b/eden/integration/service_log_test.py @@ -7,10 +7,8 @@ # of patent rights can be found in the PATENTS file in the same directory. import pathlib -import subprocess from .lib.fake_edenfs import FakeEdenFS -from .lib.find_executables import FindExe from .lib.service_test_case import ( ManagedFakeEdenFSMixin, ServiceTestCaseBase, diff --git a/eden/integration/setattr_test.py b/eden/integration/setattr_test.py index 239dcf7c51..8513ece623 100644 --- a/eden/integration/setattr_test.py +++ b/eden/integration/setattr_test.py @@ -8,7 +8,6 @@ # of patent rights can be found in the PATENTS file in the same directory. import errno -import grp import os import stat import subprocess diff --git a/eden/integration/stale_test.py b/eden/integration/stale_test.py index 20644539cf..9b69adbef6 100644 --- a/eden/integration/stale_test.py +++ b/eden/integration/stale_test.py @@ -10,11 +10,10 @@ import errno import os import subprocess -from typing import Type import __manifest__ -from .lib import repobase, testcase +from .lib import testcase class StaleTest(testcase.HgRepoTestMixin, testcase.EdenRepoTest): diff --git a/make-client.py b/make-client.py index 42b535ea63..62664e1f59 100755 --- a/make-client.py +++ b/make-client.py @@ -16,7 +16,6 @@ import argparse import os import shutil import subprocess -import sys import tempfile import zipapp from pipes import quote as shellquote