mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 23:38:50 +03:00
util: use urlreq.unquote
pycompat.urlreq.unquote and pycompat.urlunquote effectively alias the same thing. pycompat.urlunquote is only used once in the code base. So let's switch to urlreq.unquote. "Effectively" in the above paragraph is because pycompat.urlreq.unquote aliases urllib.unquote and pycompat.urlunquote aliases urlparse.unquote on Python 2. You might think one of urllib.unquote and urlparse.unquote is an alias to the other, but you would be incorrect. In fact, these functions are copies of each other. There is even a comment in the CPython source code saying to keep them in sync. You can't make this up.
This commit is contained in:
parent
a0383567c2
commit
28ebe71a15
@ -2637,7 +2637,7 @@ class url(object):
|
||||
'path', 'fragment'):
|
||||
v = getattr(self, a)
|
||||
if v is not None:
|
||||
setattr(self, a, pycompat.urlunquote(v))
|
||||
setattr(self, a, urlreq.unquote(v))
|
||||
|
||||
def __repr__(self):
|
||||
attrs = []
|
||||
|
Loading…
Reference in New Issue
Block a user