facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-06 23:07:18 +03:00
Code Issues Projects Releases Wiki Activity

mononoke: log if derived data is not enabled

Browse Source 
Summary:
Before we start blocking generation of derived data let's start with logging if
derived data is not specified.

Reviewed By: farnz

Differential Revision: D19791523

fbshipit-source-id: 15bed8463f8a021de76a2878f06ec95d9fef877f
This commit is contained in:
Stanislau Hlebik 2020-02-10 01:39:17 -08:00 committed by Facebook Github Bot
parent 8abe1af621
commit 2b7e7e5676
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
eden/mononoke/blobrepo/src/repo.rs
View File

@ -763,6 +763,10 @@ impl BlobRepo {
self.changesets.clone()
}
pub fn get_derived_data_config(&self) -> &DerivedDataConfig {
&self.derived_data_config
}
fn store_file_change(
&self,
ctx: CoreContext,

13
eden/mononoke/derived_data/src/derive_impl.rs
View File

@ -37,6 +37,8 @@ define_stats! {
prefix = "mononoke.derived_data";
derived_data_latency:
dynamic_timeseries("{}.deriving.latency_ms", (derived_data_type: &'static str); Average),
derived_data_disabled:
dynamic_timeseries("{}.{}.derived_data_disabled", (repo_id: i32, derived_data_type: &'static str); Count),
}
const DERIVE_TRACE_THRESHOLD: Duration = Duration::from_secs(3);
@ -171,6 +173,16 @@ pub(crate) fn derive_impl<
.and_then(move |_| fetch_derived_may_panic(ctx, start_csid, derived_mapping))
}
fn log_if_disabled<Derived: BonsaiDerived>(repo: &BlobRepo) {
if !repo
.get_derived_data_config()
.derived_data_types
.contains(Derived::NAME)
{
STATS::derived_data_disabled.add_value(1, (repo.get_repoid().id(), Derived::NAME));
}
}
pub(crate) fn find_underived<
Derived: BonsaiDerived,
Mapping: BonsaiDerivedMapping<Value = Derived> + Send + Sync + Clone + 'static,
@ -181,6 +193,7 @@ pub(crate) fn find_underived<
start_csid: &ChangesetId,
limit: Option<u64>,
) -> impl Future<Item = HashMap<ChangesetId, Vec<ChangesetId>>, Error = Error> {
log_if_disabled::<Derived>(repo);
let changeset_fetcher = repo.get_changeset_fetcher();
// This is necessary to avoid visiting the same commit a lot of times in mergy repos
let visited: Arc<Mutex<HashSet<ChangesetId>>> = Arc::new(Mutex::new(HashSet::new()));