mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 00:14:35 +03:00
[RFC] convert: fix --datesort
The problem is that previously commit.date was used for sorting, but it's a string like "1 Jan xxx 2007", so it it wrong to use it for sorting. Another problem is that why we are using depth for sorting -- I have no clear answer -- it seems to be plain wrong. This patch is just an RFC.
This commit is contained in:
parent
ad0a9d7201
commit
2de575229a
@ -145,7 +145,8 @@ class converter(object):
|
||||
if pl:
|
||||
depth[n] = max([depth[p] for p in pl]) + 1
|
||||
|
||||
s = [(depth[n], self.commitcache[n].date, n) for n in s]
|
||||
s = [(depth[n], util.parsedate(self.commitcache[n].date), n)
|
||||
for n in s]
|
||||
s.sort()
|
||||
s = [e[2] for e in s]
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user