facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 07:17:55 +03:00
Code Issues Projects Releases Wiki Activity

[fastmanifest] don't use shell=True

Browse Source 
Test Plan: none

Reviewers: durham, lcharignon

Reviewed By: lcharignon

Subscribers: mitrandir, mjpieters

Differential Revision: https://phabricator.intern.facebook.com/D3468818

Tasks: 11683504

Signature: t1:3468818:1466695146:9bd98efec59fced0d99f712b7a1e4b855e6ae93e
This commit is contained in:
Tony Tung 2016-06-23 13:40:12 -07:00
parent ac63bda69a
commit 2eb056bf8e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fastmanifest/concurrency.py
View File

@ -183,7 +183,7 @@ if platform.system() == 'Windows':
# we can't use close_fds *and* redirect stdin. I'm not sure that we
# need to because the detached process has no console connection.
subprocess.Popen(
script, shell=True, env=env, close_fds=True,
script, env=env, close_fds=True,
creationflags=_creationflags)
else:
def runshellcommand(script, env):
@ -203,7 +203,7 @@ else:
# connect stdin to devnull to make sure the subprocess can't
# muck up that stream for mercurial.
subprocess.Popen(
script, shell=True, stdout=open(os.devnull, 'w'),
script, stdout=open(os.devnull, 'w'),
stderr=open(os.devnull, 'w'), stdin=open(os.devnull, 'r'),
env=env, close_fds=True, **newsession)
finally: