facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-09 16:31:02 +03:00
Code Issues Projects Releases Wiki Activity

cut catch-all exceptionStr overload

Browse Source 
Summary: There are no correct uses of the catch-all overload of `folly::exceptionStr`. Every use is a bug of some kind, leading to the impression that this overload ought to be removed.

Differential Revision: D26539622

fbshipit-source-id: dc2ca0781ea02f1327a334bb1fe2e533fa46d1b3
This commit is contained in:
Yedidya Feldblum 2021-02-26 12:17:05 -08:00 committed by Facebook GitHub Bot
parent 31b5ed02fd
commit 355f92564a
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
eden/fs/inodes/FileInode.cpp
View File

@ -534,9 +534,7 @@ folly::Future<bool> FileInode::isSameAsSlow(
return getSha1(fetchContext)
.thenTry([expectedBlobSha1](folly::Try<Hash>&& try_) {
if (try_.hasException()) {
XLOG(DBG2) << "Assuming changed: "
<< folly::exceptionStr(
try_.tryGetExceptionObject<std::exception>());
XLOG(DBG2) << "Assuming changed: " << try_.exception();
return false;
} else {
return try_.value() == expectedBlobSha1;
@ -584,9 +582,7 @@ folly::Future<bool> FileInode::isSameAs(
return folly::collectUnsafe(f1, f2).thenTry(
[](folly::Try<std::tuple<Hash, Hash>>&& try_) {
if (try_.hasException()) {
XLOG(DBG2) << "Assuming changed: "
<< folly::exceptionStr(
try_.tryGetExceptionObject<std::exception>());
XLOG(DBG2) << "Assuming changed: " << try_.exception();
return false;
} else {
auto hashes = std::move(try_).value();