facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-07 23:38:50 +03:00
Code Issues Projects Releases Wiki Activity

phabsend: make --amend the default

Browse Source 
The local tag feature was intended to make `phabsend` closer to `email`
workflow. But its experience is not great in multiple ways:

  - after rebase, obsoleted changesets are still visible because of tags
  - without obsstore, the association information will get lost
  - even with obsstore, things could go wrong with graft, export+import
  - no easy way to tell which Differential Revision a commit is associated

Therefore make `--amend` the default. People wanting the old behavior can
use `--no-amend`.

Differential Revision: https://phab.mercurial-scm.org/D511
This commit is contained in:
Jun Wu 2017-08-24 16:52:28 -07:00
parent e2464e037c
commit 3969533711
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/phabricator.py
View File

@ -7,9 +7,9 @@
"""simple Phabricator integration
This extension provides a ``phabsend`` command which sends a stack of
changesets to Phabricator without amending commit messages, and a ``phabread``
command which prints a stack of revisions in a format suitable
for :hg:`import`, and a ``phabupdate`` command to update statuses in batch.
changesets to Phabricator, and a ``phabread`` command which prints a stack of
revisions in a format suitable for :hg:`import`, and a ``phabupdate`` command
to update statuses in batch.
By default, Phabricator requires ``Test Plan`` which might prevent some
changeset from being sent. The requirement could be disabled by changing
@ -339,7 +339,7 @@ def userphids(repo, names):
@command('phabsend',
[('r', 'rev', [], _('revisions to send'), _('REV')),
('', 'amend', False, _('update commit messages')),
('', 'amend', True, _('update commit messages')),
('', 'reviewer', [], _('specify reviewers')),
('', 'confirm', None, _('ask for confirmation before sending'))],
_('REV [OPTIONS]'))