remove unnecessary list comprehensions

These result lists were only built for the side effects, and so a
normal loop is just as good and more straight-forward.
This commit is contained in:
Martin Geisler 2011-02-03 10:31:17 +01:00
parent 1e4894d773
commit 4009f00b54
3 changed files with 6 additions and 3 deletions

View File

@ -722,7 +722,8 @@ class workingctx(changectx):
def tags(self):
t = []
[t.extend(p.tags()) for p in self.parents()]
for p in self.parents():
t.extend(p.tags())
return t
def children(self):

View File

@ -86,7 +86,8 @@ def ignore(root, files, warn):
(f, inst.strerror))
allpats = []
[allpats.extend(patlist) for patlist in pats.values()]
for patlist in pats.values():
allpats.extend(patlist)
if not allpats:
return util.never

View File

@ -1242,7 +1242,8 @@ class localrepository(repo.repository):
self.ui.status(_("skipping missing subrepository: %s\n")
% subpath)
[l.sort() for l in r]
for l in r:
l.sort()
return r
def heads(self, start=None):