facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-11 01:07:15 +03:00
Code Issues Projects Releases Wiki Activity

mercurial_types: rename Node to HgId

Browse Source 
Summary: The `Node` type in Mercurial's Rust code was renamed to `HgId`, with an alias to `Node` to keep older code building. Let's rename the usages in Mononoke to `HgId` to reduce ambiguity and keep the terminology consistent with Mercurial.

Reviewed By: StanislavGlebik

Differential Revision: D20460543

fbshipit-source-id: f6d8e3aef42743370323cde79ec10b21de956313
This commit is contained in:
Arun Kulshreshtha 2020-03-19 01:39:57 -07:00 committed by Facebook GitHub Bot
parent bf866d3a21
commit 431a9c02b5
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
eden/mononoke/mercurial/types/src/nodehash.rs
View File

@ -20,8 +20,9 @@ use std::{
str::FromStr,
};
/// Node hash type from Mercurial's Rust code (essentially equivalent to [HgNodeHash]).
use types::Node as HgTypesNode;
/// Type used to represent a node hash in the Mercurial client's Rust code.
/// Equivalent to HgNodeHash;
use types::HgId;
use crate::hash::{self, Sha1, Sha1Prefix};
use crate::manifest::Type;
@ -123,15 +124,15 @@ impl From<Option<HgNodeHash>> for HgNodeHash {
}
}
impl From<HgNodeHash> for HgTypesNode {
impl From<HgNodeHash> for HgId {
fn from(node: HgNodeHash) -> Self {
HgTypesNode::from_byte_array(node.0.into_byte_array())
HgId::from_byte_array(node.0.into_byte_array())
}
}
impl From<HgTypesNode> for HgNodeHash {
fn from(node: HgTypesNode) -> Self {
Self::from_bytes(node.as_ref()).unwrap()
impl From<HgId> for HgNodeHash {
fn from(hgid: HgId) -> Self {
Self::from_bytes(hgid.as_ref()).unwrap()
}
}